From: Alex Dubov <oakad@yahoo.com>
To: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 05/11] tifm: fix the MemoryStick host fifo handling code
Date: Wed, 5 Mar 2008 18:30:46 -0800 (PST) [thread overview]
Message-ID: <996921.54635.qm@web36711.mail.mud.yahoo.com> (raw)
--- Andrew Morton <akpm@linux-foundation.org> wrote:
> On Wed, 5 Mar 2008 03:02:22 +1100
> oakad@exemail.com.au wrote:
>
> > + buf = kmap_atomic(pg, KM_BIO_SRC_IRQ) + p_off;
>
> I am unable to convince myself that this driver always has local IRQs
> disabled when altering the KM_BIO_SRC_IRQ slot. Does it?
>
diff did rather bad job with this patch. The place in question looks like:
211: local_irq_save(flags);
212: buf = kmap_atomic(pg, KM_BIO_SRC_IRQ) + p_off;
....
....
223: kunmap_atomic(buf - p_off, KM_BIO_SRC_IRQ);
224: local_irq_restore(flags);
____________________________________________________________________________________
Never miss a thing. Make Yahoo your home page.
http://www.yahoo.com/r/hs
next reply other threads:[~2008-03-06 2:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 2:30 Alex Dubov [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-03-04 16:02 MemoryStick driver updates oakad
2008-03-04 16:02 ` [PATCH 01/11] memstick: introduce correct definitions in the header oakad
2008-03-04 16:02 ` [PATCH 02/11] memstick: add memstick_suspend/resume_host methods oakad
2008-03-04 16:02 ` [PATCH 03/11] memstick: make sure number of command retries is exactly as specified oakad
2008-03-04 16:02 ` [PATCH 04/11] memstick: drop DRIVER_VERSION numbers as meaningless oakad
2008-03-04 16:02 ` [PATCH 05/11] tifm: fix the MemoryStick host fifo handling code oakad
2008-03-05 22:59 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=996921.54635.qm@web36711.mail.mud.yahoo.com \
--to=oakad@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.