All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Russon <rich@flatcap.org>
To: Harald von Fellenberg <harald.von-fellenberg@sun.com>
Cc: aia21@cus.cam.ac.uk, linux-ntfs-dev@lists.sourceforge.net,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: PROBLEM: NTFS  routine fs/ntfs/unistr.c does not compile
Date: 22 Aug 2001 13:20:25 +0100	[thread overview]
Message-ID: <998482825.1795.4.camel@home.flatcap.org> (raw)
In-Reply-To: <3B834ADD.3A466F48@sun.com>
In-Reply-To: <3B834ADD.3A466F48@sun.com>

Hi Harald,

> [1.] NTFS  routine fs/ntfs/unistr.c does not compile
> [2.] NTFS  routine fs/ntfs/unistr.c does not compile: the macro
> min(a,b,c) is not defined.

Yep.

> Comparison with Linux 2.4.7 revealed that
>      1. the pertaining line in unistr.c has changed from 2.4.7 to 2.4.9
>      2. the macro definition in file fs/ntfs/macros.h for macro min()
> has been dropped

Actually all the min/max macros have (finally) been moved to kernel.h.

>      The solution was straight forward: add the (three-parameter) macro
>      definition from include/linux/kernel.h to fs/ntfs/macros.h
>      The patch is added below

The correct solution is to add the following to unistr.c:

  #include <linux/kernel.h>

Cheers,
  FlatCap (Rich)
  ntfs@flatcap.org



      reply	other threads:[~2001-08-22 12:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-22  6:02 PROBLEM: NTFS routine fs/ntfs/unistr.c does not compile Harald von Fellenberg
2001-08-22 12:20 ` Richard Russon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=998482825.1795.4.camel@home.flatcap.org \
    --to=rich@flatcap.org \
    --cc=aia21@cus.cam.ac.uk \
    --cc=harald.von-fellenberg@sun.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-ntfs-dev@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.