From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30B75C433EF for ; Thu, 4 Nov 2021 21:29:08 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D759361213 for ; Thu, 4 Nov 2021 21:29:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D759361213 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636061346; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ehpn9Rv9HuUgpefczUvQTynL2dsif7G7qM5nijcmH88=; b=bQN2n9TyfFKzLdYBUkgjesVBjLKW8g43u03hQXgrs68p+1SQhnx9dfUOnEEujQ2SgVOVi0 LzjLk52betdA48TiTSqQBUKvjHlOoGNKzXO9vWfBKcSQLOarGboU9HViDti/Q484aj/1vC /g+aLE6bOmjC7qCfSk2h6JZGY9qXkB8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-519-Bce8lP9nMWqzYny30fa4dg-1; Thu, 04 Nov 2021 17:29:03 -0400 X-MC-Unique: Bce8lP9nMWqzYny30fa4dg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2687BEC1A0; Thu, 4 Nov 2021 21:29:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BED0860C17; Thu, 4 Nov 2021 21:28:59 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8405E4EA2A; Thu, 4 Nov 2021 21:28:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1A4LQTRP026745 for ; Thu, 4 Nov 2021 17:26:29 -0400 Received: by smtp.corp.redhat.com (Postfix) id B8DB560C17; Thu, 4 Nov 2021 21:26:29 +0000 (UTC) Received: from x2.localnet (unknown [10.22.18.115]) by smtp.corp.redhat.com (Postfix) with ESMTP id BA3E660BF1; Thu, 4 Nov 2021 21:26:17 +0000 (UTC) From: Steve Grubb To: Linux-Audit Mailing List , Richard Guy Briggs Subject: Re: [PATCH v1] add clock_adjtime to certification rulesets Date: Thu, 04 Nov 2021 17:26:17 -0400 Message-ID: <9986532.nUPlyArG6x@x2> Organization: Red Hat In-Reply-To: <20211104210110.3978025-1-rgb@redhat.com> References: <20211104210110.3978025-1-rgb@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: linux-audit@redhat.com X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hello Richard, On Thursday, November 4, 2021 5:01:10 PM EDT Richard Guy Briggs wrote: > The clock_adjtime syscall is missing from several certification rulesets > that monitor changes to the system clock. Add it. > > Please see https://bugzilla.redhat.com/show_bug.cgi?id=1991919 > > Signed-off-by: Richard Guy Briggs > --- > rules/30-nispom.rules | 4 ++-- > rules/30-pci-dss-v31.rules | 4 ++-- > rules/30-stig.rules | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/rules/30-nispom.rules b/rules/30-nispom.rules > index e3873ef95069..ecac01a0b4e1 100644 > --- a/rules/30-nispom.rules > +++ b/rules/30-nispom.rules > @@ -10,8 +10,8 @@ > ## Things that could affect time > -a always,exit -F arch=b32 -S adjtimex,settimeofday,stime -F key=time- > change > -a always,exit -F arch=b64 -S adjtimex,settimeofday -F key=time-change > --a always,exit -F arch=b32 -S clock_settime -F a0=0x0 -F key=time-change > --a always,exit -F arch=b64 -S clock_settime -F a0=0x0 -F key=time-change > +-a always,exit -F arch=b32 -S clock_settime,clock_adjtime -F a0=0x0 -F > key=time-change > +-a always,exit -F arch=b64 -S clock_settime,clock_adjtime -F a0=0x0 -F > key=time-change > # Introduced in 2.6.39, commented out because it can make false positives > #-a always,exit -F arch=b32 -S clock_adjtime -F key=time-change > #-a always,exit -F arch=b64 -S clock_adjtime -F key=time-change Not sure if you saw this, but directly under the change is a rule for that syscall, but it's commented out. This is because it is a very noisy event. Anyone that wants it can enable it. -Steve > diff --git a/rules/30-pci-dss-v31.rules b/rules/30-pci-dss-v31.rules > index 7062b35f165c..0251bcafcc03 100644 > --- a/rules/30-pci-dss-v31.rules > +++ b/rules/30-pci-dss-v31.rules > @@ -77,8 +77,8 @@ > ## We will place rules to check time synchronization > -a always,exit -F arch=b32 -S adjtimex,settimeofday,stime -F > key=10.4.2b-time-change -a always,exit -F arch=b64 -S > adjtimex,settimeofday -F key=10.4.2b-time-change --a always,exit -F > arch=b32 -S clock_settime -F a0=0x0 -F key=10.4.2b-time-change --a > always,exit -F arch=b64 -S clock_settime -F a0=0x0 -F > key=10.4.2b-time-change +-a always,exit -F arch=b32 -S > clock_settime,clock_adjtime -F a0=0x0 -F key=10.4.2b-time-change +-a > always,exit -F arch=b64 -S clock_settime,clock_adjtime -F a0=0x0 -F > key=10.4.2b-time-change # Introduced in 2.6.39, commented out because it > can make false positives #-a always,exit -F arch=b32 -S clock_adjtime -F > key=10.4.2b-time-change #-a always,exit -F arch=b64 -S clock_adjtime -F > key=10.4.2b-time-change diff --git a/rules/30-stig.rules > b/rules/30-stig.rules > index 234f239cac06..60384f6b247d 100644 > --- a/rules/30-stig.rules > +++ b/rules/30-stig.rules > @@ -26,8 +26,8 @@ > ## Things that could affect time > -a always,exit -F arch=b32 -S adjtimex,settimeofday,stime -F > key=time-change -a always,exit -F arch=b64 -S adjtimex,settimeofday -F > key=time-change --a always,exit -F arch=b32 -S clock_settime -F a0=0x0 -F > key=time-change --a always,exit -F arch=b64 -S clock_settime -F a0=0x0 -F > key=time-change +-a always,exit -F arch=b32 -S clock_settime,clock_adjtime > -F a0=0x0 -F key=time-change +-a always,exit -F arch=b64 -S > clock_settime,clock_adjtime -F a0=0x0 -F key=time-change # Introduced in > 2.6.39, commented out because it can make false positives #-a always,exit > -F arch=b32 -S clock_adjtime -F key=time-change > #-a always,exit -F arch=b64 -S clock_adjtime -F key=time-change -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit