From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18C55C369C2 for ; Tue, 22 Apr 2025 12:52:55 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.962639.1353810 (Exim 4.92) (envelope-from ) id 1u7D7B-0001g8-Tx; Tue, 22 Apr 2025 12:52:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 962639.1353810; Tue, 22 Apr 2025 12:52:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1u7D7B-0001g1-Q7; Tue, 22 Apr 2025 12:52:41 +0000 Received: by outflank-mailman (input) for mailman id 962639; Tue, 22 Apr 2025 12:52:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1u7D7A-0001fv-6N for xen-devel@lists.xenproject.org; Tue, 22 Apr 2025 12:52:40 +0000 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [2a00:1450:4864:20::331]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ab28768a-1f78-11f0-9ffb-bf95429c2676; Tue, 22 Apr 2025 14:52:37 +0200 (CEST) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-43cef035a3bso35467395e9.1 for ; Tue, 22 Apr 2025 05:52:37 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4a4856sm14929166f8f.81.2025.04.22.05.52.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Apr 2025 05:52:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab28768a-1f78-11f0-9ffb-bf95429c2676 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1745326357; x=1745931157; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=bE/jHnlYVgixbgWAMsy/KdCYr+LmN1M00uv5a0GYY6I=; b=cuPQUka9c8jvP+sFgTBBM+5AaL0kh+YmHYQNu7e7U/Bw0wBPcCq4CrVklz62Tuz7nY MHC4I8xxOUhQxq3ESTWArO946n/sz8zRgGQJEyMTEAFD7Lt98vhr8/CKBvdAfHZyHj2F QSvYFEB8fj+ldFK75y4De5nPVBYVMYzAmuihbTs/fdgzjDoFIsOPMiRfep1pYV8JBNs3 Py/+/rO0Aw7JDRSNLAiC+OPoucjXuaD/QiAtA1BYAqt3/Q7ruhDRndkbmQ2UZRi8AoKI V8ikrzWaBtloIGmea3Jr+3DpJq5PB+sMiIGu8N6gbGr0YN31SbsNXfyvTP+tREMqUoF8 OHXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745326357; x=1745931157; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bE/jHnlYVgixbgWAMsy/KdCYr+LmN1M00uv5a0GYY6I=; b=YfANFf6om1ZKaJzc/XwCZ20m0+sq1UeyFjNrZmISTRYbv+J6qYijAX5to/wiOt64Vo u2MLIkIvQ5cUC3OUfqvfgEqxjYgLThfXM2inVJwXNjv2Lh5tF2ox7m3ya+gPM0n3r2qk 6L5JB5yhxwTfMkyoSZ8STcrRc5P7xj0NJNDT8bRJOyBW1qVe1sC60dYN+AcNISB0nqt9 Fd8xQP8bwcoiXL9MYaIAzMc6GYxBAl4zKeiVrwWlhWmMut6bxfjXBMRZgUG69KOnMWbj nqMknQ75n8RMM9JPrDjjoOLi+0QN746i4oEhkOU5rVxfA3baALmaGe8LD/z43IvXi0S7 DgqA== X-Forwarded-Encrypted: i=1; AJvYcCWbe2GVD6G9SxRe4xsMa2yV3ZQvw5jye2GQ8vQJ+g3jhQrIvVkIodEX+0zRJr7ww+5e/qLZVqy0/lI=@lists.xenproject.org X-Gm-Message-State: AOJu0YwFbbI6uUnojgQOqiUgRkXp1QaSIzNt4wvJ7swUdF0riQt+Kv19 af0wSSvm3XxdjjlQsjesUVOpXUga4wnnWmU2uQGlZMoRFuSmiWIC/jgSaOIZSA== X-Gm-Gg: ASbGncteZSzo8IPnSWS7UgnSmUwhTtMI6J8YAyj7fR8N8c0jc35EYAMhkIOVPsbspLi AdeHFPY5yovYHYqMM9xbdB2IQCJ8LunIIXAJuraOHJuR3bycg9emGZhwcGZXRQwcjJe86ZOKVFh r8MPsJZyOBVshoLgx5bo/gpMfH8AfvxeolUKmLQK8RlAIubEdQi952r5lr+ccLlciS7HBy2amMw XqmqX7IrTpOD+mqz6rBcErI9rf7KUj08AniQPXCCEUb8h1d3ur/puaQ2uOPpN8XSRXBlfuBBO6G yTYpSfVp1arvVd1rQSWn55NPZ4IX7/igF75bJmu8LfEl/luS2tn9wigfMsNgBW+dw2wHWuvGo2C yD/IMEN/cMZFiP6xbdSxgipt2/g== X-Google-Smtp-Source: AGHT+IEKobdzgQVn3tWdMvVuaZwFKRs1j63qCbgoiumvlDSXlviK5Bg7pGUWWjQKHIQmFnPYHimm9Q== X-Received: by 2002:a05:600c:4fcf:b0:440:6a37:be0d with SMTP id 5b1f17b1804b1-4406abb245cmr146779015e9.15.1745326357216; Tue, 22 Apr 2025 05:52:37 -0700 (PDT) Message-ID: <9990d438-6ebf-4308-89f5-ecacf04ea89b@suse.com> Date: Tue, 22 Apr 2025 14:52:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] xen: Use asm inline when available for alternatives To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Michal Orzel , Xen-devel References: <20250422113957.1289290-1-andrew.cooper3@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20250422113957.1289290-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 22.04.2025 13:39, Andrew Cooper wrote: > Compilers estimate the size of an asm() block for inlining purposes. > > Constructs such as ALTERNATIVE appear large due to the metadata, depsite often > only being a handful of instructions. asm inline() overrides the estimation > to identify the block as being small. > > This has a substantial impact on inlining decisions, expected to be for the > better given that the compiler has a more accurate picture to work with. > > Signed-off-by: Andrew Cooper So this is effectively a generalized version of https://lists.xen.org/archives/html/xen-devel/2022-08/msg00712.html with ... > --- a/xen/Kconfig > +++ b/xen/Kconfig > @@ -29,6 +29,10 @@ config LD_IS_GNU > config LD_IS_LLVM > def_bool $(success,$(LD) --version | head -n 1 | grep -q "^LLD") > > +config CC_HAS_ASM_INLINE > + # GCC >= 9, Clang >= 11 > + def_bool $(success,echo 'void foo(void) { asm inline (""); }' | $(CC) -x c - -c -o /dev/null) ... detection once again done in Kconfig (only). I don't think I had any feedback there; I'm hence having a hard time seeing why I should now like this any better than mine was liked. In any event it's clearly increasingly necessary that we finally get the detection aspect settled. Jan