All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Geliang Tang <geliang.tang@suse.com>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next] tcp: Add mss zero checks to avoid divide errors
Date: Fri, 09 Sep 2022 16:44:37 +0200	[thread overview]
Message-ID: <99b1363eeecf160159bbe9f37e38221e93baef55.camel@redhat.com> (raw)
In-Reply-To: <48ba286b429284accc457e34c6580efcdec593c4.1662725968.git.geliang.tang@suse.com>

On Fri, 2022-09-09 at 20:19 +0800, Geliang Tang wrote:
> If mss_now is set to zero when invoking tcp_push(), this divide error will occur:

We should not call at all tcp_push() in such situation. How did you
reproduce the issue?

Adding more check in TCP for the above situation is very likely not the
correct thing to do. Instead we should prevent MPTCP from reaching for
tcp_push() in the critical situation.

Thanks!

Paolo


  parent reply	other threads:[~2022-09-09 14:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-09 12:19 [PATCH mptcp-next] tcp: Add mss zero checks to avoid divide errors Geliang Tang
2022-09-09 14:12 ` tcp: Add mss zero checks to avoid divide errors: Tests Results MPTCP CI
2022-09-09 14:44 ` Paolo Abeni [this message]
2022-09-23  2:24   ` [PATCH mptcp-next] tcp: Add mss zero checks to avoid divide errors Geliang Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99b1363eeecf160159bbe9f37e38221e93baef55.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=geliang.tang@suse.com \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.