All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiang Gao <hsiangkao@linux.alibaba.com>
To: Yue Hu <zbestahu@gmail.com>
Cc: Yue Hu <huyue2@coolpad.com>,
	linux-erofs@lists.ozlabs.org, zhangwen@coolpad.com
Subject: Re: [RFC PATCH] erofs-utils: fsck: support fragments
Date: Wed, 4 Jan 2023 15:28:42 +0800	[thread overview]
Message-ID: <99d24ef5-c72a-80ea-9ea5-2b7e1e60af79@linux.alibaba.com> (raw)
In-Reply-To: <20230104152651.000051df.zbestahu@gmail.com>



On 2023/1/4 15:26, Yue Hu wrote:

...

>>
>> I think we could just export parts of erofs_pread() to clean up the
>> whole erofs_verify_inode_data()...
> 
> What's the clean up referring to?
> 
> However, i think erofs_verify_inode_data() looks a little duplicate compared to erofs_read_raw_data/z_erofs_read_data().

We should reuse the main part (for example, by introducing an interface 
to accept mapping) of
erofs_read_raw_data() and z_erofs_read_data() to avoid duplicated code 
in erofs_verify_inode_data().

Thanks,
Gao Xiang

> 
>>
>> Thanks,
>> Gao Xiang
>>
>>

  reply	other threads:[~2023-01-04  7:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-24  9:43 [RFC PATCH] erofs-utils: fsck: support fragments Yue Hu
2023-01-04  2:48 ` Xiang Gao
2023-01-04  3:24   ` Yue Hu
2023-01-04  3:32     ` Xiang Gao
2023-01-04  7:26       ` Yue Hu
2023-01-04  7:28         ` Xiang Gao [this message]
2023-01-04  7:42           ` Yue Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99d24ef5-c72a-80ea-9ea5-2b7e1e60af79@linux.alibaba.com \
    --to=hsiangkao@linux.alibaba.com \
    --cc=huyue2@coolpad.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=zbestahu@gmail.com \
    --cc=zhangwen@coolpad.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.