From: Tao Xu <tao3.xu@intel.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
"Li, Xiaoyao" <xiaoyao.li@intel.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v2] target/i386: Add ARCH_CAPABILITIES related bits into Icelake-Server CPU model
Date: Tue, 24 Mar 2020 08:23:41 +0800 [thread overview]
Message-ID: <99e35e3c-c797-ea54-4a55-dfe628cb7d2f@intel.com> (raw)
In-Reply-To: <20200323183936.GA3784@habkost.net>
On 3/24/2020 2:39 AM, Eduardo Habkost wrote:
> On Mon, Mar 23, 2020 at 10:58:16AM +0800, Xiaoyao Li wrote:
>> On 3/23/2020 10:32 AM, Tao Xu wrote:
>>> Hi Xiaoyao,
>>>
>>> May be you can add .note for this new version.
>>>
>>> for example:
>>>
>>> + .version = 3,
>>> + .note = "ARCH_CAPABILITIES",
>>> + .props = (PropValue[]) {
>>
>> Hi Paolo and Eduardo,
>>
>> Need I spin a new version to add the .note ?
>> Maybe you can add it when queue?
>
> Please send a follow up patch so we don't hold a bug fix because
> of something that's just cosmetic. I will queue this patch. We
> still need a new version of "target/i386: Add notes for versioned
> CPU models"[1], don't we?
>
> [1] https://lore.kernel.org/qemu-devel/20200228215253.GB494511@habkost.net/
>
I am sorry for misunderstanding your comments in that patch[1]. I will
submit a new version of this patch.
prev parent reply other threads:[~2020-03-24 0:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 9:56 [PATCH v2] target/i386: Add ARCH_CAPABILITIES related bits into Icelake-Server CPU model Xiaoyao Li
2020-03-23 2:32 ` Tao Xu
2020-03-23 2:58 ` Xiaoyao Li
2020-03-23 18:39 ` Eduardo Habkost
2020-03-24 0:23 ` Tao Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99e35e3c-c797-ea54-4a55-dfe628cb7d2f@intel.com \
--to=tao3.xu@intel.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.