From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31C2EC7EE29 for ; Wed, 7 Jun 2023 13:05:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686143156; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=10mifJxFyaj7/ZO7yw2Ql5ZTIIOXYQrB54cWnl8eENg=; b=QGFWI6KTsi9c5HLI4rTKDZKRppqvIz6zBNMhcHe8d757Ls4PT2XWYStE+Ud7JJNC9y7tOX V7Axa4oXNNdlxdVKZdvbJYnpMnS5mwS7KoM4dZ4ibt6XReMii1VUgtWGDmZuZlEQXejzkp JDEy68fP0h3tXhn56BmHzAaW+moPNUA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-517-uFSf2NBcP66GNAIC3FduWg-1; Wed, 07 Jun 2023 09:05:52 -0400 X-MC-Unique: uFSf2NBcP66GNAIC3FduWg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 926423C0F232; Wed, 7 Jun 2023 13:05:50 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 81EA140D1B66; Wed, 7 Jun 2023 13:05:50 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 724D819452C3; Wed, 7 Jun 2023 13:05:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id DEC1119465BA for ; Wed, 7 Jun 2023 13:05:48 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id BC76B40D1B68; Wed, 7 Jun 2023 13:05:48 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B59B640D1B66 for ; Wed, 7 Jun 2023 13:05:48 +0000 (UTC) Received: from us-smtp-inbound-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 998F3101B048 for ; Wed, 7 Jun 2023 13:05:48 +0000 (UTC) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-5VsNUcOoPkmoPZKVT2hm-g-1; Wed, 07 Jun 2023 09:05:46 -0400 X-MC-Unique: 5VsNUcOoPkmoPZKVT2hm-g-1 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EEFDA21A00; Wed, 7 Jun 2023 13:05:44 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BB4031346D; Wed, 7 Jun 2023 13:05:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YVNqLaiAgGR2WwAAMHmgww (envelope-from ); Wed, 07 Jun 2023 13:05:44 +0000 Message-ID: <99fc97ec-45ed-7dcf-e53f-e14c8831e678@suse.de> Date: Wed, 7 Jun 2023 15:05:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 To: Christoph Hellwig , Jens Axboe References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-22-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20230606073950.225178-22-hch@lst.de> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Subject: Re: [dm-devel] [PATCH 21/31] scsi: replace the fmode_t argument to ->sg_io_fn with a simple bool X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , "Rafael J. Wysocki" , linux-nvme@lists.infradead.org, Phillip Potter , Chris Mason , dm-devel@redhat.com, "Md. Haris Iqbal" , Pavel Machek , Miquel Raynal , Jack Wang , linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, Richard Weinberger , linux-pm@vger.kernel.org, linux-um@lists.infradead.org, Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, Alexander Viro , David Sterba , Christian Brauner , "Martin K. Petersen" , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-btrfs@vger.kernel.org Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: suse.de Content-Language: en-US Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" On 6/6/23 09:39, Christoph Hellwig wrote: > Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass > a bool open_for_write to prepare for callers that won't have the fmode_t. > > Signed-off-by: Christoph Hellwig > --- > block/bsg-lib.c | 2 +- > block/bsg.c | 8 +++++--- > drivers/scsi/scsi_bsg.c | 4 ++-- > include/linux/bsg.h | 2 +- > 4 files changed, 9 insertions(+), 7 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14122C7EE2F for ; Wed, 7 Jun 2023 13:05:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239335AbjFGNFt (ORCPT ); Wed, 7 Jun 2023 09:05:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233152AbjFGNFs (ORCPT ); Wed, 7 Jun 2023 09:05:48 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4628910DE; Wed, 7 Jun 2023 06:05:46 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EEFDA21A00; Wed, 7 Jun 2023 13:05:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686143144; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u6+vpKfau0iKqyo79MzZYvFgo2CWRimrv/MEFMfrr24=; b=fpyIDozRfR7Cw5m06Ago2OaY4vdqSadihaZ5yyCOf6Kte48Hg2kKTnOyYPGeQZe44HLFDq s6HTof/SA8wZCUu9OFNTDHJFXBqLWBL4GN/FCRwcp4Jn7Mdc0a0G5cBqpsPjqNn7SV3BhS bX1WwtlSqwCJfLNgkkDWf1hnAp4Acrs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686143144; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u6+vpKfau0iKqyo79MzZYvFgo2CWRimrv/MEFMfrr24=; b=469Bq6Wif5eIWsabvA+s5g95VvmQctUcubNCWgwGeYHM4htPaM0E32GlVKkGZ0MPLthDEA VCex8psY6mgl5jCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BB4031346D; Wed, 7 Jun 2023 13:05:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YVNqLaiAgGR2WwAAMHmgww (envelope-from ); Wed, 07 Jun 2023 13:05:44 +0000 Message-ID: <99fc97ec-45ed-7dcf-e53f-e14c8831e678@suse.de> Date: Wed, 7 Jun 2023 15:05:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 21/31] scsi: replace the fmode_t argument to ->sg_io_fn with a simple bool Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , Christian Brauner , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-22-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20230606073950.225178-22-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On 6/6/23 09:39, Christoph Hellwig wrote: > Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass > a bool open_for_write to prepare for callers that won't have the fmode_t. > > Signed-off-by: Christoph Hellwig > --- > block/bsg-lib.c | 2 +- > block/bsg.c | 8 +++++--- > drivers/scsi/scsi_bsg.c | 4 ++-- > include/linux/bsg.h | 2 +- > 4 files changed, 9 insertions(+), 7 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC9DCC77B7A for ; Wed, 7 Jun 2023 13:05:59 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1q6srP-0000Qs-JO; Wed, 07 Jun 2023 13:05:59 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q6srL-0000Qb-AR for linux-f2fs-devel@lists.sourceforge.net; Wed, 07 Jun 2023 13:05:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=u6+vpKfau0iKqyo79MzZYvFgo2CWRimrv/MEFMfrr24=; b=IqnSNzWV8sg88YkEB5OVbx98IV 7IXW+91aAKGjRfx4b7rE5yW8fkj65cR/k5m2RN5UyKG3ycjv2p6ImdX3jZMaU8/shJf3KiODS9kCX QzGax8gg+/9qkzHklpbUALjweJAp3rgPp5h8kpzGc2h7rBsP6qDDzpJPQBLb55mEz/h8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=u6+vpKfau0iKqyo79MzZYvFgo2CWRimrv/MEFMfrr24=; b=YYgr28h2B0lRzxeaNb/BPjrK/S Z0GRszbVxIaB8tqTtTVRkrwDfnX3EG6ncS0LRggOSOhDagFvlC9DsSEq14AGg5GRlDkMrUmfeTrGt RKLB3acEMvrX70JE1ACbWj1CCNt4MRVl+0xJlU6DThWnNmyLtD+TBR7e2ugAWx15yg44=; Received: from smtp-out1.suse.de ([195.135.220.28]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1q6srH-00Dhqw-7H for linux-f2fs-devel@lists.sourceforge.net; Wed, 07 Jun 2023 13:05:55 +0000 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EEFDA21A00; Wed, 7 Jun 2023 13:05:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686143144; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u6+vpKfau0iKqyo79MzZYvFgo2CWRimrv/MEFMfrr24=; b=fpyIDozRfR7Cw5m06Ago2OaY4vdqSadihaZ5yyCOf6Kte48Hg2kKTnOyYPGeQZe44HLFDq s6HTof/SA8wZCUu9OFNTDHJFXBqLWBL4GN/FCRwcp4Jn7Mdc0a0G5cBqpsPjqNn7SV3BhS bX1WwtlSqwCJfLNgkkDWf1hnAp4Acrs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686143144; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u6+vpKfau0iKqyo79MzZYvFgo2CWRimrv/MEFMfrr24=; b=469Bq6Wif5eIWsabvA+s5g95VvmQctUcubNCWgwGeYHM4htPaM0E32GlVKkGZ0MPLthDEA VCex8psY6mgl5jCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BB4031346D; Wed, 7 Jun 2023 13:05:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YVNqLaiAgGR2WwAAMHmgww (envelope-from ); Wed, 07 Jun 2023 13:05:44 +0000 Message-ID: <99fc97ec-45ed-7dcf-e53f-e14c8831e678@suse.de> Date: Wed, 7 Jun 2023 15:05:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Christoph Hellwig , Jens Axboe References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-22-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20230606073950.225178-22-hch@lst.de> X-Headers-End: 1q6srH-00Dhqw-7H Subject: Re: [f2fs-dev] [PATCH 21/31] scsi: replace the fmode_t argument to ->sg_io_fn with a simple bool X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , "Rafael J. Wysocki" , linux-nvme@lists.infradead.org, Phillip Potter , Chris Mason , dm-devel@redhat.com, "Md. Haris Iqbal" , Pavel Machek , Miquel Raynal , Jack Wang , linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, Richard Weinberger , linux-pm@vger.kernel.org, linux-um@lists.infradead.org, Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, Alexander Viro , David Sterba , Christian Brauner , "Martin K. Petersen" , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-btrfs@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 6/6/23 09:39, Christoph Hellwig wrote: > Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass > a bool open_for_write to prepare for callers that won't have the fmode_t. > > Signed-off-by: Christoph Hellwig > --- > block/bsg-lib.c | 2 +- > block/bsg.c | 8 +++++--- > drivers/scsi/scsi_bsg.c | 4 ++-- > include/linux/bsg.h | 2 +- > 4 files changed, 9 insertions(+), 7 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH 21/31] scsi: replace the fmode_t argument to ->sg_io_fn with a simple bool Date: Wed, 7 Jun 2023 15:05:44 +0200 Message-ID: <99fc97ec-45ed-7dcf-e53f-e14c8831e678@suse.de> References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-22-hch@lst.de> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686143144; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u6+vpKfau0iKqyo79MzZYvFgo2CWRimrv/MEFMfrr24=; b=fpyIDozRfR7Cw5m06Ago2OaY4vdqSadihaZ5yyCOf6Kte48Hg2kKTnOyYPGeQZe44HLFDq s6HTof/SA8wZCUu9OFNTDHJFXBqLWBL4GN/FCRwcp4Jn7Mdc0a0G5cBqpsPjqNn7SV3BhS bX1WwtlSqwCJfLNgkkDWf1hnAp4Acrs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686143144; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u6+vpKfau0iKqyo79MzZYvFgo2CWRimrv/MEFMfrr24=; b=469Bq6Wif5eIWsabvA+s5g95VvmQctUcubNCWgwGeYHM4htPaM0E32GlVKkGZ0MPLthDEA VCex8psY6mgl5jCg== Content-Language: en-US In-Reply-To: <20230606073950.225178-22-hch@lst.de> List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Christoph Hellwig , Jens Axboe Cc: Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , Christian Brauner , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org On 6/6/23 09:39, Christoph Hellwig wrote: > Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass > a bool open_for_write to prepare for callers that won't have the fmode_t. > > Signed-off-by: Christoph Hellwig > --- > block/bsg-lib.c | 2 +- > block/bsg.c | 8 +++++--- > drivers/scsi/scsi_bsg.c | 4 ++-- > include/linux/bsg.h | 2 +- > 4 files changed, 9 insertions(+), 7 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85983C83005 for ; Wed, 7 Jun 2023 13:05:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QzFqeH8eAvL1KqYJMNt2R/zokY2amthvkEWfPwROxjI=; b=DxbJvVHHxpTv74 6nj5P5uWMqb8XAbDy/r0UKb6w3WWs34hptUTIEWuSyAkWQuRgfhRpHr9EqrOcvQic/Zv525SIu8O0 vSgORojlJPbzuEvGBJ8W3EbvgAajBBhuSmLNqlwGm7UM6KWKwgy3DJPth/KqbYm7YiDnEqsZZE1Mz AMF3fvymmqxF7X4vQzoHk1At8hQbKMmDjsUYsxVnzyVsBwTd3WQ9/YAjE+w0PialxnHkL/l39qBlz idU21NgOp8H9g6/Sg+HdKIl9iJPUg4XPp9zC0T1kcM7xTuU0UHAzVDxfLjFfD4/ADNT/LcWJRQ7eG oZL35Qc/oqIt4f5wZgOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6srE-0060JB-1H; Wed, 07 Jun 2023 13:05:48 +0000 Received: from smtp-out1.suse.de ([195.135.220.28]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6srC-0060IR-1W; Wed, 07 Jun 2023 13:05:47 +0000 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EEFDA21A00; Wed, 7 Jun 2023 13:05:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686143144; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u6+vpKfau0iKqyo79MzZYvFgo2CWRimrv/MEFMfrr24=; b=fpyIDozRfR7Cw5m06Ago2OaY4vdqSadihaZ5yyCOf6Kte48Hg2kKTnOyYPGeQZe44HLFDq s6HTof/SA8wZCUu9OFNTDHJFXBqLWBL4GN/FCRwcp4Jn7Mdc0a0G5cBqpsPjqNn7SV3BhS bX1WwtlSqwCJfLNgkkDWf1hnAp4Acrs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686143144; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u6+vpKfau0iKqyo79MzZYvFgo2CWRimrv/MEFMfrr24=; b=469Bq6Wif5eIWsabvA+s5g95VvmQctUcubNCWgwGeYHM4htPaM0E32GlVKkGZ0MPLthDEA VCex8psY6mgl5jCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BB4031346D; Wed, 7 Jun 2023 13:05:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YVNqLaiAgGR2WwAAMHmgww (envelope-from ); Wed, 07 Jun 2023 13:05:44 +0000 Message-ID: <99fc97ec-45ed-7dcf-e53f-e14c8831e678@suse.de> Date: Wed, 7 Jun 2023 15:05:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 21/31] scsi: replace the fmode_t argument to ->sg_io_fn with a simple bool Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , Christian Brauner , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-22-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20230606073950.225178-22-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230607_060546_651619_BCAE220A X-CRM114-Status: GOOD ( 12.36 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On 6/6/23 09:39, Christoph Hellwig wrote: > Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass > a bool open_for_write to prepare for callers that won't have the fmode_t. > > Signed-off-by: Christoph Hellwig > --- > block/bsg-lib.c | 2 +- > block/bsg.c | 8 +++++--- > drivers/scsi/scsi_bsg.c | 4 ++-- > include/linux/bsg.h | 2 +- > 4 files changed, 9 insertions(+), 7 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B872C77B7A for ; Wed, 7 Jun 2023 13:05:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=86mfd+G1cA4lYlLhVM3M7je02g51jfab8waHfLFkksM=; b=WT6rhXIDp9Pyua zk02RLeIAsay100bhYlwmBMsilX33TZx9wtfN/nwehCCI11ACrpR2yt/Mq6hX7FMXrhrKJ6ePv4v7 +LVyHXkqPB4qsq/frs+0aFGsYIDnFL9DAmIcw//F1r8of5kVzv0f86YXZohwAeVLhs3CYNTeUeK6r KYrzy7vAFDxN+W4yo/KSO+T+E2hTyHCu1o+e+PkwVg8yBKwr5Mf/QzwQLAFhd0PQN7uW/Bm5ZeSJF SdKywIKt3cNjXVLjh0VockyCeVS/tRzT2t9fdktPSoHapTlRm3HxY2aR96KWjEolwyf91CqdFfx4u yGXi6+BWpTDpVi5eTpdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6srG-0060Jt-28; Wed, 07 Jun 2023 13:05:50 +0000 Received: from smtp-out1.suse.de ([195.135.220.28]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6srC-0060IR-1W; Wed, 07 Jun 2023 13:05:47 +0000 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EEFDA21A00; Wed, 7 Jun 2023 13:05:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686143144; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u6+vpKfau0iKqyo79MzZYvFgo2CWRimrv/MEFMfrr24=; b=fpyIDozRfR7Cw5m06Ago2OaY4vdqSadihaZ5yyCOf6Kte48Hg2kKTnOyYPGeQZe44HLFDq s6HTof/SA8wZCUu9OFNTDHJFXBqLWBL4GN/FCRwcp4Jn7Mdc0a0G5cBqpsPjqNn7SV3BhS bX1WwtlSqwCJfLNgkkDWf1hnAp4Acrs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686143144; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u6+vpKfau0iKqyo79MzZYvFgo2CWRimrv/MEFMfrr24=; b=469Bq6Wif5eIWsabvA+s5g95VvmQctUcubNCWgwGeYHM4htPaM0E32GlVKkGZ0MPLthDEA VCex8psY6mgl5jCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BB4031346D; Wed, 7 Jun 2023 13:05:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YVNqLaiAgGR2WwAAMHmgww (envelope-from ); Wed, 07 Jun 2023 13:05:44 +0000 Message-ID: <99fc97ec-45ed-7dcf-e53f-e14c8831e678@suse.de> Date: Wed, 7 Jun 2023 15:05:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 21/31] scsi: replace the fmode_t argument to ->sg_io_fn with a simple bool Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , Christian Brauner , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-22-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20230606073950.225178-22-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230607_060546_651619_BCAE220A X-CRM114-Status: GOOD ( 12.36 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org On 6/6/23 09:39, Christoph Hellwig wrote: > Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass > a bool open_for_write to prepare for callers that won't have the fmode_t. > > Signed-off-by: Christoph Hellwig > --- > block/bsg-lib.c | 2 +- > block/bsg.c | 8 +++++--- > drivers/scsi/scsi_bsg.c | 4 ++-- > include/linux/bsg.h | 2 +- > 4 files changed, 9 insertions(+), 7 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um