From: Thorsten Blum <thorsten.blum@linux.dev>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Ioana Ciornei <ioana.ciornei@nxp.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] bus: fsl-mc: Use strscpy() instead of strscpy_pad()
Date: Tue, 29 Apr 2025 14:45:21 +0200 [thread overview]
Message-ID: <9DDEEADA-BD78-4F4D-97AA-DCC683B2C7D0@linux.dev> (raw)
In-Reply-To: <17c35382-36c2-44e6-b553-e66a32a8c47e@csgroup.eu>
Hi Christophe,
On 29. Apr 2025, at 13:58, Christophe Leroy wrote:
> Le 29/04/2025 à 13:47, Ioana Ciornei a écrit:
>> On Tue, Apr 29, 2025 at 12:41:48PM +0200, Thorsten Blum wrote:
>>> Both destination buffers are already zero-initialized, making strscpy()
>>> sufficient for safely copying 'obj_type'. The additional NUL-padding
>>> performed by strscpy_pad() is unnecessary.
>>>
>>> If the destination buffer has a fixed length, strscpy() automatically
>>> determines its size using sizeof() when the argument is omitted. This
>>> makes the explicit size arguments unnecessary.
>>>
>>> No functional changes intended.
>>>
>>> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
>> Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
>> Christophe, could you also pick-up this patch when you have a chance?
>
> Sure I will take it when time comes, but again I'd expect an explanation inside the patch (below the ---) for the resend. I now have this patch twice in the list and don't know why, see https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=&submitter=&state=&q=&archive=&delegate=61610
A "resend" is meant as a "ping" and the patch is always unmodified, at
least that's my understanding of it. So there's no particular reason
other than: "Did you see my patch? Let me send it again just to be sure
you didn't miss it."
From [1]: "Don’t add “RESEND” when you are submitting a modified version
of your patch or patch series - “RESEND” only applies to resubmission of
a patch or patch series which have not been modified in any way from the
previous submission."
The patches are identical - just pick one.
Thanks,
Thorsten
[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#don-t-get-discouraged-or-impatient
next prev parent reply other threads:[~2025-04-29 12:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 10:41 [RESEND PATCH] bus: fsl-mc: Use strscpy() instead of strscpy_pad() Thorsten Blum
2025-04-29 11:47 ` Ioana Ciornei
2025-04-29 11:58 ` Christophe Leroy
2025-04-29 12:45 ` Thorsten Blum [this message]
2025-05-17 10:19 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9DDEEADA-BD78-4F4D-97AA-DCC683B2C7D0@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=christophe.leroy@csgroup.eu \
--cc=ioana.ciornei@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.