Re: [PATCH] iio: adc: ad799x: add reference supply for ad7994

[Stefano Manni <stefano.manni@gmail.com>]

Hi Andy,

On mar, ago 5 2025 at 15:13:06 +02:00:00, Andy Shevchenko 
<andy.shevchenko@gmail.com> wrote:
> On Tue, Aug 5, 2025 at 2:28 PM Stefano Manni 
> <stefano.manni@gmail.com> wrote:
>> 
>>  AD7994 supports the external reference voltage on pin REFIN.
> 
> ...
> 
>>  -               if ((st->id == ad7991) || (st->id == ad7995) || 
>> (st->id == ad7999)) {
>>  +               if ((st->id == ad7991) || (st->id == ad7995) || 
>> (st->id == ad7999)
>>  +                       (st->id == ad7994)) {
> 
> Instead of making this conditional longer and uglier, it is better to
> add a boolean field to chip_info and just check it instead. This will
> remove the churn when any new chip will require the same change in the
> future.
> 
> So, please make it two patches:
> - introducing a field in chip_info and use it for the existing cases
> - add this field to be true for the ad7994 case.
> 
> Is it doable?
> 

Yes, it is. A patch series is coming.

> --
> With Best Regards,
> Andy Shevchenko