Re: [PATCH 3/7] btrfs: zoned: always set data_relocation_bg

[Damien Le Moal <dlemoal@kernel.org>]

On 2026/05/13 21:34, Johannes Thumshirn wrote:
> When searching for a data relocation block-group on mount,
> btrfs_zoned_reserve_data_reloc_bg() is looking for the first empty DATA
> block-group. But it first checks if the block-group is empty and if yes
> continues the search, and then checks if it is the first DATA block-group.
> 
> Reverse the order, first check if it is the first DATA block-group found
> and skip, then check if the block-group is empty. This enusres that there
> is always a DATA block-group set as data_relocation_bg in the filesystem.
> 
> Singed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Doesn't this need a Fixes tag ?

> ---
>  fs/btrfs/zoned.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
> index 16dd87aa06f2..0b80b498fb85 100644
> --- a/fs/btrfs/zoned.c
> +++ b/fs/btrfs/zoned.c
> @@ -2784,14 +2784,14 @@ void btrfs_zoned_reserve_data_reloc_bg(struct btrfs_fs_info *fs_info)
>  again:
>  	bg_list = &space_info->block_groups[index];
>  	list_for_each_entry(bg, bg_list, list) {
> -		if (bg->alloc_offset != 0)
> -			continue;
> -
>  		if (first) {
>  			first = false;
>  			continue;
>  		}
>  
> +		if (bg->alloc_offset != 0)
> +			continue;
> +
>  		if (space_info == data_sinfo) {
>  			/* Migrate the block group to the data relocation space_info. */
>  			struct btrfs_space_info *reloc_sinfo = data_sinfo->sub_group[0];


-- 
Damien Le Moal
Western Digital Research