Re: [PATCH i-g-t v9 31/49] tests/unigraf: Add basic unigraf tests

["Naladala, Ramanaidu" <Ramanaidu.naladala@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 10435 bytes --]

Hi Louis,

On 3/16/2026 9:47 PM, Louis Chauvet wrote:
> Adds two tests to validate unigraf communication.
>
> unigraf-connect checks if the device is connected and if the EDID is
> properly applied.
>
> ungiraf-reconnect checks if the device can be connected/reconnected
> using SST and MST configurations.
>
> Signed-off-by: Louis Chauvet<louis.chauvet@bootlin.com>
> ---
>   tests/meson.build                    |   4 +
>   tests/unigraf/meson.build            |  12 +++
>   tests/unigraf/unigraf_connectivity.c | 138 +++++++++++++++++++++++++++++++++++
>   3 files changed, 154 insertions(+)
>
> diff --git a/tests/meson.build b/tests/meson.build
> index cecb4a8ae34a..4d3399d0eff4 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -475,6 +475,10 @@ foreach prog : intel_progs
>   	endif
>   endforeach
>   
> +if libtsi.found()
> +	subdir('unigraf')
> +endif
> +
>   if chamelium.found()
>   	foreach prog : chamelium_progs
>   		testexe = executable(prog,
> diff --git a/tests/unigraf/meson.build b/tests/unigraf/meson.build
> new file mode 100644
> index 000000000000..4ef8c32151e4
> --- /dev/null
> +++ b/tests/unigraf/meson.build
> @@ -0,0 +1,12 @@
> +unigraf_progs = [
> +	'unigraf_connectivity',
> +]
> +
> +foreach prog : unigraf_progs
> +	test_executables += executable(prog, prog + '.c',
> +				       dependencies : test_deps,
> +				       install_dir : unigrafdir,
> +				       install_rpath : unigraf_rpathdir,
> +				       install : true)
> +	test_list += join_paths('unigraf', prog)
> +endforeach
> diff --git a/tests/unigraf/unigraf_connectivity.c b/tests/unigraf/unigraf_connectivity.c
> new file mode 100644
> index 000000000000..b35149a4de9a
> --- /dev/null
> +++ b/tests/unigraf/unigraf_connectivity.c
> @@ -0,0 +1,138 @@
> +// SPDX-License-Identifier: MIT
> +/*
> + * Copyright © 2026 Google
> + *
> + * Authors:
> + *   Louis Chauvet<louis.chauvet@bootlin.com>
> + */
> +
> +#include <stdint.h>
> +#include <stdlib.h>
> +#include <unistd.h>
> +#include <xf86drmMode.h>
> +
> +#include "drmtest.h"
> +#include "igt_aux.h"
> +#include "igt_core.h"
> +#include "igt_kms.h"
> +#include "unigraf/unigraf.h"
> +
> +/**
> + * TEST: unigraf connectivity
> + * Category: Core
> + * Description: Testing connectivity with a unigraf device
> + *
> + * SUBTEST: unigraf-connect-edid
> + * Description: Verify that the unigraf device is properly connected to the DUT
> + *              and that the correct EDID is detected and read.
> + *
> + * SUBTEST: unigraf-connect-mst
> + * Description: Ensure that the DUT can correctly detect and handle the unigraf device
> + *              when it is configured to operate in MST mode.
> + */
> +
> +IGT_TEST_DESCRIPTION("Test basic unigraf connectivity");
> +int igt_main()
> +{
> +	int drm_fd;
> +
> +	igt_fixture() {
> +		drm_fd = drm_open_driver_master(DRIVER_ANY);
> +	}
> +
> +	igt_describe("Make sure that the unigraf device is connected to the DUT and EDID is properly detected");
> +	igt_subtest("unigraf-connect-edid") {
> +		drmModePropertyBlobPtr edid_blob = NULL;
> +		struct igt_display display;
> +		uint64_t edid_blob_id;
> +		igt_output_t *output;
> +		uint32_t unigraf_edid_len;
> +		void *unigraf_edid;
> +		bool found = false;
> +
> +		/*
> +		 * Sleep are required to allow hardware to configure/detect the current
> +		 * configuration
> +		 */
> +		unigraf_require_device(drm_fd);

I think delays side need to check again. If i ran subtest alone observed 
new connector timeouts.

Starting subtest: unigraf-connect-mst
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:(nil): Initialize 
unigraf...
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:(nil): No 
connector name configured, will autodetect.
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:(nil): MST usage 
not configured, using SST.
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:(nil): Detected 
unigraf device 0: UCD-500 [2607C673]
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Successfully opened the unigraf device 0.
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Role 0: DisplayPort Source and Sink
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Role 1: DisplayPort Source and USB-C, DP Alt Mode Sink
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Role 2: DisplayPort Sink and USB-C, DP Alt Mode Source
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Role 3: USB-C, DP Alt Mode Source and Sink
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Input 0: USB-C RX
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Value write: TSI_FORCE_HOT_PLUG_STATE_W=0...
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Value write: TSI_DPRX_LINK_FLAGS=86...
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Value write: TSI_FORCE_HOT_PLUG_STATE_W=1...
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Value write: TSI_DPRX_LINK_FLAGS=86...
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Value write: TSI_FORCE_HOT_PLUG_STATE_W=0...
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Value write: TSI_FORCE_HOT_PLUG_STATE_W=1...
*(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
No newly connected connector, assuming that the unigraf is not connected.*
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Value write: TSI_DPRX_HPD_FORCE=12...
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Value write: TSI_DPRX_MST_SINK_COUNT=1...
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Value read: TSI_DPRX_MST_SINK_COUNT=1
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Value write: TSI_DPRX_LINK_FLAGS=86...
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Write EDID for stream 3...
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Value write: TSI_EDID_SELECT_STREAM=3...
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Writing 2048 bytes to 0x1100
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Write EDID for stream 2...
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Value write: TSI_EDID_SELECT_STREAM=2...
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Writing 2048 bytes to 0x1100
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Write EDID for stream 1...
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Value write: TSI_EDID_SELECT_STREAM=1...
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Writing 2048 bytes to 0x1100
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Write EDID for stream 0...
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Value write: TSI_EDID_SELECT_STREAM=0...
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Writing 2048 bytes to 0x1100
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Value write: TSI_FORCE_HOT_PLUG_STATE_W=1...
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Value write: TSI_DPRX_MAX_LANES=4...
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Value write: TSI_DPRX_MAX_LINK_RATE=30...
(unigraf_connectivity:7675) unigraf/unigraf-DEBUG: TSI:0x630f991906c0: 
Value write: TSI_DPRX_LINK_FLAGS=86...
Test requirement not met in function unigraf_require_device, file 
../lib/unigraf/unigraf.c:534:
Test requirement: unigraf_open_device(drm_fd)

> +		unigraf_hpd_deassert();
> +		sleep(igt_default_display_detect_timeout());
> +		unigraf_set_sst();
> +		unigraf_hpd_assert();
> +		sleep(igt_default_display_detect_timeout());
> +		igt_display_require(&display, drm_fd);
> +		sleep(igt_default_display_detect_timeout());
> +
> +		unigraf_edid = unigraf_read_edid(0, &unigraf_edid_len);
> +
> +		for_each_connected_output(&display, output) {
> +			if (output->config.connector->connector_type ==
> +			    DRM_MODE_CONNECTOR_DisplayPort) {
> +				igt_assert(kmstest_get_property(drm_fd,
> +								output->config.connector->connector_id,
> +								DRM_MODE_OBJECT_CONNECTOR, "EDID",
> +								NULL, &edid_blob_id, NULL));
> +				edid_blob = drmModeGetPropertyBlob(drm_fd, edid_blob_id);
> +				if (!edid_blob)
> +					continue;
> +
> +				if (!memcmp(unigraf_edid, edid_blob->data,
> +					    min(edid_blob->length, unigraf_edid_len)))
> +					found = true;
> +
> +				drmModeFreePropertyBlob(edid_blob);
> +
> +				if (found)
> +					break;
> +			}
> +		}
> +		igt_assert_f(found, "No output with the correct EDID was found\n");
> +
> +		free(unigraf_edid);
> +	}
> +
> +	igt_describe("Make sure that the unigraf device can be used as a MST device");
> +	igt_subtest("unigraf-connect-mst") {
> +		int newly_connected_count, already_connected_count, diff_len;
> +		uint32_t *newly_connected = NULL, *already_connected = NULL, *diff = NULL;
> +		int max_count;
> +
> +		unigraf_require_device(drm_fd);
> +		max_count = unigraf_get_mst_stream_max_count();
> +
> +		unigraf_hpd_deassert();
> +
> +		already_connected_count = igt_get_connected_connectors(drm_fd, &already_connected);
> +
> +		igt_debug("Already connected count: %d\n", already_connected_count);
> +
> +		// i = 0 is SST so we need to process max_count + 1 streams
> +		for (int i = 0; i <= max_count; i++) {
> +			unigraf_hpd_deassert();
> +			// Let the hardware detect the new state
> +			sleep(igt_default_display_detect_timeout());
> +
> +			unigraf_set_mst_stream_count(max(i, 1));
> +			if (!i)
> +				unigraf_set_sst();
> +			else
> +				unigraf_set_mst();
> +
> +			unigraf_hpd_assert();
> +			// Let the hardware detect the new state
> +			sleep(igt_default_display_detect_timeout());
> +
> +			newly_connected_count = kms_wait_for_new_connectors(&newly_connected,
> +									    already_connected,
> +									    already_connected_count,
> +									    drm_fd);
> +
> +			diff_len = get_array_diff(newly_connected, newly_connected_count,
> +						  already_connected, already_connected_count, &diff);
> +
> +			igt_assert_f(diff_len == max(i, 1),
> +				     "Invalid connected connector count, expected %d found %d\n",
> +				     max(i, 1), diff_len);
> +		}
> +	}
> +}
>

[-- Attachment #2: Type: text/html, Size: 11586 bytes --]