All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Joshua DeWeese <josh.deweese@gmail.com>,
	 openembedded-core@lists.openembedded.org
Cc: Joshua DeWeese <jdeweese@hennypenny.com>
Subject: Re: [PATCH] wpa_supplicant: Changed systemd template units
Date: Tue, 05 Feb 2019 21:52:14 +0000	[thread overview]
Message-ID: <9a5432388d2f7cc7b3f8ec52814516a53df72b53.camel@linuxfoundation.org> (raw)
In-Reply-To: <20190205162644.24971-1-josh.deweese@gmail.com>

On Tue, 2019-02-05 at 11:26 -0500, Joshua DeWeese wrote:
> From: Joshua DeWeese <jdeweese@hennypenny.com>
> 
> https://www.freedesktop.org/software/systemd/man/systemd.unit.html#WantedBy=
> 
> When building root filesystems with any of the wpa_supplicant systemd
> template service files enabled (current default is to have them
> disabled) the
> systemd-native-fake script would not process the line:
> 
> Alias=multi-user.target.wants/wpa_supplicant@%i.service
> 
> appropriately due the the use of "%i."
> 
> According to the systemd documentation "WantedBy=foo.service in a
> service
> bar.service is mostly equivalent to
> Alias=foo.service.wants/bar.service in
> the same file." However, this is not really the intended purpose of
> install
> Aliases.
> 
> All lines of the form:
> 
> Alias=multi-user.target.wants/*%i.service
> 
> Were replaced with the following lines:
> 
> WantedBy=multi-user.target
> 
> Signed-off-by: Joshua DeWeese <jdeweese@hennypenny.com>

This patch doesn't seem to apply against master (which has 2.6, not
2.5)?

Cheers,

Richard



  reply	other threads:[~2019-02-05 21:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-05 16:26 [PATCH] wpa_supplicant: Changed systemd template units Joshua DeWeese
2019-02-05 21:52 ` Richard Purdie [this message]
2019-02-07 14:48   ` (No subject) Joshua DeWeese
2019-02-07 15:03   ` [PATCH] wpa_supplicant: Changed systemd template units Joshua DeWeese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a5432388d2f7cc7b3f8ec52814516a53df72b53.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=jdeweese@hennypenny.com \
    --cc=josh.deweese@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.