From: Jesper Juhl <jesper.juhl@gmail.com>
To: Chris Wright <chrisw@osdl.org>
Cc: Jesper Juhl <juhl-lkml@dif.dk>,
linux-kernel@vger.kernel.org,
"Rickard E. (Rik) Faith" <faith@redhat.com>,
Rik Faith <faith@cs.unc.edu>,
linux-audit@redhat.com
Subject: Re: [PATCH] Small kfree cleanup, save a local variable.
Date: Sun, 19 Jun 2005 22:19:26 +0200 [thread overview]
Message-ID: <9a874849050619131941278fc4@mail.gmail.com> (raw)
In-Reply-To: <20050619201354.GY9153@shell0.pdx.osdl.net>
On 6/19/05, Chris Wright <chrisw@osdl.org> wrote:
> * Jesper Juhl (juhl-lkml@dif.dk) wrote:
> > Here's a patch with a small improvement to kernel/auditsc.c .
> > There's no need for the local variable struct audit_entry *e ,
> > we can just call kfree directly on container_of() .
> > Patch also removes an extra space a little further down in the file.
>
> Please Cc: linux-audit@redhat.com on audit patches.
I didn't find that address in MAINTAINERS nor in the source file. I
had no idea it existed. Perhaps it ought to be listed in MAINTAINERS
somewhere...
> I tend to agree
> with Michael, it's optimized away, and readable as is.
>
Fair enough, we'll just leave it as is :)
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
next prev parent reply other threads:[~2005-06-19 20:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-19 19:38 [PATCH] Small kfree cleanup, save a local variable Jesper Juhl
2005-06-19 19:37 ` Michael Buesch
2005-06-19 19:49 ` Jesper Juhl
2005-06-19 20:13 ` Chris Wright
2005-06-19 20:19 ` Jesper Juhl [this message]
2005-06-19 20:20 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a874849050619131941278fc4@mail.gmail.com \
--to=jesper.juhl@gmail.com \
--cc=chrisw@osdl.org \
--cc=faith@cs.unc.edu \
--cc=faith@redhat.com \
--cc=juhl-lkml@dif.dk \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.