From: Jesper Juhl <jesper.juhl@gmail.com>
To: Harald Welte <laforge@gnumonks.org>
Cc: Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Omnikey Cardman 4000 driver
Date: Mon, 5 Sep 2005 22:29:32 +0200 [thread overview]
Message-ID: <9a87484905090513292d611391@mail.gmail.com> (raw)
In-Reply-To: <20050906013545.GB16056@rama.de.gnumonks.org>
On 9/6/05, Harald Welte <laforge@gnumonks.org> wrote:
> Hi!
>
> Following-up to the Cardman 4040 driver, I'm now sumitting a driver for
> the Cardman 4000 reader. It is, too, a PCMCIA smartcard reader and the
> predecessor of the 4040.
>
> From a technical point of view, the two devices have nothing in common,
> so there is no possibility of code sharing.
>
> Please consider mergin mainline, thanks.
>
> Note: The patch is incremental to the Cardman 4040 driver that has
> already been submitted.
>
[snip]
Please see my CodingStyle comments for your previous driver as well as
the cleanup patch I just posted for that one. A lot of those issues
apply to your new driver as well - care to clean that up?
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
next prev parent reply other threads:[~2005-09-05 20:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-06 1:35 [PATCH] Omnikey Cardman 4000 driver Harald Welte
2005-09-05 19:44 ` Nish Aravamudan
2005-09-07 7:06 ` Harald Welte
2005-09-05 20:29 ` Jesper Juhl [this message]
2005-09-05 20:36 ` Jesper Juhl
2005-09-06 6:59 ` Harald Welte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a87484905090513292d611391@mail.gmail.com \
--to=jesper.juhl@gmail.com \
--cc=laforge@gnumonks.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.