From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Gerd Hoffmann <kraxel@redhat.com>, Peter Wu <peter@lekensteyn.nl>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-devel@nongnu.org, "Alexander Bulekov" <alxndr@bu.edu>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Mauro Matteo Cascella" <mcascell@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [RFC PATCH-for-7.2 3/5] hw/display/qxl: Pass requested buffer size to qxl_phys2virt()
Date: Mon, 28 Nov 2022 17:29:32 +0100 [thread overview]
Message-ID: <9a8debf0-8a49-1ba7-a009-eb1e5b383590@linaro.org> (raw)
In-Reply-To: <c64522e4-4bb9-8dbf-fd93-151b77f5156a@linaro.org>
On 28/11/22 17:18, Philippe Mathieu-Daudé wrote:
> On 28/11/22 16:41, Philippe Mathieu-Daudé wrote:
>> On 28/11/22 16:08, Gerd Hoffmann wrote:
>
>>> Also at least one code path (processing SPICE_CURSOR_TYPE_MONO in
>>> qxl_cursor) goes access chunk.data[] without calling
>>> qxl_unpack_chunks(), that needs additional verification too (or
>>> switch it to call qxl_unpack_chunks, or just drop it because nobody
>>> uses mono chrome cursors anyway).
> Per commit 36ffc122dc ("qxl: support mono cursors with inverted colors")
> "Monochrome cursors are still used by Windows guests" (i.e. Win2008R2)
> :/
Hmm I guess I'm missing something in qxl_cursor() following the
SPICE_CURSOR_TYPE_MONO case.
- cursor_alloc() allocate QEMUCursor* c but doesn't set c->data,
- nothing seems to set c->data
- cursor_set_mono() is called and *(c->data) is assigned...
?
next prev parent reply other threads:[~2022-11-28 16:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 13:48 [RFC PATCH-for-7.2 0/5] hw/display/qxl: Avoid buffer overrun in qxl_phys2virt() Philippe Mathieu-Daudé
2022-11-28 13:48 ` [PATCH-for-7.2 1/5] hw/display/qxl: Have qxl_log_command Return early if no log_cmd handler Philippe Mathieu-Daudé
2022-11-28 13:48 ` [PATCH-for-7.2 2/5] hw/display/qxl: Document qxl_phys2virt() Philippe Mathieu-Daudé
2022-11-28 13:48 ` [RFC PATCH-for-7.2 3/5] hw/display/qxl: Pass requested buffer size to qxl_phys2virt() Philippe Mathieu-Daudé
2022-11-28 13:53 ` Marc-André Lureau
2022-11-28 15:08 ` Gerd Hoffmann
2022-11-28 15:41 ` Philippe Mathieu-Daudé
2022-11-28 15:49 ` Gerd Hoffmann
2022-11-28 16:18 ` Philippe Mathieu-Daudé
2022-11-28 16:29 ` Philippe Mathieu-Daudé [this message]
2022-11-28 16:52 ` Philippe Mathieu-Daudé
2022-11-28 13:48 ` [RFC PATCH-for-7.2 4/5] hw/display/qxl: Avoid buffer overrun in qxl_phys2virt (CVE-2022-4144) Philippe Mathieu-Daudé
2022-11-28 15:16 ` Stefan Hajnoczi
2022-11-28 15:25 ` Philippe Mathieu-Daudé
2022-11-28 15:32 ` Stefan Hajnoczi
2022-11-28 15:46 ` Philippe Mathieu-Daudé
2022-11-28 15:48 ` Stefan Hajnoczi
2022-11-28 13:48 ` [PATCH-for-8.0 5/5] hw/display/qxl: Assert memory slot fits in preallocated MemoryRegion Philippe Mathieu-Daudé
2022-11-28 13:51 ` [RFC PATCH-for-7.2 v2 0/5] hw/display/qxl: Avoid buffer overrun in qxl_phys2virt() Philippe Mathieu-Daudé
2022-11-28 15:19 ` [RFC PATCH-for-7.2 " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8debf0-8a49-1ba7-a009-eb1e5b383590@linaro.org \
--to=philmd@linaro.org \
--cc=alxndr@bu.edu \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mcascell@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peter@lekensteyn.nl \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.