From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3DE6C4332F for ; Fri, 16 Dec 2022 20:27:49 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 993EA16FC; Fri, 16 Dec 2022 21:26:56 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 993EA16FC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1671222466; bh=yXW+wV+UgSM2VSneYgwaMavVBMwnnak5JNaby2zZkUY=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=SsNEUPHRWCiNUkEVgkmUaRqr0yrXtLpMIEHq+oVM2GaATgJm8lpQ2+Me5GJAGmlNu bLw10YdVOSgOWJeyPHwUHWhCE38MVpA27X5xvbozIaSHI+0v9/dVxLtEOaN3RSl9lG /ineSiUMO7ptZeGJNieA8ViLf+UwBawwnzlkX4yM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9015CF80570; Fri, 16 Dec 2022 18:37:10 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 931AAF80571; Fri, 16 Dec 2022 18:37:09 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6AE45F8056F for ; Fri, 16 Dec 2022 18:37:02 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6AE45F8056F Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=NIUP04Wu DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671212225; x=1702748225; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=yXW+wV+UgSM2VSneYgwaMavVBMwnnak5JNaby2zZkUY=; b=NIUP04WujA/bmM8U0ekYddzlcD70QYJ1lsF/R2IGLmq2ayliN6BL3B0A S2HvY/Wk1aSt4DWH5+fwVX8trvAdnV7udjop1IPvM3mBx3/+f8Qu2fp+Y 1qNp5Zui5p6MdZ9NHY0hC7B8Ch+yVCQUjhngKCM6l+3eAGrcPaGL/BwRz 4pnWT62phzt8v798ycKpN9owDm2UVuVrA/xfQvie/J3qh+3EZadpcsM0l Givo8bBQn4n8mjAPBrZNgph0DrTIZJI1JIyBKVIZhkypAzpRNNotzxowi xBhLNvymIwvytNIN9Q4ALZ4JBIYt3wEbNVccx9d3Iby2jyFVyaw/wS8YR w==; X-IronPort-AV: E=McAfee;i="6500,9779,10563"; a="383352493" X-IronPort-AV: E=Sophos;i="5.96,249,1665471600"; d="scan'208";a="383352493" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2022 09:36:58 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10563"; a="651997543" X-IronPort-AV: E=Sophos;i="5.96,249,1665471600"; d="scan'208";a="651997543" Received: from krojasle-mobl.amr.corp.intel.com (HELO [10.209.187.31]) ([10.209.187.31]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2022 09:36:57 -0800 Message-ID: <9aa4bffd-bc7e-0e40-3063-5ce80b5fbe9a@linux.intel.com> Date: Fri, 16 Dec 2022 11:36:56 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.4.2 Subject: Re: [PATCH v2] ASoC: Intel: sof_nau8825: add variant with nau8318 amplifier. Content-Language: en-US To: Ajye Huang References: <20221216154938.9426-1-ajye_huang@compal.corp-partner.google.com> From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Libin Yang , Liam Girdwood , Cezary Rojewski , Kai Vehmanen , ye xingchen , Peter Ujfalusi , Takashi Iwai , linux-kernel@vger.kernel.org, "balamurugan . c" , Mark Brown , Muralidhar Reddy , Ranjani Sridharan , Akihiko Odaki , David Lin , alsa-devel@alsa-project.org, Bard Liao , Brent Lu , Yong Zhi Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 12/16/22 10:55, Ajye Huang wrote: > Hi Pierre > > On Sat, Dec 17, 2022 at 12:03 AM Pierre-Louis Bossart > wrote: > >> On 12/16/22 09:49, Ajye Huang wrote: >>> This patch adds the driver data for two nau8318 speaker amplifiers on >>> SSP1 and nau8825 on SSP0 for ADL platform. >> >> So here you are making reference to two amplifiers... >> >>> +static struct snd_soc_dai_link_component nau8318_components[] = { >>> + { >>> + .name = "NVTN2012:00", >>> + .dai_name = "nau8315-hifi", >>> + } >>> +}; >> >> but here there's only one? I was expecting something like what we've >> used for Maxim amplifiers with a codec configuration and dailink >> components that list the two amplifiers. >> >> static struct snd_soc_codec_conf max_98373_codec_conf[] = { >> { >> .dlc = COMP_CODEC_CONF(MAX_98373_DEV0_NAME), >> .name_prefix = "Right", >> }, >> { >> .dlc = COMP_CODEC_CONF(MAX_98373_DEV1_NAME), >> .name_prefix = "Left", >> }, >> }; >> >> struct snd_soc_dai_link_component max_98373_components[] = { >> { /* For Right */ >> .name = MAX_98373_DEV0_NAME, >> .dai_name = MAX_98373_CODEC_DAI, >> }, >> { /* For Left */ >> .name = MAX_98373_DEV1_NAME, >> .dai_name = MAX_98373_CODEC_DAI, >> }, >> }; >> >> Or is this a commit message problem and there's really only one amplifier? > > Really , it has two speakers. The nau8318 is an auto mode Amplifier > chip, similar to the max98360a amp chip. > EX: Sof_maxim_common.c (sound\soc\intel\boards): > static struct snd_soc_dai_link_component max_98360a_components[] = { > { > .name = MAX_98360A_DEV0_NAME, > .dai_name = MAX_98357A_CODEC_DAI, > } > }; > It is not an i2c interface, from the nau8318 data sheet, there are > five pins used mainly. one for enable, others for I2S. > EN-- enable pin > FSR-- Frame Sync, Right > FSL-- Frame Sync, Left > BCLK-- bit clock > DACIN-- Input i2s data > > The FSR and FSL pins are for Left and Right channels used. > thanks Ok, thanks for the explanations. Acked-by: Pierre-Louis Bossart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65794C4332F for ; Fri, 16 Dec 2022 17:37:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231817AbiLPRhI (ORCPT ); Fri, 16 Dec 2022 12:37:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231743AbiLPRhA (ORCPT ); Fri, 16 Dec 2022 12:37:00 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B192A164A9 for ; Fri, 16 Dec 2022 09:36:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671212219; x=1702748219; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=yXW+wV+UgSM2VSneYgwaMavVBMwnnak5JNaby2zZkUY=; b=CTit5uW6eaCNF3GDuV3ogc0CGpP47y7jEnc5IqivZxUflrtrn1AQRrbi pNHMtWvdfU+apTma+/51JOtLB40j8ngwT44h+8XGki1p/Vl6uQppLJmbq yNhGVqa2R34+uWWLUPTUIaZ2tOSoDACjxbJSntITKeO+Y5utstFJYFFc1 qFCNmSjuv1raEioETZqUYxESXvE5M9HVA24RZlYPYLVQn4/qaq40lQCP1 eAj7rJ2bFA+ixUQOlKi3nFzSaeF7LSugUi50dtOTgyFfKy/+ymOY1C6nr 0k4gh3DyDHb3Im7oU4UCtiAjfRrdd8vaw8Vrg15DAvqAPYGpx1oC0RaLQ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10563"; a="383352498" X-IronPort-AV: E=Sophos;i="5.96,249,1665471600"; d="scan'208";a="383352498" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2022 09:36:59 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10563"; a="651997543" X-IronPort-AV: E=Sophos;i="5.96,249,1665471600"; d="scan'208";a="651997543" Received: from krojasle-mobl.amr.corp.intel.com (HELO [10.209.187.31]) ([10.209.187.31]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2022 09:36:57 -0800 Message-ID: <9aa4bffd-bc7e-0e40-3063-5ce80b5fbe9a@linux.intel.com> Date: Fri, 16 Dec 2022 11:36:56 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.4.2 Subject: Re: [PATCH v2] ASoC: Intel: sof_nau8825: add variant with nau8318 amplifier. Content-Language: en-US To: Ajye Huang Cc: Libin Yang , "balamurugan . c" , Cezary Rojewski , Kai Vehmanen , Bard Liao , Takashi Iwai , linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown , Muralidhar Reddy , Ranjani Sridharan , Akihiko Odaki , ye xingchen , David Lin , alsa-devel@alsa-project.org, Peter Ujfalusi , Brent Lu , Yong Zhi References: <20221216154938.9426-1-ajye_huang@compal.corp-partner.google.com> From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/16/22 10:55, Ajye Huang wrote: > Hi Pierre > > On Sat, Dec 17, 2022 at 12:03 AM Pierre-Louis Bossart > wrote: > >> On 12/16/22 09:49, Ajye Huang wrote: >>> This patch adds the driver data for two nau8318 speaker amplifiers on >>> SSP1 and nau8825 on SSP0 for ADL platform. >> >> So here you are making reference to two amplifiers... >> >>> +static struct snd_soc_dai_link_component nau8318_components[] = { >>> + { >>> + .name = "NVTN2012:00", >>> + .dai_name = "nau8315-hifi", >>> + } >>> +}; >> >> but here there's only one? I was expecting something like what we've >> used for Maxim amplifiers with a codec configuration and dailink >> components that list the two amplifiers. >> >> static struct snd_soc_codec_conf max_98373_codec_conf[] = { >> { >> .dlc = COMP_CODEC_CONF(MAX_98373_DEV0_NAME), >> .name_prefix = "Right", >> }, >> { >> .dlc = COMP_CODEC_CONF(MAX_98373_DEV1_NAME), >> .name_prefix = "Left", >> }, >> }; >> >> struct snd_soc_dai_link_component max_98373_components[] = { >> { /* For Right */ >> .name = MAX_98373_DEV0_NAME, >> .dai_name = MAX_98373_CODEC_DAI, >> }, >> { /* For Left */ >> .name = MAX_98373_DEV1_NAME, >> .dai_name = MAX_98373_CODEC_DAI, >> }, >> }; >> >> Or is this a commit message problem and there's really only one amplifier? > > Really , it has two speakers. The nau8318 is an auto mode Amplifier > chip, similar to the max98360a amp chip. > EX: Sof_maxim_common.c (sound\soc\intel\boards): > static struct snd_soc_dai_link_component max_98360a_components[] = { > { > .name = MAX_98360A_DEV0_NAME, > .dai_name = MAX_98357A_CODEC_DAI, > } > }; > It is not an i2c interface, from the nau8318 data sheet, there are > five pins used mainly. one for enable, others for I2S. > EN-- enable pin > FSR-- Frame Sync, Right > FSL-- Frame Sync, Left > BCLK-- bit clock > DACIN-- Input i2s data > > The FSR and FSL pins are for Left and Right channels used. > thanks Ok, thanks for the explanations. Acked-by: Pierre-Louis Bossart