All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Kalle Valo <kvalo@kernel.org>,
	Bitterblue Smith <rtl8821cerfe2@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH] wifi: rtlwifi: Ignore IEEE80211_CONF_CHANGE_RETRY_LIMITS
Date: Thu, 30 May 2024 03:13:30 +0000	[thread overview]
Message-ID: <9aaaee6266474945b6278c56f3ee3fec@realtek.com> (raw)
In-Reply-To: <87o78omrk4.fsf@kernel.org>

Kalle Valo <kvalo@kernel.org> wrote:
> Bitterblue Smith <rtl8821cerfe2@gmail.com> writes:
> 
> > Since commit 0a44dfc07074 ("wifi: mac80211: simplify non-chanctx
> > drivers") ieee80211_hw_config() is no longer called with changed = ~0.
> > rtlwifi relied on ~0 in order to ignore the default retry limits of
> > 4/7, preferring 48/48 in station mode and 7/7 in AP/IBSS.
> >
> > RTL8192DU has a lot of packet loss with the default limits from
> > mac80211. Fix it by ignoring IEEE80211_CONF_CHANGE_RETRY_LIMITS
> > completely, because it's the simplest solution.
> >
> > Link: https://lore.kernel.org/linux-wireless/cedd13d7691f4692b2a2fa5a24d44a22@realtek.com/
> > Cc: stable@vger.kernel.org # 6.9.x
> > Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>

> 
> Ping, should this go to v6.10? If you agree, ack and assign it to me on
> patchwork. I'll then take it to wireless tree.
> 
> But feel free to take it to rtw-next as well, your call.
> 

Please take it to v6.10, and assign it to you. Thanks.



  reply	other threads:[~2024-05-30  3:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-29 17:19 [PATCH] wifi: rtlwifi: Ignore IEEE80211_CONF_CHANGE_RETRY_LIMITS Bitterblue Smith
2024-05-29 17:55 ` Kalle Valo
2024-05-30  3:13   ` Ping-Ke Shih [this message]
2024-06-01 10:15 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9aaaee6266474945b6278c56f3ee3fec@realtek.com \
    --to=pkshih@realtek.com \
    --cc=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rtl8821cerfe2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.