From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95AC1C433F5 for ; Fri, 19 Nov 2021 07:58:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5798F60EBD for ; Fri, 19 Nov 2021 07:58:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5798F60EBD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AOyl5M1addv3tq+zQGaSe9QlJMztGYPpfEOnbNh3Jvs=; b=WxHy0rGnSVHbVVj6NzMse2riZq nLEK0704J/CYr2wZGcEWQDu9Rj6RoXfFEG8NvdopM/06ehDjkwSnSCUe2bG0PIvhCBvdp4KbkaC+f zCL9W60LQAcll+jcII2ryszD20IRnaPlNv4gMUWLLkUtOMOZYloAW62DGzK5xdKsHE8DuXy5ple9G g00LO2jEC8v1vvKh7NDhQEDeNvl8Gb1GEFhoXmuzUs7OnhYedL3gmXB/xAq5AdBodeULOoinihcCT NLVfAqijvIbyAIY/f3sBKYKAJzKMTsY7BdC43CuSwXoRr5Kg617etjl4rcNfG7uxi/3IYkLzwWtwy Q3WX1BHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnynI-009gGa-33; Fri, 19 Nov 2021 07:58:48 +0000 Received: from m43-7.mailgun.net ([69.72.43.7]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnynF-009gFp-Q9 for ath11k@lists.infradead.org; Fri, 19 Nov 2021 07:58:47 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1637308725; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=tkMTrgPDznBkag7N8PY4gBko+1tUGKNQ/pYo04ktkzk=; b=FsCSRmtg3spx0Hom0gO+h5yBZki/RWb2pVgoc+RI53YJZejdnitfH0dQCOxs6oxwnu5+gx64 MKI9tHdltkUmLDZ5Zo0wtQpz51NRjNF/7rekYZEdhIRwqsb2cJOkQNzDYPFbx7XVfbUMghYW x3+N2UUCGOtIX6StjbG16Kxbr0M= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJmOGQ2ZiIsICJhdGgxMWtAbGlzdHMuaW5mcmFkZWFkLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-west-2.postgun.com with SMTP id 61975934f5c956d49e80b7fa (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 19 Nov 2021 07:58:44 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id DA692C4360D; Fri, 19 Nov 2021 07:58:43 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: wgong) by smtp.codeaurora.org (Postfix) with ESMTPSA id 72BBDC4338F; Fri, 19 Nov 2021 07:58:43 +0000 (UTC) MIME-Version: 1.0 Date: Fri, 19 Nov 2021 15:58:43 +0800 From: Wen Gong To: Kalle Valo Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH] ath11k: add read variant from SMBIOS for download board data In-Reply-To: References: <20211011082433.30415-1-wgong@codeaurora.org> <163713928364.10263.15372409026240983506.kvalo@codeaurora.org> Message-ID: <9abb629d45130da8847679e090c3e4cf@codeaurora.org> X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211118_235845_961663_F4E06CD2 X-CRM114-Status: GOOD ( 17.09 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org On 2021-11-18 18:25, Wen Gong wrote: > On 2021-11-17 16:54, Kalle Valo wrote: >> Wen Gong wrote: >> >>> This is to read variant from SMBIOS such as read from DT, the variant >>> string will be used to one part of string which used to search board >>> data from board-2.bin. >>> >>> Tested-on: WCN6855 hw2.0 PCI >>> WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1 >>> >>> Signed-off-by: Wen Gong >> >> I'm dropping all patches listed below in one go. I didn't manage to >> apply any of these without conflicts, please remember to always use >> ath.git master branch as the baseline to avoid conflicts. >> >> 9 patches set to Changes Requested. >> >> 12549401 ath11k: add read variant from SMBIOS for download board data >> 12549415 ath11k: add wait operation for tx management packets for >> flush from mac80211 >> 12549419 ath11k: change to treat alpha code na as world wide regdomain >> 12549431 ath11k: report rssi of each chain to mac80211 >> 12549433 ath11k: Add signal report to mac80211 for QCA6390 and WCN6855 >> 12549449 ath11k: report tx bitrate for iw wlan station dump >> 12554953 ath11k: add support for hardware rfkill for QCA6390 >> 12583807 ath11k: add 11d scan offload support >> 12583809 ath11k: calculate the correct NSS of peer for HE capabilities > > I have rebased to latest ath.git master ath-202111170737 and resend v2 > for below patches: > [v2] ath11k: report rssi of each chain to mac80211 > [v2,0/2] ath11k: add 11d scan offload support for QCA6390/WCN6855 > [v2] ath11k: add read variant from SMBIOS for download board data > [v2] ath11k: skip sending vdev down for channel switch > [v2] ath11k: fix read fail for htt_stats and htt_peer_stats for single > pdev > [v2] ath11k: calculate the correct NSS of peer for HE capabilities > [v2] ath11k: add wait operation for tx management packets for flush > from mac80211 > [v2] ath11k: change to treat alpha code na as world wide regdomain > > I will rebase the left patches after these patches upstream, otherwise > the left patches will have conflict with these patches > because they change same location but actually have no logic relation. Hi Kalle, I have tested in my local git, all the above v2 patches only have one conflict between "[v2,2/2] ath11k: add 11d scan offload support" and "[v2] ath11k: report rssi of each chain to mac80211" in wmi_tlv_policies of wmi.c because they both add a item in the struct. patch -p1 -i xxx.patch will auto fix this type conflict. + [WMI_TAG_11D_NEW_COUNTRY_EVENT] = { + .min_len = sizeof(struct wmi_11d_new_cc_ev) }, + [WMI_TAG_PER_CHAIN_RSSI_STATS] = { + .min_len = sizeof(struct wmi_per_chain_rssi_stats) }, -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67BF6C433EF for ; Fri, 19 Nov 2021 07:58:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D455610A1 for ; Fri, 19 Nov 2021 07:58:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229972AbhKSIBr (ORCPT ); Fri, 19 Nov 2021 03:01:47 -0500 Received: from m43-7.mailgun.net ([69.72.43.7]:36502 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229879AbhKSIBr (ORCPT ); Fri, 19 Nov 2021 03:01:47 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1637308725; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=tkMTrgPDznBkag7N8PY4gBko+1tUGKNQ/pYo04ktkzk=; b=FsCSRmtg3spx0Hom0gO+h5yBZki/RWb2pVgoc+RI53YJZejdnitfH0dQCOxs6oxwnu5+gx64 MKI9tHdltkUmLDZ5Zo0wtQpz51NRjNF/7rekYZEdhIRwqsb2cJOkQNzDYPFbx7XVfbUMghYW x3+N2UUCGOtIX6StjbG16Kxbr0M= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 61975934c48ba488841d73ee (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 19 Nov 2021 07:58:44 GMT Sender: wgong=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 89FBCC4360C; Fri, 19 Nov 2021 07:58:44 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: wgong) by smtp.codeaurora.org (Postfix) with ESMTPSA id 72BBDC4338F; Fri, 19 Nov 2021 07:58:43 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 19 Nov 2021 15:58:43 +0800 From: Wen Gong To: Kalle Valo Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH] ath11k: add read variant from SMBIOS for download board data In-Reply-To: References: <20211011082433.30415-1-wgong@codeaurora.org> <163713928364.10263.15372409026240983506.kvalo@codeaurora.org> Message-ID: <9abb629d45130da8847679e090c3e4cf@codeaurora.org> X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2021-11-18 18:25, Wen Gong wrote: > On 2021-11-17 16:54, Kalle Valo wrote: >> Wen Gong wrote: >> >>> This is to read variant from SMBIOS such as read from DT, the variant >>> string will be used to one part of string which used to search board >>> data from board-2.bin. >>> >>> Tested-on: WCN6855 hw2.0 PCI >>> WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1 >>> >>> Signed-off-by: Wen Gong >> >> I'm dropping all patches listed below in one go. I didn't manage to >> apply any of these without conflicts, please remember to always use >> ath.git master branch as the baseline to avoid conflicts. >> >> 9 patches set to Changes Requested. >> >> 12549401 ath11k: add read variant from SMBIOS for download board data >> 12549415 ath11k: add wait operation for tx management packets for >> flush from mac80211 >> 12549419 ath11k: change to treat alpha code na as world wide regdomain >> 12549431 ath11k: report rssi of each chain to mac80211 >> 12549433 ath11k: Add signal report to mac80211 for QCA6390 and WCN6855 >> 12549449 ath11k: report tx bitrate for iw wlan station dump >> 12554953 ath11k: add support for hardware rfkill for QCA6390 >> 12583807 ath11k: add 11d scan offload support >> 12583809 ath11k: calculate the correct NSS of peer for HE capabilities > > I have rebased to latest ath.git master ath-202111170737 and resend v2 > for below patches: > [v2] ath11k: report rssi of each chain to mac80211 > [v2,0/2] ath11k: add 11d scan offload support for QCA6390/WCN6855 > [v2] ath11k: add read variant from SMBIOS for download board data > [v2] ath11k: skip sending vdev down for channel switch > [v2] ath11k: fix read fail for htt_stats and htt_peer_stats for single > pdev > [v2] ath11k: calculate the correct NSS of peer for HE capabilities > [v2] ath11k: add wait operation for tx management packets for flush > from mac80211 > [v2] ath11k: change to treat alpha code na as world wide regdomain > > I will rebase the left patches after these patches upstream, otherwise > the left patches will have conflict with these patches > because they change same location but actually have no logic relation. Hi Kalle, I have tested in my local git, all the above v2 patches only have one conflict between "[v2,2/2] ath11k: add 11d scan offload support" and "[v2] ath11k: report rssi of each chain to mac80211" in wmi_tlv_policies of wmi.c because they both add a item in the struct. patch -p1 -i xxx.patch will auto fix this type conflict. + [WMI_TAG_11D_NEW_COUNTRY_EVENT] = { + .min_len = sizeof(struct wmi_11d_new_cc_ev) }, + [WMI_TAG_PER_CHAIN_RSSI_STATS] = { + .min_len = sizeof(struct wmi_per_chain_rssi_stats) },