All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org, Alain Volmat <alain.volmat@foss.st.com>
Subject: Re: [PATCH 0/2] v4l2-cci: little-endian registers
Date: Wed, 1 Nov 2023 12:28:38 +0100	[thread overview]
Message-ID: <9acf20d5-4a3d-8129-036c-c3d79f1d2e3b@redhat.com> (raw)
In-Reply-To: <20231101111747.252072-1-alexander.stein@ew.tq-group.com>

Hi,

On 11/1/23 12:17, Alexander Stein wrote:
> Hi,
> 
> after the discussions at [1] and [2], this series adds proper support for
> little-endian encoded registers.
> Patch 1 adds the infrastructure and patch 2 fixes imx290 driver.
> As v6.6 was released with imx290 broken, both should be added to stable. But
> I'm not sure if adding a Fixes tag to Patch 1 is correct, because it adds a
> new feature patch 2 requires. Any suggestion is welcomed.

I usually just add the Fixes: + Cc: stable@ tags to both patches in cases
like these. Please add the tags to both patches for v2 (with cci_read()
also fixed).

Regards,

Hans




> [1] https://lore.kernel.org/linux-media/20231030173637.GA2977515@gnbcxd0016.gnb.st.com/
> [2] https://lore.kernel.org/linux-media/ZUIuNDTJAN_fz3q6@kekkonen.localdomain/
> 
> Alexander Stein (2):
>   media: v4l2-cci: Add support for little-endian encoded registers
>   media: i2c: imx290: Properly encode registers as little-endian
> 
>  drivers/media/i2c/imx290.c         | 42 +++++++++++++++---------------
>  drivers/media/v4l2-core/v4l2-cci.c | 22 +++++++++++++---
>  include/media/v4l2-cci.h           |  5 ++++
>  3 files changed, 44 insertions(+), 25 deletions(-)
> 


      parent reply	other threads:[~2023-11-01 11:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-01 11:17 [PATCH 0/2] v4l2-cci: little-endian registers Alexander Stein
2023-11-01 11:17 ` [PATCH 1/2] media: v4l2-cci: Add support for little-endian encoded registers Alexander Stein
2023-11-01 11:27   ` Hans de Goede
2023-11-01 11:28   ` Sakari Ailus
2023-11-01 11:17 ` [PATCH 2/2] media: i2c: imx290: Properly encode registers as little-endian Alexander Stein
2023-11-01 11:28 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9acf20d5-4a3d-8129-036c-c3d79f1d2e3b@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=alain.volmat@foss.st.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.