All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Rob Herring <robh@kernel.org>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Device Tree Mailing List <devicetree@vger.kernel.org>,
	Sekhar Nori <nsekhar@ti.com>, Tero Kristo <t-kristo@ti.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 04/12] dt-bindings: irqchip: ti, sci-intr: Update bindings to drop the usage of gic as parent
Date: Mon, 15 Jun 2020 09:34:47 +0100	[thread overview]
Message-ID: <9afd8a79d9c9ecfd35b6a4e66c93e298@kernel.org> (raw)
In-Reply-To: <d586e88c-2907-1771-dee2-32429082aa07@ti.com>

On 2020-06-15 09:03, Lokesh Vutla wrote:
> Hi Marc,
> 
> On 01/06/20 5:06 pm, Lokesh Vutla wrote:
>> Hi Marc,
>> 
>> On 29/05/20 3:48 pm, Marc Zyngier wrote:
>>> On 2020-05-29 11:14, Lokesh Vutla wrote:
>>>> Hi Rob,
>>>> 
>>>> On 29/05/20 3:44 am, Rob Herring wrote:
>>>>> On Wed, May 20, 2020 at 06:14:46PM +0530, Lokesh Vutla wrote:
>>>>>> Drop the firmware related dt-bindings and use the hardware 
>>>>>> specified
>>>>>> interrupt numbers within Interrupt Router. This ensures interrupt 
>>>>>> router
>>>>>> DT node need not assume any interrupt parent type.
>>>>> 
>>>>> I didn't like this binding to begin with, but now you're breaking
>>>>> compatibility.
>>>> 
>>>> Yes, I do agree that this change is breaking backward compatibility. 
>>>> But IMHO,
>>>> this does cleanup of firmware specific properties from DT. Since 
>>>> this is not
>>>> deployed out yet in the wild market, I took the leverage of breaking 
>>>> backward
>>>> compatibility. Before accepting these changes from firmware team, I 
>>>> did
>>>> discuss[0] with Marc on this topic.
>>> 
>>> And I assume that should anyone complain about the kernel being 
>>> broken
>>> because they have an old firmware, you'll be OK with the patches 
>>> being
>>> reverted, right?
>> 
>> I am assuming there is no one to complain as there is no product 
>> available yet
>> with upstream kernel. Internally everyone is aware of the changes. So, 
>> yes I
>> would agree with you to revert the changes if someone really needs it. 
>> :)
> 
> Any chance you can shower your blessings on this series :)

I have purposely ignored it just before and during the merge window. It 
is now firmly in my review queue.

         M.
-- 
Jazz is not dead. It just smells funny...

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Rob Herring <robh@kernel.org>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Device Tree Mailing List <devicetree@vger.kernel.org>,
	Tero Kristo <t-kristo@ti.com>, Sekhar Nori <nsekhar@ti.com>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 04/12] dt-bindings: irqchip: ti, sci-intr: Update bindings to drop the usage of gic as parent
Date: Mon, 15 Jun 2020 09:34:47 +0100	[thread overview]
Message-ID: <9afd8a79d9c9ecfd35b6a4e66c93e298@kernel.org> (raw)
In-Reply-To: <d586e88c-2907-1771-dee2-32429082aa07@ti.com>

On 2020-06-15 09:03, Lokesh Vutla wrote:
> Hi Marc,
> 
> On 01/06/20 5:06 pm, Lokesh Vutla wrote:
>> Hi Marc,
>> 
>> On 29/05/20 3:48 pm, Marc Zyngier wrote:
>>> On 2020-05-29 11:14, Lokesh Vutla wrote:
>>>> Hi Rob,
>>>> 
>>>> On 29/05/20 3:44 am, Rob Herring wrote:
>>>>> On Wed, May 20, 2020 at 06:14:46PM +0530, Lokesh Vutla wrote:
>>>>>> Drop the firmware related dt-bindings and use the hardware 
>>>>>> specified
>>>>>> interrupt numbers within Interrupt Router. This ensures interrupt 
>>>>>> router
>>>>>> DT node need not assume any interrupt parent type.
>>>>> 
>>>>> I didn't like this binding to begin with, but now you're breaking
>>>>> compatibility.
>>>> 
>>>> Yes, I do agree that this change is breaking backward compatibility. 
>>>> But IMHO,
>>>> this does cleanup of firmware specific properties from DT. Since 
>>>> this is not
>>>> deployed out yet in the wild market, I took the leverage of breaking 
>>>> backward
>>>> compatibility. Before accepting these changes from firmware team, I 
>>>> did
>>>> discuss[0] with Marc on this topic.
>>> 
>>> And I assume that should anyone complain about the kernel being 
>>> broken
>>> because they have an old firmware, you'll be OK with the patches 
>>> being
>>> reverted, right?
>> 
>> I am assuming there is no one to complain as there is no product 
>> available yet
>> with upstream kernel. Internally everyone is aware of the changes. So, 
>> yes I
>> would agree with you to revert the changes if someone really needs it. 
>> :)
> 
> Any chance you can shower your blessings on this series :)

I have purposely ignored it just before and during the merge window. It 
is now firmly in my review queue.

         M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2020-06-15  8:34 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-20 12:44 [PATCH 00/12] irqchip: ti, sci-intr/inta: Update the dt bindings to accept different interrupt parents Lokesh Vutla
2020-05-20 12:44 ` [PATCH 00/12] irqchip: ti,sci-intr/inta: " Lokesh Vutla
2020-05-20 12:44 ` [PATCH 01/12] firmware: ti_sci: Drop the device id to resource type translation Lokesh Vutla
2020-05-20 12:44   ` Lokesh Vutla
2020-05-20 12:44 ` [PATCH 02/12] firmware: ti_sci: Drop unused structure ti_sci_rm_type_map Lokesh Vutla
2020-05-20 12:44   ` Lokesh Vutla
2020-05-20 12:44 ` [PATCH 03/12] firmware: ti_sci: Add support for getting resource with subtype Lokesh Vutla
2020-05-20 12:44   ` Lokesh Vutla
2020-05-20 12:44 ` [PATCH 04/12] dt-bindings: irqchip: ti, sci-intr: Update bindings to drop the usage of gic as parent Lokesh Vutla
2020-05-20 12:44   ` [PATCH 04/12] dt-bindings: irqchip: ti,sci-intr: " Lokesh Vutla
2020-05-28 22:14   ` [PATCH 04/12] dt-bindings: irqchip: ti, sci-intr: " Rob Herring
2020-05-28 22:14     ` [PATCH 04/12] dt-bindings: irqchip: ti,sci-intr: " Rob Herring
2020-05-29 10:14     ` [PATCH 04/12] dt-bindings: irqchip: ti, sci-intr: " Lokesh Vutla
2020-05-29 10:14       ` [PATCH 04/12] dt-bindings: irqchip: ti,sci-intr: " Lokesh Vutla
2020-05-29 10:18       ` [PATCH 04/12] dt-bindings: irqchip: ti, sci-intr: " Marc Zyngier
2020-05-29 10:18         ` [PATCH 04/12] dt-bindings: irqchip: ti,sci-intr: " Marc Zyngier
2020-06-01 11:36         ` [PATCH 04/12] dt-bindings: irqchip: ti, sci-intr: " Lokesh Vutla
2020-06-01 11:36           ` Lokesh Vutla
2020-06-15  8:03           ` Lokesh Vutla
2020-06-15  8:03             ` Lokesh Vutla
2020-06-15  8:34             ` Marc Zyngier [this message]
2020-06-15  8:34               ` Marc Zyngier
2020-07-09  9:40               ` Lokesh Vutla
2020-07-09  9:40                 ` Lokesh Vutla
2020-05-29 11:13     ` Lokesh Vutla
2020-05-29 11:13       ` [PATCH 04/12] dt-bindings: irqchip: ti,sci-intr: " Lokesh Vutla
2020-05-20 12:44 ` [PATCH 05/12] dt-bindings: irqchip: Convert ti, sci-intr bindings to yaml Lokesh Vutla
2020-05-20 12:44   ` [PATCH 05/12] dt-bindings: irqchip: Convert ti,sci-intr " Lokesh Vutla
2020-05-20 12:44 ` [PATCH 06/12] irqchip/ti-sci-intr: Add support for INTR being a parent to INTR Lokesh Vutla
2020-05-20 12:44   ` Lokesh Vutla
2020-05-20 12:44 ` [PATCH 07/12] dt-bindings: irqchip: ti, sci-inta: Update docs to support different parent Lokesh Vutla
2020-05-20 12:44   ` [PATCH 07/12] dt-bindings: irqchip: ti,sci-inta: " Lokesh Vutla
2020-05-20 12:44 ` [PATCH 08/12] dt-bindings: irqchip: Convert ti, sci-inta bindings to yaml Lokesh Vutla
2020-05-20 12:44   ` [PATCH 08/12] dt-bindings: irqchip: Convert ti,sci-inta " Lokesh Vutla
2020-05-20 12:44 ` [PATCH 09/12] irqchip/ti-sci-inta: Add support for INTA directly connecting to GIC Lokesh Vutla
2020-05-20 12:44   ` Lokesh Vutla
2020-05-20 12:44 ` [PATCH 10/12] arm64: dts: k3-j721e: ti-sci-inta/intr: Update to latest bindings Lokesh Vutla
2020-05-20 12:44   ` Lokesh Vutla
2020-05-20 12:44 ` [PATCH 11/12] arm64: dts: k3-am65: " Lokesh Vutla
2020-05-20 12:44   ` Lokesh Vutla
2020-05-20 12:44 ` [PATCH 12/12] arm64: dts: k3-am65: Update the RM resource types Lokesh Vutla
2020-05-20 12:44   ` Lokesh Vutla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9afd8a79d9c9ecfd35b6a4e66c93e298@kernel.org \
    --to=maz@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lokeshvutla@ti.com \
    --cc=nm@ti.com \
    --cc=nsekhar@ti.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=robh@kernel.org \
    --cc=ssantosh@kernel.org \
    --cc=t-kristo@ti.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.