From mboxrd@z Thu Jan  1 00:00:00 1970
From: xiaofeis@codeaurora.org
Subject: Re: [PATCH] net: dsa: Inherit dev addr from master
Date: Wed, 27 Mar 2019 12:09:07 +0800
Message-ID: <9b81c4c88090606c25c75196ed2ec79c@codeaurora.org>
References: <20190222125654.12478-1-vkoul@kernel.org>
 <20190222143003.GL5653@lunn.ch>
 <441ae81a814498876e4cfed6fd5b7bcb@codeaurora.org>
 <20190225132107.GG20855@lunn.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <netdev-owner@vger.kernel.org>
In-Reply-To: <20190225132107.GG20855@lunn.ch>
Sender: netdev-owner@vger.kernel.org
To: Andrew Lunn <andrew@lunn.ch>
Cc: Vinod Koul <vkoul@kernel.org>, "David S. Miller" <davem@davemloft.net>, linux-arm-msm@vger.kernel.org, Bjorn Andersson <bjorn.andersson@linaro.org>, Vivien Didelot <vivien.didelot@gmail.com>, Florian Fainelli <f.fainelli@gmail.com>, Niklas Cassel <niklas.cassel@linaro.org>, netdev@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org

On 2019-02-25 21:21, Andrew Lunn wrote:
>> I think we can remove the first inherit, but if keep it, we can see
>> consistent address output by ifconfig -a before open master and slave
>> interface.
> 
> True
> 
> But it also means we see inconsistent MAC addresses on the master. The
> MAC address changes on open.
> 
> Maybe it would be better to change your master so it sets its MAC
> address during probe? Everything is then consistent all the time.
> 
> 	Andrew
I'm trying to suggest our master driver owner to set MAC address during 
probe.

I found in kernel, different driver has different implementation, some 
set it in probe, while
some in open. DSA should be generic to work with all these master 
drivers. I think this change
can help. Thanks.