From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 894EBC55822 for ; Mon, 3 Aug 2026 17:48:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/QpwCR1gWmaEH3r7j6VRXYmAnNj2248l8sEz16nP5fk=; b=3dgMfvHhF70zGY IuMOhOVTgM3AwRbqtmfcJDIcfj4/YE9Ez14bPWsEe3sZPPBkfShA2JDTIuSOYCWUtQtg0caPDYHrh ii/6YxoAOaIrh5Qo71/ZFtDpcncxzUC+nxjkaRELJx0K+ZeTbETL51l7hi6UZJ4ssVd50wblgWeXu KIurqrhzMS1studz6g0+cyFPnYMhCvqp96OZbimaxgtj3VRJSLQkiWOtu1nWQmX0N1gnqzqIk/vAk /xeUzDN5zQUn7xGrKyjLguMGkOwGKmQ2MFOa5Fe4BBwN9O4jTdpArywNZkQNJ43bxCDAd2SdS3Nt8 TSvWZWhURC+sy1tBtp5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wqwm7-00000000GSJ-3LtU; Mon, 03 Aug 2026 17:48:31 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wqwm5-00000000GRG-1mFu; Mon, 03 Aug 2026 17:48:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=cSyyM7BUXIDF3kJhgyCmgOwoW98OlpC1I9i3DPZMz2s=; b=u1 kXI2+R12w43beaPSCbM1HCJtvorD9d3Ebq53sQZR3ik4voCij2lPlW5oXM+0wRshrRMCr87mcUHo7 XN23BeKdWZNVXSS4v3jExOreZBR9tOxH6d4xKQfMcUyCUx/18N/JTdJBnEYVUqcMnpK/q5TYssUsX zXFXTFEDjez0ehA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wqwlg-00Fn1q-LQ; Mon, 03 Aug 2026 19:48:04 +0200 Date: Mon, 3 Aug 2026 19:48:04 +0200 From: Andrew Lunn To: James Hilliard Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andre Przywara , Richard Genoud , Maxime Ripard , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin , Heiner Kallweit , Russell King , Saravana Kannan , Lee Jones , Heiko Stuebner , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, mfd@lists.linux.dev, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 10/21] net: phy: add X-Powers AC200 EPHY control driver Message-ID: <9b8be475-1fde-409c-a82e-be4b2e402650@lunn.ch> References: <20260802-submit-acx00-of-dynamic-v1-v1-0-0a53cd9e21cc@gmail.com> <20260802-submit-acx00-of-dynamic-v1-v1-10-0a53cd9e21cc@gmail.com> <05b1e6a2-725e-4b8e-8629-249637bbcb81@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260803_104829_462135_A684812E X-CRM114-Status: GOOD ( 16.58 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gTW9uLCBBdWcgMDMsIDIwMjYgYXQgMTA6MDk6MDFBTSAtMDYwMCwgSmFtZXMgSGlsbGlhcmQg d3JvdGU6Cj4gT24gTW9uLCBBdWcgMywgMjAyNiBhdCA3OjUx4oCvQU0gQW5kcmV3IEx1bm4gPGFu ZHJld0BsdW5uLmNoPiB3cm90ZToKPiA+Cj4gPiA+ICtzdGF0aWMgaW50Cj4gPiA+ICthYzIwMF9l cGh5X2N0bF9zZXRfbGVkX291dHB1dHMoc3RydWN0IGFjeDAwX2VwaHlfY29udHJvbCAqY29udHJv bCwKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIG91dHB1 dHMpCj4gPiA+ICt7Cj4gPiA+ICt9Cj4gPgo+ID4gPiArc3RhdGljIGludAo+ID4gPiArYWMyMDBf ZXBoeV9jdGxfc2V0X2xlZF9wb2xhcml0eShzdHJ1Y3QgYWN4MDBfZXBoeV9jb250cm9sICpjb250 cm9sLAo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBib29sIGFjdGl2ZV9sb3cp Cj4gPiA+ICt7Cj4gPiA+ICt9Cj4gPgo+ID4gSSd2ZSBub3QgbG9va2VkIGludG8gdGhlIGRldGFp bHMsIGJ1dCB0aGVzZSBsb29rIGxpa2UgcGlubXV4LiBEb2VzCj4gPiB0aGlzIEkyQyBkZXZpY2Ug aGF2ZSBhIEdQSU8gY29udHJvbGxlcj8gQ2FuIHRoZXNlIHBpbnMgYmUgdXNlZCBmb3IKPiA+IG90 aGVyIHRoaW5ncyB0aGFuIExFRHM/IE1heWJlIHlvdSBzaG91bGQgYmUgaW1wbGVtZW50aW5nIGEg R1BJTyBhbmQKPiA+IHBpbm11eCBkcml2ZXIuIFRoZSBFdGhlcm5ldCBQSFkgZHJpdmVyIGNhbiB0 aGVuIGp1c3Qgc2VsZWN0IHRoZQo+ID4gY29ycmVjdCBwaW5tdXggY29uZmlndXJhdGlvbi4KPiAK PiBUaGVzZSBkbyBub3QgYXBwZWFyIHRvIGJlIEdQSU8gb3IgbXV4YWJsZSBwaW5zLiBUaGUgQUMy MDAKPiBkb2N1bWVudGF0aW9uIGRlc2NyaWJlcyB0aGVtIGFzIHRocmVlIGRlZGljYXRlZCBFUEhZ IExFRAo+IG91dHB1dHM6IGxpbmsvYWN0aXZpdHksIHNwZWVkLCBhbmQgZHVwbGV4LiBUaGUgYml0 cyBpbiBTWVNfRVBIWV9DVEwxCj4gZW5hYmxlIHRob3NlIG91dHB1dCBwYWRzLCB3aGlsZSBFUEhZ X0NUTCBwcm92aWRlcyB0aGVpciBzaGFyZWQKPiBwb2xhcml0eSBzZXR0aW5nLiBJIGhhdmUgbm90 IGZvdW5kIGFueSBkb2N1bWVudGVkIEdQSU8gZGF0YQo+IHJlZ2lzdGVycyBvciBhbHRlcm5hdGl2 ZSBmdW5jdGlvbnMgZm9yIHRoZXNlIHBpbnMuCgpTbyB3aGF0IGknbSB0cnlpbmcgdG8gZG8gd2l0 aCBib3RoIG9mIHRoZXNlIGlzIG1ha2UgaXQgbG9vayBtb3JlIGxpa2UKc3RhbmRhcmQgTGludXgg YnVpbGRpbmcgYmxvY2tzLgoKSWYgdGhhdCBpcyBub3QgcG9zc2libGUsIGkgd291bGQgYWN0dWFs bHkgcHV0IGFsbCB0aGlzIGNvZGUgaW50byB0aGUKUEhZIGRyaXZlci4gWW91IHRoZW4gaGF2ZSBh IHJlZ21hcCBwcm9wZXJ0eSB0byBnYWluIGFjY2VzcyB0byB0aGUgSTJDCnJlZ2lzdGVycy4KCiAg ICAgICBBbmRyZXcKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EEF23955D8; Mon, 3 Aug 2026 17:48:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785779307; cv=none; b=QB4Ia2mxElafoTfDh4eVVw+EwpCZrctHURt6oqr4dP//Y1lEUhpOygLOHwlWYXmjCGFDaj8nU8OBNf8o/g6GyRrfp4BNVVOI9+bCsuitspByZM+gel/17kVOB5qzmnvqSBzzuqQu6bUHjdTedvemIIHHoTaL/ALjo3BvhLQ6RVI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785779307; c=relaxed/simple; bh=65cb7UEHUvs9af0Ej+kL97qAT27LpOyQMo8mrY/QLik=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uO2kGNc8vHV1ucw58dFTTopdo0OO7+N9InqvqsBoC6OH7zAZAVkcuBN8k6OusrQ7WF0XZhKucuUyBcW42Yl26MvcIAatKvXFpd9XMja4ShLLeJPvByg/ZlVpwIIl8HUKLsmVtf5DxYUB570KyqcSu8fGOVgAuOJP1FKnzJgtTMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=u1kXI2+R; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="u1kXI2+R" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=cSyyM7BUXIDF3kJhgyCmgOwoW98OlpC1I9i3DPZMz2s=; b=u1 kXI2+R12w43beaPSCbM1HCJtvorD9d3Ebq53sQZR3ik4voCij2lPlW5oXM+0wRshrRMCr87mcUHo7 XN23BeKdWZNVXSS4v3jExOreZBR9tOxH6d4xKQfMcUyCUx/18N/JTdJBnEYVUqcMnpK/q5TYssUsX zXFXTFEDjez0ehA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wqwlg-00Fn1q-LQ; Mon, 03 Aug 2026 19:48:04 +0200 Date: Mon, 3 Aug 2026 19:48:04 +0200 From: Andrew Lunn To: James Hilliard Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andre Przywara , Richard Genoud , Maxime Ripard , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin , Heiner Kallweit , Russell King , Saravana Kannan , Lee Jones , Heiko Stuebner , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, mfd@lists.linux.dev, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 10/21] net: phy: add X-Powers AC200 EPHY control driver Message-ID: <9b8be475-1fde-409c-a82e-be4b2e402650@lunn.ch> References: <20260802-submit-acx00-of-dynamic-v1-v1-0-0a53cd9e21cc@gmail.com> <20260802-submit-acx00-of-dynamic-v1-v1-10-0a53cd9e21cc@gmail.com> <05b1e6a2-725e-4b8e-8629-249637bbcb81@lunn.ch> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Aug 03, 2026 at 10:09:01AM -0600, James Hilliard wrote: > On Mon, Aug 3, 2026 at 7:51 AM Andrew Lunn wrote: > > > > > +static int > > > +ac200_ephy_ctl_set_led_outputs(struct acx00_ephy_control *control, > > > + unsigned long outputs) > > > +{ > > > +} > > > > > +static int > > > +ac200_ephy_ctl_set_led_polarity(struct acx00_ephy_control *control, > > > + bool active_low) > > > +{ > > > +} > > > > I've not looked into the details, but these look like pinmux. Does > > this I2C device have a GPIO controller? Can these pins be used for > > other things than LEDs? Maybe you should be implementing a GPIO and > > pinmux driver. The Ethernet PHY driver can then just select the > > correct pinmux configuration. > > These do not appear to be GPIO or muxable pins. The AC200 > documentation describes them as three dedicated EPHY LED > outputs: link/activity, speed, and duplex. The bits in SYS_EPHY_CTL1 > enable those output pads, while EPHY_CTL provides their shared > polarity setting. I have not found any documented GPIO data > registers or alternative functions for these pins. So what i'm trying to do with both of these is make it look more like standard Linux building blocks. If that is not possible, i would actually put all this code into the PHY driver. You then have a regmap property to gain access to the I2C registers. Andrew