From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66B32C636D6 for ; Thu, 23 Feb 2023 17:39:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229588AbjBWRj1 (ORCPT ); Thu, 23 Feb 2023 12:39:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjBWRj1 (ORCPT ); Thu, 23 Feb 2023 12:39:27 -0500 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B11A215CA6; Thu, 23 Feb 2023 09:39:24 -0800 (PST) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id D825080AE4; Thu, 23 Feb 2023 18:39:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1677173963; bh=O3IRV+shEDtZsoaALUQKrtNo9sDC2VLCvqXxuJK8bUQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Gyqof24y1xX0/Da9dgFTlfK4TWqU2HB3AiaJqSMsRuLJ8xZtWb83CjYuHqxUqhRp0 8zuqWw84XyUP3/7QkUMemeVZMJPKVmfuS6VLSVW1OtkbMOoQIEIcNbE9csulJXEVB5 NTDWsoegBjAx0Oj6WgCcAjWR6ybVH2L9OY1pF2CLEAWufNlBSEr4sN2EuIfsjKdIMl uL/F4SZmqIj6mw+wKZDnPXo0oG8RJmZkZKIJNn04uatwyLBJNDdEGl4Lu4Vc1Qx3hk 157V6qkIDMc/lpV1Luf6QlhDb/xpeztpFlMiHWBXy/lUUX96PdAEqwGnR5bLogvb4w FCkBf6MX4mAyg== Message-ID: <9bcaaa02-d9e6-1086-91bf-b94a10330577@denx.de> Date: Thu, 23 Feb 2023 18:39:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 5/5] arm64: dts: imx8mp: Add analog audio output on i.MX8MP EVK Content-Language: en-US To: Fabio Estevam Cc: linux-clk@vger.kernel.org, Abel Vesa , Jacky Bai , Krzysztof Kozlowski , Laurent Pinchart , Lucas Stach , Marco Felsch , Michael Turquette , NXP Linux Team , Peng Fan , Pengutronix Kernel Team , Richard Cochran , Rob Herring , Sascha Hauer , Shawn Guo , Stephen Boyd , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Luca Ceresoli References: <20230223171114.59164-1-marex@denx.de> <20230223171114.59164-5-marex@denx.de> From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 2/23/23 18:28, Fabio Estevam wrote: > Hi Marek, Hi, > On Thu, Feb 23, 2023 at 2:11 PM Marek Vasut wrote: > >> + reg_audio_pwr: regulator-audio-pwr { >> + compatible = "regulator-fixed"; >> + regulator-name = "audio-pwr"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + gpio = <&gpio4 29 GPIO_ACTIVE_HIGH>; >> + enable-active-high; >> + regulator-always-on; > > It seems that "regulator-always-on" could be removed as the regulator > is controlled by the codec. Ah yes > Reviewed-by: Fabio Estevam Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51235C636D6 for ; Thu, 23 Feb 2023 17:40:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hZ9KZ6qJWiEvUew6ULcFIydoIxdfH0U6RUMDkDIhNOk=; b=uMTBabPx06iums Qqs/her85625LmbN1M+HI51DZt5dbLEjyEJZ3h967LSudUe7uhuPwyCjnqdyXdPfsJCZXa6h8OwFy EvtlwYBbCzhWnqrOOiRqrbzodXP1ZcndlSON+7X+yEQ7jXD/Xly5SnLgac8u8LecSattVA9HSqfeQ ed60ZmbTtM+OegmnIVhmGWvPFwL7bpEHwGo3gegrcF2wx150trtiIIN/gbPDvH73hFVSHfrjf5Sol P0kk7mRElFRiKE7xbo227uinMYZjK4xL+9WFPDE86/l27mM1X1HRjqnYkmczi/37s7AiVCbrjkfGu 7g/hBiciCxDYZa7AgsMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pVFZ3-00HOQ3-Ml; Thu, 23 Feb 2023 17:39:29 +0000 Received: from phobos.denx.de ([2a01:238:438b:c500:173d:9f52:ddab:ee01]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pVFZ0-00HOOv-RW for linux-arm-kernel@lists.infradead.org; Thu, 23 Feb 2023 17:39:28 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id D825080AE4; Thu, 23 Feb 2023 18:39:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1677173963; bh=O3IRV+shEDtZsoaALUQKrtNo9sDC2VLCvqXxuJK8bUQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Gyqof24y1xX0/Da9dgFTlfK4TWqU2HB3AiaJqSMsRuLJ8xZtWb83CjYuHqxUqhRp0 8zuqWw84XyUP3/7QkUMemeVZMJPKVmfuS6VLSVW1OtkbMOoQIEIcNbE9csulJXEVB5 NTDWsoegBjAx0Oj6WgCcAjWR6ybVH2L9OY1pF2CLEAWufNlBSEr4sN2EuIfsjKdIMl uL/F4SZmqIj6mw+wKZDnPXo0oG8RJmZkZKIJNn04uatwyLBJNDdEGl4Lu4Vc1Qx3hk 157V6qkIDMc/lpV1Luf6QlhDb/xpeztpFlMiHWBXy/lUUX96PdAEqwGnR5bLogvb4w FCkBf6MX4mAyg== Message-ID: <9bcaaa02-d9e6-1086-91bf-b94a10330577@denx.de> Date: Thu, 23 Feb 2023 18:39:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 5/5] arm64: dts: imx8mp: Add analog audio output on i.MX8MP EVK Content-Language: en-US To: Fabio Estevam Cc: linux-clk@vger.kernel.org, Abel Vesa , Jacky Bai , Krzysztof Kozlowski , Laurent Pinchart , Lucas Stach , Marco Felsch , Michael Turquette , NXP Linux Team , Peng Fan , Pengutronix Kernel Team , Richard Cochran , Rob Herring , Sascha Hauer , Shawn Guo , Stephen Boyd , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Luca Ceresoli References: <20230223171114.59164-1-marex@denx.de> <20230223171114.59164-5-marex@denx.de> From: Marek Vasut In-Reply-To: X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230223_093927_077027_3E5245B8 X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/23/23 18:28, Fabio Estevam wrote: > Hi Marek, Hi, > On Thu, Feb 23, 2023 at 2:11 PM Marek Vasut wrote: > >> + reg_audio_pwr: regulator-audio-pwr { >> + compatible = "regulator-fixed"; >> + regulator-name = "audio-pwr"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + gpio = <&gpio4 29 GPIO_ACTIVE_HIGH>; >> + enable-active-high; >> + regulator-always-on; > > It seems that "regulator-always-on" could be removed as the regulator > is controlled by the codec. Ah yes > Reviewed-by: Fabio Estevam Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel