Re: [PATCH RFC v2 1/7] mm/memcontrol: drop unused vmscan tracepoint include

[Ridong Chen <ridong.chen@linux.dev>]

On 9/28/2026 8:08 PM, Muchun Song wrote:
> 
> 
>> On Sep 28, 2026, at 19:46, Ridong Chen <ridong.chen@linux.dev> wrote:
>>
>> From: Ridong Chen <chenridong@xiaomi.com>
>>
>> memcontrol.c includes <trace/events/vmscan.h> but does not use any of
>> the tracepoints or macros it defines: all tracepoints invoked here come
>> from memcg.h and writeback.h.  Removing the include still compiles
>> cleanly.
>>
>> Assisted-by: Claude:claude-opus-4-8
> 
> Since commit 816d9992d9ed, the label we recommend is Assisted-by: LLM.
> 

Thank you for the reminder; I will update it in the next version.


>> Signed-off-by: Ridong Chen <chenridong@xiaomi.com>
>> ---
>> mm/memcontrol.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
>> index aad0498a7bd6..95c2322d4a6f 100644
>> --- a/mm/memcontrol.c
>> +++ b/mm/memcontrol.c
>> @@ -77,8 +77,6 @@
>> #include <trace/events/memcg.h>
>> #undef CREATE_TRACE_POINTS
>>
>> -#include <trace/events/vmscan.h>
>> -
>> struct cgroup_subsys memory_cgrp_subsys __read_mostly;
>> EXPORT_SYMBOL(memory_cgrp_subsys);
> 
> Acked-by: Muchun Song <muchun.song@linux.dev>
> 
> Thanks.

-- 
Best regards
Ridong