From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9738C433F5 for ; Mon, 4 Apr 2022 05:55:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 6DC9982503; Mon, 4 Apr 2022 05:55:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HucpqSwu0sqY; Mon, 4 Apr 2022 05:55:35 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 659B382B94; Mon, 4 Apr 2022 05:55:35 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 30784C002C; Mon, 4 Apr 2022 05:55:35 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2B232C0012 for ; Mon, 4 Apr 2022 05:55:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 0365D404C7 for ; Mon, 4 Apr 2022 05:55:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=intel.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zyjAsPzjHlkB for ; Mon, 4 Apr 2022 05:55:32 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by smtp2.osuosl.org (Postfix) with ESMTPS id 6792840142 for ; Mon, 4 Apr 2022 05:55:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649051732; x=1680587732; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=VRzHUmWn6xSVl9VxnZQQsCjifYYpTLqDX0N+7W19r24=; b=Mr/1b8B743QBaHN+Dif0YH7Q8MiPkZBkd7o1bwt3baplIt2k4/kxOXNu dL5fd8g3NsEEJD6Fl8HJqzVs3Rs1o2uPjVLi/XReW9QjmJ4SUMl2ZRTOi 7U4zq+kBTpBhrqaTk/E1RcW2aIFsyp6jP+1KXAopChr18nhdRPBXZOM7d ndvUbeiEcLEhQgDjzRq92C53/SsLbeShcOV7hM0oTgtLLfxY0ianVZPIy uwYTlHjfdGsf6MTO1RcgI/oDGMHVUR6A5dOw+zYRCpaIgInS5Ar6xQI2w exPXFOY6Kt1ElCGa68EBThzihHZenMtYaGAJ11rVga7LkTG5kSPIwjH2A w==; X-IronPort-AV: E=McAfee;i="6200,9189,10306"; a="242585667" X-IronPort-AV: E=Sophos;i="5.90,233,1643702400"; d="scan'208";a="242585667" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2022 22:55:31 -0700 X-IronPort-AV: E=Sophos;i="5.90,233,1643702400"; d="scan'208";a="548533670" Received: from blu2-mobl3.ccr.corp.intel.com (HELO [10.254.214.140]) ([10.254.214.140]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2022 22:55:28 -0700 Message-ID: <9be015a3-c436-5829-b117-e0a70bc29954@linux.intel.com> Date: Mon, 4 Apr 2022 13:55:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH RFC v2 08/11] iommu/sva: Use attach/detach_pasid_dev in SVA interfaces Content-Language: en-US To: Jason Gunthorpe , Jacob Pan References: <20220329053800.3049561-1-baolu.lu@linux.intel.com> <20220329053800.3049561-9-baolu.lu@linux.intel.com> <20220331135922.6c677117@jacob-builder> <20220331222630.GI2120790@nvidia.com> From: Lu Baolu In-Reply-To: <20220331222630.GI2120790@nvidia.com> Cc: Kevin Tian , Ashok Raj , Robin Murphy , linux-kernel@vger.kernel.org, Christoph Hellwig , Jean-Philippe Brucker , iommu@lists.linux-foundation.org, Will Deacon X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 2022/4/1 6:26, Jason Gunthorpe wrote: > On Thu, Mar 31, 2022 at 01:59:22PM -0700, Jacob Pan wrote: > >>> + handle->dev = dev; >>> + handle->domain = domain; >>> + handle->pasid = mm->pasid; >> why do we need to store pasid here? Conceptually, pasid is per sva domain >> not per bind. You can get it from handle->domain->sva_cookie. > That is a mistake - SVA needs to follow the general PASID design - the > domain does not encode the PASID, the PASID comes from the device You are right. We should not store any pasid information in the domain. Best regards, baolu _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6432AC433F5 for ; Mon, 4 Apr 2022 05:55:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377374AbiDDF5e (ORCPT ); Mon, 4 Apr 2022 01:57:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235279AbiDDF52 (ORCPT ); Mon, 4 Apr 2022 01:57:28 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02EB03299B for ; Sun, 3 Apr 2022 22:55:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649051731; x=1680587731; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=VRzHUmWn6xSVl9VxnZQQsCjifYYpTLqDX0N+7W19r24=; b=dxlgT20QbBZrsOtwgshOPhhSvrsh+oc8xWUVzKpZOYggbdc+2CiwdwuZ NhK7JUpcO6MOev1YU01BojrtHMk1+2FnVxnmtolYW/FG8OkrcuhwyTgkV ywr9RA/xggYJzZTO8wz0TYdeLBhz/+DTKG9d0FJ55H/NJWYNHQhw3Wfbh cXx3ORRNcI1GCAN0UH/qS9wEi4Uj3/FcQZ0dE1MH19nfAvjebOsPDJBxI GREJdaUPZ6f1Fk6RjKL5is0klsCD1f3qpDFd2Uy7acfC9YGtI27kAPVrj jcQdnXFcp3PUnFgU4A0yik47zyMhkEgzFVYHWU41IbyuuNOjGeJhm0lb5 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10306"; a="260622957" X-IronPort-AV: E=Sophos;i="5.90,233,1643702400"; d="scan'208";a="260622957" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2022 22:55:31 -0700 X-IronPort-AV: E=Sophos;i="5.90,233,1643702400"; d="scan'208";a="548533670" Received: from blu2-mobl3.ccr.corp.intel.com (HELO [10.254.214.140]) ([10.254.214.140]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2022 22:55:28 -0700 Message-ID: <9be015a3-c436-5829-b117-e0a70bc29954@linux.intel.com> Date: Mon, 4 Apr 2022 13:55:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Cc: baolu.lu@linux.intel.com, Joerg Roedel , Christoph Hellwig , Kevin Tian , Ashok Raj , Will Deacon , Robin Murphy , Jean-Philippe Brucker , Eric Auger , Liu Yi L , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC v2 08/11] iommu/sva: Use attach/detach_pasid_dev in SVA interfaces Content-Language: en-US To: Jason Gunthorpe , Jacob Pan References: <20220329053800.3049561-1-baolu.lu@linux.intel.com> <20220329053800.3049561-9-baolu.lu@linux.intel.com> <20220331135922.6c677117@jacob-builder> <20220331222630.GI2120790@nvidia.com> From: Lu Baolu In-Reply-To: <20220331222630.GI2120790@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/4/1 6:26, Jason Gunthorpe wrote: > On Thu, Mar 31, 2022 at 01:59:22PM -0700, Jacob Pan wrote: > >>> + handle->dev = dev; >>> + handle->domain = domain; >>> + handle->pasid = mm->pasid; >> why do we need to store pasid here? Conceptually, pasid is per sva domain >> not per bind. You can get it from handle->domain->sva_cookie. > That is a mistake - SVA needs to follow the general PASID design - the > domain does not encode the PASID, the PASID comes from the device You are right. We should not store any pasid information in the domain. Best regards, baolu