All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Farman <farman@linux.ibm.com>
To: jrossi@linux.ibm.com, qemu-devel@nongnu.org,
	qemu-s390x@nongnu.org, cohuck@redhat.com, mjrosato@linux.ibm.com
Cc: jjherne@linux.ibm.com, zycai@linux.ibm.com
Subject: Re: [PATCH v3 6/8] pc-bios/s390-ccw: Add support for virtio-scsi-pci IPL
Date: Wed, 2 Sep 2026 06:18:07 -0400	[thread overview]
Message-ID: <9be45df8-464f-45a5-8d63-4dea4c07ce44@linux.ibm.com> (raw)
In-Reply-To: <20260831194919.3830270-7-jrossi@linux.ibm.com>



On 8/31/26 3:49 PM, jrossi@linux.ibm.com wrote:
> From: Jared Rossi <jrossi@linux.ibm.com>
> 
> Read virtio-pci configuration and configure virt-queue for scsi devices.
> 
> Also add check for virtio setup failures when doing scsi setup and return
> early if it fails instead of waiting for subsequent failure.
> 
> Signed-off-by: Jared Rossi <jrossi@linux.ibm.com>
> ---
>   pc-bios/s390-ccw/main.c        |  3 ++-
>   pc-bios/s390-ccw/virtio-pci.c  | 30 ++++++++++++++++++++++++++++++
>   pc-bios/s390-ccw/virtio-scsi.c | 18 +++++++++++++++++-
>   3 files changed, 49 insertions(+), 2 deletions(-)

Thanks for fixing up the (lack of) return code check.

Reviewed-by: Eric Farman <farman@linux.ibm.com>


  reply	other threads:[~2026-09-02 10:18 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31 19:49 [PATCH v3 0/8] s390x: Add support for virtio-scsi-pci boot device jrossi
2026-08-31 19:49 ` [PATCH v3 1/8] pc-bios/s390-ccw: Check if a PCI function is already enabled before trying to enable it jrossi
2026-09-03 12:44   ` Jason J. Herne
2026-08-31 19:49 ` [PATCH v3 2/8] hw/s390x/ipl: Fix incorrect PCI IPL block lengths jrossi
2026-09-02  9:53   ` Eric Farman
2026-09-03 12:56   ` Jason J. Herne
2026-09-09 15:03   ` Matthew Rosato
2026-08-31 19:49 ` [PATCH v3 3/8] pc-bios/s390-ccw: Use bus specific IPL_TYPE directly for scsi IPL jrossi
2026-09-03 13:15   ` Jason J. Herne
2026-08-31 19:49 ` [PATCH v3 4/8] s390x/ipl: Add PCI and bus fields to IplBlockQemuScsi jrossi
2026-09-03 13:53   ` Jason J. Herne
2026-08-31 19:49 ` [PATCH v3 5/8] pc-bios/s390-ccw: Abstract virtio_run() for generic use jrossi
2026-09-03 14:55   ` Jason J. Herne
2026-08-31 19:49 ` [PATCH v3 6/8] pc-bios/s390-ccw: Add support for virtio-scsi-pci IPL jrossi
2026-09-02 10:18   ` Eric Farman [this message]
2026-09-03 15:04   ` Jason J. Herne
2026-08-31 19:49 ` [PATCH v3 7/8] s390x: Find scsi-pci boot device and build IPLB jrossi
2026-09-01  2:54   ` Joshua Daley
2026-09-02 20:19   ` Eric Farman
2026-09-03 19:07   ` Jason J. Herne
2026-08-31 19:49 ` [PATCH v3 8/8] tests/qtest: Add s390x PCI SCSI fallback test to cdrom-test.c jrossi
2026-09-01  2:06   ` Joshua Daley
2026-09-02 20:44   ` Eric Farman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9be45df8-464f-45a5-8d63-4dea4c07ce44@linux.ibm.com \
    --to=farman@linux.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=jjherne@linux.ibm.com \
    --cc=jrossi@linux.ibm.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=zycai@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.