From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH v3] drm/bridge: Build the panel wrapper in drm_kms_helper Date: Wed, 7 Jun 2017 13:49:19 +0530 Message-ID: <9be9f59f-3d6e-d68b-490e-68fa325a38fe@codeaurora.org> References: <20170602202514.11900-1-eric@anholt.net> <2ab4e84f-9834-1dce-d16a-14f9cc4083e9@codeaurora.org> <2cbcbf54-debf-10a1-390d-128171d81f91@linux.intel.com> <3fd262cf-1db6-4335-320c-af92f9014502@linux.intel.com> <87fufd9f60.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by gabe.freedesktop.org (Postfix) with ESMTPS id A03366E20A for ; Wed, 7 Jun 2017 08:19:24 +0000 (UTC) In-Reply-To: <87fufd9f60.fsf@eliezer.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt , Maarten Lankhorst , Andrzej Hajda , Laurent Pinchart , Thierry Reding Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org CgpPbiAwNi8wNi8yMDE3IDExOjIyIFBNLCBFcmljIEFuaG9sdCB3cm90ZToKPiBNYWFydGVuIExh bmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPiB3cml0ZXM6Cj4KPj4g VGhpcyBmaXhlcyB0aGUgZm9sbG93aW5nIGRlcG1vZCBlcnJvciB3aGVuIGJ1aWxkaW5nIGRybSBh cyBhIG1vZHVsZToKPj4gZGVwbW9kOiBFUlJPUjogRm91bmQgNiBtb2R1bGVzIGluIGRlcGVuZGVu Y3kgY3ljbGVzIQo+PiBkZXBtb2Q6IEVSUk9SOiBDeWNsZSBkZXRlY3RlZDogZHJtIC0+IGRybV9r bXNfaGVscGVyIC0+IGRybQo+Pgo+PiBGaXhlczogMTNkZmMwNTQwYTU3ICgiZHJtL2JyaWRnZTog UmVmYWN0b3Igb3V0IHRoZSBwYW5lbCB3cmFwcGVyIGZyb20gdGhlIGx2ZHMtZW5jb2RlciBicmlk Z2UuIikKPj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hv cnN0QGxpbnV4LmludGVsLmNvbT4KPgo+IExvb2tzIHBsYXVzaWJsZSB0byBtZS4gIEdpdmVuIGhv dyBtdWNoIHRyb3VibGUgSSd2ZSBoYWQgZ2V0dGluZyB0aGUKPiBrYnVpbGQgcmlnaHQsIGFueW9u ZSBlbHNlIHdhbnQgdG8gY2hpbWUgaW4/Cj4KClRoZSBmaXggbG9va3MgZ29vZCB0byBtZSB0b28u IGRlcG1vZCBkb2Vzbid0IGNvbXBsYWluIGFmdGVyIHRoaXMgcGF0Y2guCgpJIGNhbiBxdWV1ZSBp dCB0byBkcm0tbWlzYy1uZXh0IGlmIG5vIG9uZSBlbHNlIGhhcyBhbnkgY29tbWVudHMgb24gaXQK aW4gdGhlIG5leHQgZmV3IGhvdXJzIG9yIHNvLgoKSSdsbCBtYWtlIHN1cmUgSSBjaGVjayB3aXRo ICdtYWtlIG1vZHVsZV9pbnN0YWxsJyBiZWZvcmUgcHVzaGluZywgSSBkaWRuJ3QKa25vdyBkZXBt b2Qgd2Fzbid0IGNhbGxlZCBvdGhlcndpc2UuCgpUaGFua3MsCkFyY2hpdAoKLS0gClF1YWxjb21t IElubm92YXRpb24gQ2VudGVyLCBJbmMuIGlzIGEgbWVtYmVyIG9mIENvZGUgQXVyb3JhIEZvcnVt LAphIExpbnV4IEZvdW5kYXRpb24gQ29sbGFib3JhdGl2ZSBQcm9qZWN0Cl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751509AbdFGIT1 (ORCPT ); Wed, 7 Jun 2017 04:19:27 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34328 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751464AbdFGITZ (ORCPT ); Wed, 7 Jun 2017 04:19:25 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 381AB60850 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCH v3] drm/bridge: Build the panel wrapper in drm_kms_helper To: Eric Anholt , Maarten Lankhorst , Andrzej Hajda , Laurent Pinchart , Thierry Reding References: <20170602202514.11900-1-eric@anholt.net> <2ab4e84f-9834-1dce-d16a-14f9cc4083e9@codeaurora.org> <2cbcbf54-debf-10a1-390d-128171d81f91@linux.intel.com> <3fd262cf-1db6-4335-320c-af92f9014502@linux.intel.com> <87fufd9f60.fsf@eliezer.anholt.net> Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org From: Archit Taneja Message-ID: <9be9f59f-3d6e-d68b-490e-68fa325a38fe@codeaurora.org> Date: Wed, 7 Jun 2017 13:49:19 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <87fufd9f60.fsf@eliezer.anholt.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/06/2017 11:22 PM, Eric Anholt wrote: > Maarten Lankhorst writes: > >> This fixes the following depmod error when building drm as a module: >> depmod: ERROR: Found 6 modules in dependency cycles! >> depmod: ERROR: Cycle detected: drm -> drm_kms_helper -> drm >> >> Fixes: 13dfc0540a57 ("drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.") >> Signed-off-by: Maarten Lankhorst > > Looks plausible to me. Given how much trouble I've had getting the > kbuild right, anyone else want to chime in? > The fix looks good to me too. depmod doesn't complain after this patch. I can queue it to drm-misc-next if no one else has any comments on it in the next few hours or so. I'll make sure I check with 'make module_install' before pushing, I didn't know depmod wasn't called otherwise. Thanks, Archit -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project