From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.01.org
Subject: Re: [PATCH] netdev: set connected to false in netdev_reassociate
Date: Fri, 30 Apr 2021 16:22:13 -0500 [thread overview]
Message-ID: <9bea686d-64d2-03e9-6930-aa1161c79916@gmail.com> (raw)
In-Reply-To: <20210430211526.291301-1-prestwoj@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 754 bytes --]
Hi James,
On 4/30/21 4:15 PM, James Prestwood wrote:
> Commit 1fe5070 added a workaround for drivers which may send the
> connect event prior to the connect callback/ack. This caused IWD
> to fail to start eapol if reassociation was used due to
> netdev_reassociate never setting netdev->connected = false.
>
> netdev_reassociate uses the same code path as normal connections,
> but when the connect callback came in connected was already set
> to true which then prevents eapol from being registered. Then,
> once the connect event comes in, there is no frame watch for
> eapol and IWD doesn't respond to any handshake frames.
> ---
> src/netdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
Applied, thanks.
Regards,
-Denis
prev parent reply other threads:[~2021-04-30 21:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 21:15 [PATCH] netdev: set connected to false in netdev_reassociate James Prestwood
2021-04-30 21:22 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bea686d-64d2-03e9-6930-aa1161c79916@gmail.com \
--to=denkenz@gmail.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.