From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65E7EC5DF9C for ; Mon, 24 Aug 2026 21:12:55 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wybxr-0004wp-KZ; Mon, 24 Aug 2026 17:12:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wybxq-0004wV-O1; Mon, 24 Aug 2026 17:12:18 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wybxo-00008b-WE; Mon, 24 Aug 2026 17:12:18 -0400 Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67OJW4Op2905148; Mon, 24 Aug 2026 21:12:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=TJBOKA YMDQdRuXDir7LOg8qWVMXWeTsww3CfUiPnP7o=; b=T+GKQCH1X9D/XbPOFwh6QH PzqBrXmVpC6nI65BN2X2VWlSbpvWE2FcN9wuMcNnGBrAHxM0HoBkRwJedycp3Zg/ W3wshYrAhM3/c919AfKBN30MBLAMJuI9hjaprV2bqPcrGjvLR6OvioQnS6L9VgZs k4BnhCOlKl7wDQC981pkPKYRx48e1Ao1Wfnf444q5JTk8wBbW03WKYimHkDDVM3I 1HpYGPTyhNYB9yBygp8ZCWSXm3OpKRmhdDxwOmZ9w4Uv+loF2Nl13xqz1hSKnKLj JOjoujUWAZU5nxaeH4TLrM3F6gsKicrH96ugE0tpbKbv3NQznZYPU4xsuLEi7V8w == Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4g73dx41aj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 24 Aug 2026 21:12:13 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 67OLBMCU021048; Mon, 24 Aug 2026 21:12:12 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4g7pfw0nnp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 24 Aug 2026 21:12:12 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 67OLCBqb19989058 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 24 Aug 2026 21:12:11 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3645358056; Mon, 24 Aug 2026 21:12:11 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 74D0158052; Mon, 24 Aug 2026 21:12:10 +0000 (GMT) Received: from [9.61.21.147] (unknown [9.61.21.147]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 24 Aug 2026 21:12:10 +0000 (GMT) Message-ID: <9c099ffc-6bb6-46f2-8e09-cc97c926a26b@linux.ibm.com> Date: Mon, 24 Aug 2026 17:12:10 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 05/15] s390x/pci: Move iotlb from S390PCIIOMMU to S390PCIBusDevice To: Konstantin Shkolnyy Cc: alifm@linux.ibm.com, farman@linux.ibm.com, richard.henderson@linaro.org, iii@linux.ibm.com, david@kernel.org, cohuck@redhat.com, pasic@linux.ibm.com, borntraeger@linux.ibm.com, qemu-s390x@nongnu.org, qemu-devel@nongnu.org References: <20260818172521.223460-1-kshk@linux.ibm.com> <20260818172521.223460-6-kshk@linux.ibm.com> From: Matthew Rosato Content-Language: en-US In-Reply-To: <20260818172521.223460-6-kshk@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Info: AW1haW4tMjYwODI0MDE3OCBTYWx0ZWRfXxENWuPXoHApp d8AuP80R37p9ffLsog6/s3OAYXYt0fabn6NjSS0HTEfyJq3uj6Nq5SA9D114YNoqde+DAG9UlfB A6m+/HX+kmRLxEQi078COjTldQMJRKc= X-Authority-Analysis: v=2.4 cv=AYuB2XXG c=1 sm=1 tr=0 ts=6a8cb3ad cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8 a=cyitXeQsElXgarLFEw8A:9 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: R2c38nx-rBkFQTaaw8Lj_bl0xK7kWYsl X-Proofpoint-GUID: R2c38nx-rBkFQTaaw8Lj_bl0xK7kWYsl X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI0MDE3OCBTYWx0ZWRfXwpmxCDtrStUF jooZ5Z2C1PLUM3c6vKj9wbSp9ZE1oNlHcKdOmwlYk1NDrINd98r96TQTYvaCdBzdO+awLcYBeaX HsrvKqy1ApCYf2L1qAb0EflOPEq49UnHlKyjvMuDHdPLWl8CfiWpn0wN+c/SE5xNtbU6e73A98D F/puAK/mtekbQtRF7rS5zXTu17M6Gg5IBMJcxRgopbDTkT8PtzW/9SD+tbePcXzFdwUNooQTOg8 9SjUaF337LC47Erc71pBiIR5T+s+CwDJ6lXHkJAgqAw9xRrdUFAauVKsf1jttiMGCNZnuj0BgmD qnp6sYTvcKJgHjG9AQjDCxg3CeL3+SdiZ/yP8xj7aHA73TT1ImjF0evW1/toBTpd20YBN41s/oF tZ0lam2FHzM83//Ysg+yvQ6hd+wJCVEXBYIpW8rY+QxgpXQyUkvrqDro68yoZt8p4gnZwQfBuL6 R1a7j2nevCXMyZF9XTg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-24_06,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 clxscore=1015 adultscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608240178 Received-SPF: pass client-ip=148.163.158.5; envelope-from=mjrosato@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 8/18/26 1:25 PM, Konstantin Shkolnyy wrote: > This field is only used when S390PCIBusDevice exists, so it can be moved > there to simplify S390PCIIOMMU which purpose is just to store the "root" > AddressSpace. > > Reviewed-by: Farhan Ali > Signed-off-by: Konstantin Shkolnyy With commit message fixed as described in patch 3: Reviewed-by: Matthew Rosato