From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Douglas Anderson <dianders@chromium.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jesszhan0024@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
mpearson-lenovo@squebb.ca, abel.vesa@oss.qualcomm.com,
sibi.sankar@oss.qualcomm.com
Subject: Re: [PATCH 1/4] dt-bindings: arm: qcom: add Lenovo ThinkPad T14s Gen 7 (Mahua)
Date: Tue, 15 Sep 2026 14:41:19 +0100 [thread overview]
Message-ID: <9c09c1f5-cffc-421a-96df-753b294d63cd@oss.qualcomm.com> (raw)
In-Reply-To: <20260915-nimble-wakeful-stingray-5beaed@quoll>
On 9/15/26 11:47 AM, Krzysztof Kozlowski wrote:
> On Sun, Sep 13, 2026 at 09:18:32PM +0100, Srinivas Kandagatla wrote:
>> Add lenovo,thinkpad-t14s-gen7 as a board compatible under qcom,mahua.
>> The T14s Gen 7 uses the Mahua SoC (a 12-core variant of Glymur with
>> cluster2 / cpu12-cpu17 fused off) rather than Glymur proper, matching
>> what the platform's ACPI MADT dump reports (12 enabled + 6 disabled
>> processors).
>
> There is variant with X2E and X2P processors, and on top of that touch
> and non-touch display. The first will be differentiated by SoC
> compatible but don't you need compatibles for the last part - display?
I only have the LCD variant in front of me
We could follow the Gen 6 T14s pattern (which already has the LCD/OLED
split upstream) and two variant SoCs for v2:
how about something like this?
- items:
- enum:
- lenovo,thinkpad-t14s-gen7-lcd
- lenovo,thinkpad-t14s-gen7-oled
- const: lenovo,thinkpad-t14s-gen7
- const: qcom,mahua
- const: qcom,<X2P SOCNAME>
--srini
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2026-09-15 13:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 20:18 [PATCH 0/4] arm64: dts: qcom: Add Lenovo ThinkPad T14s Gen 7 Srinivas Kandagatla
2026-09-13 20:18 ` [PATCH 1/4] dt-bindings: arm: qcom: add Lenovo ThinkPad T14s Gen 7 (Mahua) Srinivas Kandagatla
2026-09-15 10:47 ` Krzysztof Kozlowski
2026-09-15 13:41 ` Srinivas Kandagatla [this message]
2026-09-16 8:39 ` Krzysztof Kozlowski
2026-09-13 20:18 ` [PATCH 2/4] drm/panel-edp: add CSOT MNE007QB1-1 entry Srinivas Kandagatla
2026-09-14 7:34 ` Abel Vesa
2026-09-14 15:13 ` Doug Anderson
2026-09-14 16:27 ` Srinivas Kandagatla
2026-09-13 20:18 ` [PATCH 3/4] arm64: dts: qcom: Add Lenovo ThinkPad T14s Gen 7 Srinivas Kandagatla
2026-09-13 20:27 ` sashiko-bot
2026-09-14 7:33 ` Abel Vesa
2026-09-14 8:13 ` Konrad Dybcio
2026-09-13 20:18 ` [PATCH 4/4] firmware: qcom: scm: Allow QSEECOM on " Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c09c1f5-cffc-421a-96df-753b294d63cd@oss.qualcomm.com \
--to=srinivas.kandagatla@oss.qualcomm.com \
--cc=abel.vesa@oss.qualcomm.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mpearson-lenovo@squebb.ca \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=sibi.sankar@oss.qualcomm.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.