Re: [PATCH] drivers: iio: light: Fix sparse warnings

[Jonathan Cameron <jic23@kernel.org>]

On 24/09/16 13:12, Sandhya Bankar wrote:
> Fixing below warnings:
> 
> drivers/iio/light/max44000.c:217:18: warning: cast to restricted __be16
> drivers/iio/light/max44000.c:217:18: warning: cast to restricted __be16
> drivers/iio/light/max44000.c:217:18: warning: cast to restricted __be16
> drivers/iio/light/max44000.c:217:18: warning: cast to restricted __be16
> 
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
This is really just papering over the problem.
A better solution would be to introduce a __be16 local variable to do
the initial read into.  Then put it in regval via that be16_to_cpu
call.

Jonathan
> ---
>  drivers/iio/light/max44000.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/max44000.c b/drivers/iio/light/max44000.c
> index 6511b20..1ea9af9 100644
> --- a/drivers/iio/light/max44000.c
> +++ b/drivers/iio/light/max44000.c
> @@ -214,7 +214,7 @@ static int max44000_read_alsval(struct max44000_data *data)
>  	if (ret < 0)
>  		return ret;
>  
> -	regval = be16_to_cpu(regval);
> +	be16_to_cpus(&regval);
>  
>  	/*
>  	 * Overflow is explained on datasheet page 17.
>