From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B26A8C4363A for ; Wed, 28 Oct 2020 20:24:47 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id DFF52247FE for ; Wed, 28 Oct 2020 20:24:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="iYmrlKDD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFF52247FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 07EB84B35C; Wed, 28 Oct 2020 16:24:46 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OY8tyC-7xQEL; Wed, 28 Oct 2020 16:24:43 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8A8EB4B353; Wed, 28 Oct 2020 16:24:43 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id EC49B4B353 for ; Wed, 28 Oct 2020 16:24:41 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZRJcUVBaDw+f for ; Wed, 28 Oct 2020 16:24:41 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 05A0B4B2A6 for ; Wed, 28 Oct 2020 16:24:40 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ABCE0247F8; Wed, 28 Oct 2020 20:24:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603916679; bh=UUOsZKN7KXk7cHfjExBsUtQIG2TwB07hlMnxPr/cS6I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iYmrlKDDxKu96zmq+Rr+6UMBZ4Z5Qf4kxsu4mfrhQOlKqhCTZLeY/QIppwXC310IC zIrHp6hEXp1SRINeXQBLbVRaVAB+iTWzMCtjNQgwowYXu9lLAGxRgjF7fRELzlrbdy U/ttQAO/n2NdjR44LppRDupZeVqfu1gRV4vRkdqQ= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kXrzp-0059jz-LS; Wed, 28 Oct 2020 20:24:37 +0000 MIME-Version: 1.0 Date: Wed, 28 Oct 2020 20:24:37 +0000 From: Marc Zyngier To: James Morse Subject: Re: [PATCH 08/11] KVM: arm64: Inject AArch32 exceptions from HYP In-Reply-To: <3691596f-fb42-a6e0-8aca-5a1605219c23@arm.com> References: <20201026133450.73304-1-maz@kernel.org> <20201026133450.73304-9-maz@kernel.org> <6b30a9c9d082aeabc6cb81aca97b5398@kernel.org> <3691596f-fb42-a6e0-8aca-5a1605219c23@arm.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <9c130c8e438f59ecd0072feea9addbcc@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: james.morse@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, ascull@google.com, will@kernel.org, qperret@google.com, dbrazdil@google.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kernel-team@android.com, Will Deacon , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gMjAyMC0xMC0yOCAxOToyMCwgSmFtZXMgTW9yc2Ugd3JvdGU6Cj4gSGkgTWFyYywKPiAKPiBP biAyNy8xMC8yMDIwIDE5OjIxLCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4+Pj4gK3N0YXRpYyBpbmxp bmUgdTMyIF9fdmNwdV9yZWFkX2NwMTUoY29uc3Qgc3RydWN0IGt2bV92Y3B1ICp2Y3B1LCBpbnQg Cj4+Pj4gcmVnKQo+Pj4+ICt7Cj4+Pj4gK8KgwqDCoCByZXR1cm4gX192Y3B1X3JlYWRfc3lzX3Jl Zyh2Y3B1LCByZWcgLyAyKTsKPj4+PiArfQo+IAo+Pj4gRG9lc24ndCB0aGlzIHJlLWltcGxlbWVu dCB0aGUgaXNzdWUgMzIwNGJlNDEwOWFkIGJpYXNlZD8KPiAKPj4gSSBkb24ndCB0aGluayBpdCBk b2VzLiBUaGUgaXNzdWUgZXhpc3RlZCB3aGVuIGFjY2Vzc2luZyB0aGUgMzJiaXQgCj4+IHNoYWRv dywKPj4gYW5kIHdlIGhhZCB0byBwaWNrIHdoaWNoIHNpZGUgb2YgdGhlIDY0Yml0IHJlZ2lzdGVy IGhhZCBvdXIgMzJiaXQgCj4+IHZhbHVlLgo+PiBIZXJlLCB3ZSBkaXJlY3RseSBhY2Nlc3MgdGhl IDY0Yml0IGZpbGUsIHdoaWNoIGlzIHNhZmUuCj4gCj4gQmVjYXVzZSBpdHMgbm90IGFjY2Vzc2lu ZyB0aGUgY29wcm8gdW5pb24sIGFuZCB0aGUgdHdvIHVzZXJzIGFyZSBib3RoCj4gc3RyYWlnaHQg Zm9yd2FyZCBhbGlhc2VzLgo+IAo+IC4uLgo+IAo+IFdoYXQgZG8gSSBnZXQgaWYgSSBjYWxsOgo+ IHwgX192Y3B1X3JlYWRfY3AxNSh2Y3B1LCBjNl9JRkFSKTsKPiAKPiBXb24ndCB0aGlzIHJldHVy biB0aGUgdmFsdWUgb2YgYzZfREZBUiBpbnN0ZWFkIGFzIHRoZXkgbGl2ZSBpbiB0aGUKPiBzYW1l IDY0IGJpdCByZWdpc3Rlci4KClllcywgdGhhdCB3b3VsZCBicmVhay4gTm90IGluIHRoaXMgYml0 IG9mIGNvZGUgdGhvdWdoLgoKPiAKPiAKPj4gQnV0IHRoaW5raW5nIG9mIGl0LCB3ZSBtYXkgYXMg d2VsbCBjaGFuZ2UgdGhlIGNhbGwgc2l0ZXMgdG8gZGlyZWN0bHkKPj4gdXNlIHRoZSA2NGJpdCBl bnVtLCByYXRoZXIgdGhhbiBwbGF5aW5nIGdhbWVzCj4gCj4gR3JlYXQhCgpZZWFoLCBhbmQgdGhl cmUgaXMgYSBidW5jaCBvZiAuLi4gY3JhcCBhcm91bmQgdGhpcyBhbGlhc2luZy4KVW5mb3J0dW5h dGVseSwgSSBqdXN0IG5vdGljZWQgdGhhdCAzMmJpdCBndWVzdHMgYXJlIGJvcmtlZCBpbiAtcmMx LgpEZWJ1ZyB0aW1lLgoKICAgICAgICAgTS4KLS0gCkphenogaXMgbm90IGRlYWQuIEl0IGp1c3Qg c21lbGxzIGZ1bm55Li4uCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmt2bWFybSBtYWlsaW5nIGxpc3QKa3ZtYXJtQGxpc3RzLmNzLmNvbHVtYmlhLmVkdQpo dHRwczovL2xpc3RzLmNzLmNvbHVtYmlhLmVkdS9tYWlsbWFuL2xpc3RpbmZvL2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFB10C4363A for ; Wed, 28 Oct 2020 20:26:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44CAD247FE for ; Wed, 28 Oct 2020 20:26:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="i7h11zOe"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="iYmrlKDD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44CAD247FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FM2MmM1cOTguzznNHP5MRtktRHS1ZeJJSEMIIZhPjhE=; b=i7h11zOekfX2o0ITCXf7Mzm7k WKFPJNBhxbDbgkdTixQm3GEX1wOfIgWF9Fv1tMKsyCIo8Jsc+TqAhBD30MA2PmJa0l4omTp+jPWyP VEw0kdoGMcqJ1yB5EwjZHWn9Xfshci1Bk7bRTEQ7TXjlkG9tLrGaYhu7EQ9GOXb0ZB97Ub93DLxYp m344RVe3vvnEFmgtfzhVWsZY4HT3LZ9X4tZWt6HNGxTEwDCS79A7aLu5W3pghkKi3AGOxVt4QU3wQ jO6bqrXj2ZwlRc/gv+rwkUcvVssZ2Fgo2kLq9Sku013bcnLfEit+t7ge5L/tibJcwQUbxj8Z/PP9r EerdaOmXg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXrzy-0004wQ-1K; Wed, 28 Oct 2020 20:24:46 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXrzu-0004vr-FP for linux-arm-kernel@lists.infradead.org; Wed, 28 Oct 2020 20:24:43 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ABCE0247F8; Wed, 28 Oct 2020 20:24:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603916679; bh=UUOsZKN7KXk7cHfjExBsUtQIG2TwB07hlMnxPr/cS6I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iYmrlKDDxKu96zmq+Rr+6UMBZ4Z5Qf4kxsu4mfrhQOlKqhCTZLeY/QIppwXC310IC zIrHp6hEXp1SRINeXQBLbVRaVAB+iTWzMCtjNQgwowYXu9lLAGxRgjF7fRELzlrbdy U/ttQAO/n2NdjR44LppRDupZeVqfu1gRV4vRkdqQ= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kXrzp-0059jz-LS; Wed, 28 Oct 2020 20:24:37 +0000 MIME-Version: 1.0 Date: Wed, 28 Oct 2020 20:24:37 +0000 From: Marc Zyngier To: James Morse Subject: Re: [PATCH 08/11] KVM: arm64: Inject AArch32 exceptions from HYP In-Reply-To: <3691596f-fb42-a6e0-8aca-5a1605219c23@arm.com> References: <20201026133450.73304-1-maz@kernel.org> <20201026133450.73304-9-maz@kernel.org> <6b30a9c9d082aeabc6cb81aca97b5398@kernel.org> <3691596f-fb42-a6e0-8aca-5a1605219c23@arm.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <9c130c8e438f59ecd0072feea9addbcc@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: james.morse@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, ascull@google.com, will@kernel.org, qperret@google.com, dbrazdil@google.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201028_162442_656126_6D4E1390 X-CRM114-Status: GOOD ( 17.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, Suzuki K Poulose , kernel-team@android.com, Quentin Perret , Andrew Scull , David Brazdil , Will Deacon , kvmarm@lists.cs.columbia.edu, Julien Thierry Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMC0xMC0yOCAxOToyMCwgSmFtZXMgTW9yc2Ugd3JvdGU6Cj4gSGkgTWFyYywKPiAKPiBP biAyNy8xMC8yMDIwIDE5OjIxLCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4+Pj4gK3N0YXRpYyBpbmxp bmUgdTMyIF9fdmNwdV9yZWFkX2NwMTUoY29uc3Qgc3RydWN0IGt2bV92Y3B1ICp2Y3B1LCBpbnQg Cj4+Pj4gcmVnKQo+Pj4+ICt7Cj4+Pj4gK8KgwqDCoCByZXR1cm4gX192Y3B1X3JlYWRfc3lzX3Jl Zyh2Y3B1LCByZWcgLyAyKTsKPj4+PiArfQo+IAo+Pj4gRG9lc24ndCB0aGlzIHJlLWltcGxlbWVu dCB0aGUgaXNzdWUgMzIwNGJlNDEwOWFkIGJpYXNlZD8KPiAKPj4gSSBkb24ndCB0aGluayBpdCBk b2VzLiBUaGUgaXNzdWUgZXhpc3RlZCB3aGVuIGFjY2Vzc2luZyB0aGUgMzJiaXQgCj4+IHNoYWRv dywKPj4gYW5kIHdlIGhhZCB0byBwaWNrIHdoaWNoIHNpZGUgb2YgdGhlIDY0Yml0IHJlZ2lzdGVy IGhhZCBvdXIgMzJiaXQgCj4+IHZhbHVlLgo+PiBIZXJlLCB3ZSBkaXJlY3RseSBhY2Nlc3MgdGhl IDY0Yml0IGZpbGUsIHdoaWNoIGlzIHNhZmUuCj4gCj4gQmVjYXVzZSBpdHMgbm90IGFjY2Vzc2lu ZyB0aGUgY29wcm8gdW5pb24sIGFuZCB0aGUgdHdvIHVzZXJzIGFyZSBib3RoCj4gc3RyYWlnaHQg Zm9yd2FyZCBhbGlhc2VzLgo+IAo+IC4uLgo+IAo+IFdoYXQgZG8gSSBnZXQgaWYgSSBjYWxsOgo+ IHwgX192Y3B1X3JlYWRfY3AxNSh2Y3B1LCBjNl9JRkFSKTsKPiAKPiBXb24ndCB0aGlzIHJldHVy biB0aGUgdmFsdWUgb2YgYzZfREZBUiBpbnN0ZWFkIGFzIHRoZXkgbGl2ZSBpbiB0aGUKPiBzYW1l IDY0IGJpdCByZWdpc3Rlci4KClllcywgdGhhdCB3b3VsZCBicmVhay4gTm90IGluIHRoaXMgYml0 IG9mIGNvZGUgdGhvdWdoLgoKPiAKPiAKPj4gQnV0IHRoaW5raW5nIG9mIGl0LCB3ZSBtYXkgYXMg d2VsbCBjaGFuZ2UgdGhlIGNhbGwgc2l0ZXMgdG8gZGlyZWN0bHkKPj4gdXNlIHRoZSA2NGJpdCBl bnVtLCByYXRoZXIgdGhhbiBwbGF5aW5nIGdhbWVzCj4gCj4gR3JlYXQhCgpZZWFoLCBhbmQgdGhl cmUgaXMgYSBidW5jaCBvZiAuLi4gY3JhcCBhcm91bmQgdGhpcyBhbGlhc2luZy4KVW5mb3J0dW5h dGVseSwgSSBqdXN0IG5vdGljZWQgdGhhdCAzMmJpdCBndWVzdHMgYXJlIGJvcmtlZCBpbiAtcmMx LgpEZWJ1ZyB0aW1lLgoKICAgICAgICAgTS4KLS0gCkphenogaXMgbm90IGRlYWQuIEl0IGp1c3Qg c21lbGxzIGZ1bm55Li4uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BCD4C4363A for ; Wed, 28 Oct 2020 21:48:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D046A2064C for ; Wed, 28 Oct 2020 21:48:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603921726; bh=UUOsZKN7KXk7cHfjExBsUtQIG2TwB07hlMnxPr/cS6I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=WDAs3JN6LX+16tXYnIfklpmXbdFBL4/pEjjT4K/GXwsY/8hahUS9sZHcgo1+uCPwM zKcr8WHFrtfTMMgSr2N160DAgXWc6BbbSPUb9uXtEsPwYJHQArcfhuJWJI/6cVON7Z wkHNxzpZw3/Nozv9PQ0cJHKQRs302WIy7z0susxg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726200AbgJ1Vso (ORCPT ); Wed, 28 Oct 2020 17:48:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:38176 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726133AbgJ1VmZ (ORCPT ); Wed, 28 Oct 2020 17:42:25 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ABCE0247F8; Wed, 28 Oct 2020 20:24:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603916679; bh=UUOsZKN7KXk7cHfjExBsUtQIG2TwB07hlMnxPr/cS6I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iYmrlKDDxKu96zmq+Rr+6UMBZ4Z5Qf4kxsu4mfrhQOlKqhCTZLeY/QIppwXC310IC zIrHp6hEXp1SRINeXQBLbVRaVAB+iTWzMCtjNQgwowYXu9lLAGxRgjF7fRELzlrbdy U/ttQAO/n2NdjR44LppRDupZeVqfu1gRV4vRkdqQ= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kXrzp-0059jz-LS; Wed, 28 Oct 2020 20:24:37 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 28 Oct 2020 20:24:37 +0000 From: Marc Zyngier To: James Morse Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Julien Thierry , Suzuki K Poulose , Andrew Scull , Will Deacon , Quentin Perret , David Brazdil , kernel-team@android.com Subject: Re: [PATCH 08/11] KVM: arm64: Inject AArch32 exceptions from HYP In-Reply-To: <3691596f-fb42-a6e0-8aca-5a1605219c23@arm.com> References: <20201026133450.73304-1-maz@kernel.org> <20201026133450.73304-9-maz@kernel.org> <6b30a9c9d082aeabc6cb81aca97b5398@kernel.org> <3691596f-fb42-a6e0-8aca-5a1605219c23@arm.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <9c130c8e438f59ecd0072feea9addbcc@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: james.morse@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, ascull@google.com, will@kernel.org, qperret@google.com, dbrazdil@google.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2020-10-28 19:20, James Morse wrote: > Hi Marc, > > On 27/10/2020 19:21, Marc Zyngier wrote: >>>> +static inline u32 __vcpu_read_cp15(const struct kvm_vcpu *vcpu, int >>>> reg) >>>> +{ >>>> +    return __vcpu_read_sys_reg(vcpu, reg / 2); >>>> +} > >>> Doesn't this re-implement the issue 3204be4109ad biased? > >> I don't think it does. The issue existed when accessing the 32bit >> shadow, >> and we had to pick which side of the 64bit register had our 32bit >> value. >> Here, we directly access the 64bit file, which is safe. > > Because its not accessing the copro union, and the two users are both > straight forward aliases. > > ... > > What do I get if I call: > | __vcpu_read_cp15(vcpu, c6_IFAR); > > Won't this return the value of c6_DFAR instead as they live in the > same 64 bit register. Yes, that would break. Not in this bit of code though. > > >> But thinking of it, we may as well change the call sites to directly >> use the 64bit enum, rather than playing games > > Great! Yeah, and there is a bunch of ... crap around this aliasing. Unfortunately, I just noticed that 32bit guests are borked in -rc1. Debug time. M. -- Jazz is not dead. It just smells funny...