From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93684C433E0 for ; Tue, 9 Mar 2021 11:42:55 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2784E6525B for ; Tue, 9 Mar 2021 11:42:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2784E6525B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pcrkz29Q3TbyRnEB18jLKiC8f4ODlaQZL0GY3BBLkP0=; b=qGJ0BV6jU/goRWJrGj1V/wSzG V3HFbKHrXUk22G/YaFJv3fC3fPlcI2jJ4b4LIQtk7425nxc6gyBUS4UMJeC6AE+5Ks5UPWX8oKp9B 5dTqkxBnm0klq7mXGXpjyIGQ9FWT2KAeFsoJn8JarALA8i3A2FZp01Kg4RIvkNEpg2Xx8stjQNRX4 MNpizt+c4CnMcmhp7zXVp0o4UC1laL59LmcUhgV+fBbVO4s1TVipKR1e97g+2XpqR3zm8Tma3hvm+ 6WGmN2qfFzn2fpk8yZEnPmITT4gcMfLXJVFQd3eYkAr7ZgjeEYpKvrVVMshoefwVrz9UrZ8mbM5h6 T7tSoPJOg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJalE-004M7E-84; Tue, 09 Mar 2021 11:42:48 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJalA-004M5v-NG; Tue, 09 Mar 2021 11:42:46 +0000 Received: by mail-ed1-x531.google.com with SMTP id t1so19419131eds.7; Tue, 09 Mar 2021 03:42:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=A6bIv+p3szTuEIXXM2XphhkvFikVXUeMFjbmhdY08N8=; b=seKe5sEbHQa2kiM0aglI977bXPLc7n2L9EqPWPTJOMEnPVhhuyIHSFyPYkIdVfACDn x3mN+QytQkoPj5UiQVGQ2pRd6re8ZDWsyMZDWmEJjYZZbDdm9r/SiArFBrwMrtDPiZ9C NzLI/p4c856hviBTwjM5QeoxaovTdWN38ihnqEeqvvxo8W3baQdCRWtP4OROgLu4iNlY d5AWq26xMBjIvnfHHDuox2HdbaxCbS4upaUh2jdEhnhGom4IlOuNoBoAMnML8x0Rit6+ tiyQegUOWvCqZ+YHsX/lEcEAKAfym5Tn0hl+EWuqnUB5KqRGcq1K7aHA6ZI7wR0D9rr5 KIPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=A6bIv+p3szTuEIXXM2XphhkvFikVXUeMFjbmhdY08N8=; b=BJ61dbOsIidNnUSAIBnvtGMK7QgMfKNdXluQ1OYVNER9OE+T21QE61WglejQxNTJLv 3lzFxjcms+/0JsGgrZznr1lB4q+YtDNHVVWlYHLFmcXaNjFQkD5kqcDY2jkM6zdpeOYQ pZlnlTUeEf7phzJHZCJ2MlshsLDTstL03L9OFPh0KQH2lZqEeL1qdmFvM6QVIoSCLOG6 VKramGuhhTsRLdy2L7vOQVIhYKimtbp7jfyT74qIXSNbpcQwuDNVzgWl5TwODN0Nso1/ ubvwraK6hWWKWkMNLCe14dNIibbKDnSu86OK8Em16uPTVPdiAmKHLLpE2K/ML4+zaj4W SRMA== X-Gm-Message-State: AOAM530La387gobsGmqHujh2lD8+8KEXnaUfDic8AZNemIzMJ84qGdMo OICyllQ96DY625ZKihLB7Io= X-Google-Smtp-Source: ABdhPJxZEHCNsHJ/oZO4KUI9IfkOvyl87o8wDz3iKGCTcntvjFUWE1J5tlAp4nXyDD67Iv0XoGbqUQ== X-Received: by 2002:a05:6402:12cf:: with SMTP id k15mr3458170edx.192.1615290163721; Tue, 09 Mar 2021 03:42:43 -0800 (PST) Received: from [192.168.2.2] (81-204-249-205.fixed.kpn.net. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id a22sm8397139ejr.89.2021.03.09.03.42.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Mar 2021 03:42:43 -0800 (PST) Subject: Re: [RESEND PATCH v5 2/4] arm64: dts: rk3399: Add dfi and dmc nodes. To: Daniel Lezcano , heiko@sntech.de Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Lin Huang , Enric Balletbo i Serra , =?UTF-8?Q?Ga=c3=abl_PORTAY?= , Rob Herring , Helen Koike , Chen-Yu Tsai , Jacob Chen , Shunqian Zheng , Robin Murphy , Boris Brezillon , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20210308233858.24741-1-daniel.lezcano@linaro.org> <20210308233858.24741-2-daniel.lezcano@linaro.org> From: Johan Jonker Message-ID: <9c36893a-6ca8-dade-e203-890a4071bf50@gmail.com> Date: Tue, 9 Mar 2021 12:42:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20210308233858.24741-2-daniel.lezcano@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210309_114244_985572_E5777421 X-CRM114-Status: GOOD ( 17.92 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgRGFuaWVsLAoKU29tZSBjb21tZW50cy4gSGF2ZSBhIGxvb2sgaWYgaXQncyB1c2VmdWwgb3Ig dGhhdCB5b3UgZGlzYWdyZWUgd2l0aC4KCk5ldyBub2RlcyBzaG91bGQgYmUgdmVyaWZpYWJsZSBp ZiBwb3NzaWJsZS4KRXNwZWNpYWxseSB3aXRoIHNvIG1hbnkgcHJvcGVydGllcy4KQ291bGQgeW91 IGNvbnZlcnQgcm9ja2NoaXAtZGZpLnR4dCBhbmQgcmszMzk5X2RtYy50eHQgdG8geWFtbCBpbnN0 ZWFkIG9mCmNoYW5naW5nIG9sZCB0eHQgZG9jdW1lbnRzPwpBZGQgcm9ja2NoaXAtZGZpLnlhbWwg YW5kIHJrMzM5OV9kbWMueWFtbCBiZWZvcmUgdGhpcyBwYXRjaCBpbiB2ZXJzaW9uIDYuCgpOb2Rl cyBhbmQgcHJvcGVydGllcyBoYXZlIGEgc29ydCBvcmRlci4gUGxlYXNlIGZpeC4KU29tZSBnb2Vz IGZvciBbUkVTRU5EIFBBVENIIHY1IDMvNF0uCgooVGhpcyBpcyBhIGdlbmVyaWMgZHRzaS4gSG93 IGFib3V0IGNvb2xpbmcgYW5kIGRtYyA/PykKCi0tLS0KSGVpa28gcnVsZXM6Cgpjb21wYXRpYmxl CnJlZwppbnRlcnJ1cHRzClthbHBoYWJldGljYWxdCnN0YXR1cyBbaWYgbmVlZGVkXQoKLS0tLQpN eSBpbmNvbXBsZXRlIGxpc3Q6CgpGb3Igbm9kZXM6CklmIGV4aXN0cyBvbiB0b3A6IG1vZGVsLCBj b21wYXRpYmxlIGFuZCBjaG9zZW4uClNvcnQgdGhpbmdzIHdpdGhvdXQgcmVnIGFscGhhYmV0aWNh bCBmaXJzdCwKdGhlbiBzb3J0IHRoZSByZXN0IGJ5IHJlZyBhZGRyZXNzLgoKSW5zaWRlIG5vZGVz OgpJZiBleGlzdHMgb24gdG9wOiBjb21wYXRpYmxlLCByZWcgYW5kIGludGVycnVwdHMuCkluIGFs cGhhYmV0aWNhbCBvcmRlciB0aGUgcmVxdWlyZWQgcHJvcGVydGllcy4KVGhlbiBpbiBhbHBoYWJl dGljYWwgb3JkZXIgdGhlIG90aGVyIHByb3BlcnRpZXMuCkFuZCBhcyBsYXN0IHRoaW5ncyB0aGF0 IHN0YXJ0IHdpdGggJyMnIGluIGFscGhhYmV0aWNhbCBvcmRlci4KQWRkIHN0YXR1cyBiZWxvdyBh bGwgb3RoZXIgcHJvcGVydGllcyBmb3Igc29jIGludGVybmFsIGNvbXBvbmVudHMgd2l0aAphbnkg Ym9hcmQtc3BlY2lmaWNzLgpLZWVwIGFuIGVtcHR5IGxpbmUgYmV0d2VlbiBwcm9wZXJ0aWVzIGFu ZCBub2Rlcy4KCkV4Y2VwdGlvbnM6ClNvcnQgcGluY3RybC0wIGFib3ZlIHBpbmN0cmwtbmFtZXMs IHNvIGl0IHN0YXlzIGluIGxpbmUgd2l0aCBjbG9jay1uYW1lcwphbmQgZG1hLW5hbWVzLgpTb3J0 IHNpbXBsZS1hdWRpby1jYXJkLG5hbWUgYWJvdmUgb3RoZXIgc2ltcGxlLWF1ZGlvLWNhcmQgcHJv cGVydGllcy4KU29ydCByZWd1bGF0b3ItbmFtZSBhYm92ZSBvdGhlciByZWd1bGF0b3IgcHJvcGVy dGllcy4KU29ydCByZWd1bGF0b3ItbWluLW1pY3Jvdm9sdCBhYm92ZSByZWd1bGF0b3ItbWF4LW1p Y3Jvdm9sdC4KCk9uIDMvOS8yMSAxMjozOCBBTSwgRGFuaWVsIExlemNhbm8gd3JvdGU6Cj4gRnJv bTogTGluIEh1YW5nIDxobEByb2NrLWNoaXBzLmNvbT4KPiAKPiBUaGVzZSBhcmUgcmVxdWlyZWQg dG8gc3VwcG9ydCBERFIgRFZGUyBvbiByazMzOTkgcGxhdGZvcm0uCj4gCj4gU2lnbmVkLW9mZi1i eTogTGluIEh1YW5nIDxobEByb2NrLWNoaXBzLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBFbnJpYyBC YWxsZXRibyBpIFNlcnJhIDxlbnJpYy5iYWxsZXRib0Bjb2xsYWJvcmEuY29tPgo+IFNpZ25lZC1v ZmYtYnk6IEdhw6tsIFBPUlRBWSA8Z2FlbC5wb3J0YXlAY29sbGFib3JhLmNvbT4KPiBTaWduZWQt b2ZmLWJ5OiBEYW5pZWwgTGV6Y2FubyA8ZGFuaWVsLmxlemNhbm9AbGluYXJvLm9yZz4KPiAtLS0K PiAgYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazMzOTkuZHRzaSB8IDE5ICsrKysrKysr KysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKykKPiAKPiBkaWZm IC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazMzOTkuZHRzaSBiL2FyY2gv YXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszMzk5LmR0c2kKPiBpbmRleCBlZGJiZjM1ZmUxOWUu LjZmMjNkOTkyMzZmZSAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlw L3JrMzM5OS5kdHNpCj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazMzOTku ZHRzaQo+IEBAIC0xOTM3LDYgKzE5MzcsMjUgQEAKPiAgCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwo+ ICAJfTsKPiAgCj4gKwlkZmk6IGRmaUBmZjYzMDAwMCB7Cj4gKwkJcmVnID0gPDB4MDAgMHhmZjYz MDAwMCAweDAwIDB4NDAwMD47Cj4gKwkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktZGZp IjsKPiArCQlyb2NrY2hpcCxwbXUgPSA8JnBtdWdyZj47Cj4gKwkJaW50ZXJydXB0cyA9IDxHSUNf U1BJIDEzMSBJUlFfVFlQRV9MRVZFTF9ISUdIIDA+Owo+ICsJCWNsb2NrcyA9IDwmY3J1IFBDTEtf RERSX01PTj47Cj4gKwkJY2xvY2stbmFtZXMgPSAicGNsa19kZHJfbW9uIjsKPiArCQlzdGF0dXMg PSAiZGlzYWJsZWQiOwo+ICsJfTsKPiArCj4gKwlkbWM6IGRtYyB7Cj4gKwkJY29tcGF0aWJsZSA9 ICJyb2NrY2hpcCxyazMzOTktZG1jIjsKPiArCQlyb2NrY2hpcCxwbXUgPSA8JnBtdWdyZj47Cj4g KwkJZGV2ZnJlcS1ldmVudHMgPSA8JmRmaT47Cj4gKwkJY2xvY2tzID0gPCZjcnUgU0NMS19ERFJD PjsKPiArCQljbG9jay1uYW1lcyA9ICJkbWNfY2xrIjsKPiArCQlzdGF0dXMgPSAiZGlzYWJsZWQi Owo+ICsJfTsKPiArCj4gIAlwaW5jdHJsOiBwaW5jdHJsIHsKPiAgCQljb21wYXRpYmxlID0gInJv Y2tjaGlwLHJrMzM5OS1waW5jdHJsIjsKPiAgCQlyb2NrY2hpcCxncmYgPSA8JmdyZj47Cj4gCgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9j a2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 400E2C433DB for ; Tue, 9 Mar 2021 11:44:48 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B56736523C for ; Tue, 9 Mar 2021 11:44:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B56736523C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rOoYX2VBaPqYrf7kirbXoDfKHBHf6neatz+l94rz40o=; b=E2Pb7pxFAm4t+tXtUxELWazAu NrSMp6cSrE9pwF9Uc7rkzP3+ZkL+L48qstPknwCkwnSUXMb+LB6PTEzq5lDizWvU6Ks+PvIArKLeZ etzifdvjKZeAUos9L2A0k//Aw4+oI5xFBpWimVohKPzyXqsIA3a5EwZkBP3b/DGJiJWmN68xnDBP4 TposWE0TzcRe8GgUEjgGKoqs00oxvs6ABG7dzpGZa8zcYTspx4w//+L0cRoLxLRb00NzyEWmWahH/ hbCz1yrdWr9kvPENHclUQsmyhHO4TSTW01BPEHlbtXq7/1mpUy8IBvNKs/1x5skVIG05wMT/cevEy D1xCGGchg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJalJ-004M87-Pq; Tue, 09 Mar 2021 11:42:54 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJalA-004M5v-NG; Tue, 09 Mar 2021 11:42:46 +0000 Received: by mail-ed1-x531.google.com with SMTP id t1so19419131eds.7; Tue, 09 Mar 2021 03:42:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=A6bIv+p3szTuEIXXM2XphhkvFikVXUeMFjbmhdY08N8=; b=seKe5sEbHQa2kiM0aglI977bXPLc7n2L9EqPWPTJOMEnPVhhuyIHSFyPYkIdVfACDn x3mN+QytQkoPj5UiQVGQ2pRd6re8ZDWsyMZDWmEJjYZZbDdm9r/SiArFBrwMrtDPiZ9C NzLI/p4c856hviBTwjM5QeoxaovTdWN38ihnqEeqvvxo8W3baQdCRWtP4OROgLu4iNlY d5AWq26xMBjIvnfHHDuox2HdbaxCbS4upaUh2jdEhnhGom4IlOuNoBoAMnML8x0Rit6+ tiyQegUOWvCqZ+YHsX/lEcEAKAfym5Tn0hl+EWuqnUB5KqRGcq1K7aHA6ZI7wR0D9rr5 KIPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=A6bIv+p3szTuEIXXM2XphhkvFikVXUeMFjbmhdY08N8=; b=BJ61dbOsIidNnUSAIBnvtGMK7QgMfKNdXluQ1OYVNER9OE+T21QE61WglejQxNTJLv 3lzFxjcms+/0JsGgrZznr1lB4q+YtDNHVVWlYHLFmcXaNjFQkD5kqcDY2jkM6zdpeOYQ pZlnlTUeEf7phzJHZCJ2MlshsLDTstL03L9OFPh0KQH2lZqEeL1qdmFvM6QVIoSCLOG6 VKramGuhhTsRLdy2L7vOQVIhYKimtbp7jfyT74qIXSNbpcQwuDNVzgWl5TwODN0Nso1/ ubvwraK6hWWKWkMNLCe14dNIibbKDnSu86OK8Em16uPTVPdiAmKHLLpE2K/ML4+zaj4W SRMA== X-Gm-Message-State: AOAM530La387gobsGmqHujh2lD8+8KEXnaUfDic8AZNemIzMJ84qGdMo OICyllQ96DY625ZKihLB7Io= X-Google-Smtp-Source: ABdhPJxZEHCNsHJ/oZO4KUI9IfkOvyl87o8wDz3iKGCTcntvjFUWE1J5tlAp4nXyDD67Iv0XoGbqUQ== X-Received: by 2002:a05:6402:12cf:: with SMTP id k15mr3458170edx.192.1615290163721; Tue, 09 Mar 2021 03:42:43 -0800 (PST) Received: from [192.168.2.2] (81-204-249-205.fixed.kpn.net. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id a22sm8397139ejr.89.2021.03.09.03.42.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Mar 2021 03:42:43 -0800 (PST) Subject: Re: [RESEND PATCH v5 2/4] arm64: dts: rk3399: Add dfi and dmc nodes. To: Daniel Lezcano , heiko@sntech.de Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Lin Huang , Enric Balletbo i Serra , =?UTF-8?Q?Ga=c3=abl_PORTAY?= , Rob Herring , Helen Koike , Chen-Yu Tsai , Jacob Chen , Shunqian Zheng , Robin Murphy , Boris Brezillon , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20210308233858.24741-1-daniel.lezcano@linaro.org> <20210308233858.24741-2-daniel.lezcano@linaro.org> From: Johan Jonker Message-ID: <9c36893a-6ca8-dade-e203-890a4071bf50@gmail.com> Date: Tue, 9 Mar 2021 12:42:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20210308233858.24741-2-daniel.lezcano@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210309_114244_985572_E5777421 X-CRM114-Status: GOOD ( 17.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgRGFuaWVsLAoKU29tZSBjb21tZW50cy4gSGF2ZSBhIGxvb2sgaWYgaXQncyB1c2VmdWwgb3Ig dGhhdCB5b3UgZGlzYWdyZWUgd2l0aC4KCk5ldyBub2RlcyBzaG91bGQgYmUgdmVyaWZpYWJsZSBp ZiBwb3NzaWJsZS4KRXNwZWNpYWxseSB3aXRoIHNvIG1hbnkgcHJvcGVydGllcy4KQ291bGQgeW91 IGNvbnZlcnQgcm9ja2NoaXAtZGZpLnR4dCBhbmQgcmszMzk5X2RtYy50eHQgdG8geWFtbCBpbnN0 ZWFkIG9mCmNoYW5naW5nIG9sZCB0eHQgZG9jdW1lbnRzPwpBZGQgcm9ja2NoaXAtZGZpLnlhbWwg YW5kIHJrMzM5OV9kbWMueWFtbCBiZWZvcmUgdGhpcyBwYXRjaCBpbiB2ZXJzaW9uIDYuCgpOb2Rl cyBhbmQgcHJvcGVydGllcyBoYXZlIGEgc29ydCBvcmRlci4gUGxlYXNlIGZpeC4KU29tZSBnb2Vz IGZvciBbUkVTRU5EIFBBVENIIHY1IDMvNF0uCgooVGhpcyBpcyBhIGdlbmVyaWMgZHRzaS4gSG93 IGFib3V0IGNvb2xpbmcgYW5kIGRtYyA/PykKCi0tLS0KSGVpa28gcnVsZXM6Cgpjb21wYXRpYmxl CnJlZwppbnRlcnJ1cHRzClthbHBoYWJldGljYWxdCnN0YXR1cyBbaWYgbmVlZGVkXQoKLS0tLQpN eSBpbmNvbXBsZXRlIGxpc3Q6CgpGb3Igbm9kZXM6CklmIGV4aXN0cyBvbiB0b3A6IG1vZGVsLCBj b21wYXRpYmxlIGFuZCBjaG9zZW4uClNvcnQgdGhpbmdzIHdpdGhvdXQgcmVnIGFscGhhYmV0aWNh bCBmaXJzdCwKdGhlbiBzb3J0IHRoZSByZXN0IGJ5IHJlZyBhZGRyZXNzLgoKSW5zaWRlIG5vZGVz OgpJZiBleGlzdHMgb24gdG9wOiBjb21wYXRpYmxlLCByZWcgYW5kIGludGVycnVwdHMuCkluIGFs cGhhYmV0aWNhbCBvcmRlciB0aGUgcmVxdWlyZWQgcHJvcGVydGllcy4KVGhlbiBpbiBhbHBoYWJl dGljYWwgb3JkZXIgdGhlIG90aGVyIHByb3BlcnRpZXMuCkFuZCBhcyBsYXN0IHRoaW5ncyB0aGF0 IHN0YXJ0IHdpdGggJyMnIGluIGFscGhhYmV0aWNhbCBvcmRlci4KQWRkIHN0YXR1cyBiZWxvdyBh bGwgb3RoZXIgcHJvcGVydGllcyBmb3Igc29jIGludGVybmFsIGNvbXBvbmVudHMgd2l0aAphbnkg Ym9hcmQtc3BlY2lmaWNzLgpLZWVwIGFuIGVtcHR5IGxpbmUgYmV0d2VlbiBwcm9wZXJ0aWVzIGFu ZCBub2Rlcy4KCkV4Y2VwdGlvbnM6ClNvcnQgcGluY3RybC0wIGFib3ZlIHBpbmN0cmwtbmFtZXMs IHNvIGl0IHN0YXlzIGluIGxpbmUgd2l0aCBjbG9jay1uYW1lcwphbmQgZG1hLW5hbWVzLgpTb3J0 IHNpbXBsZS1hdWRpby1jYXJkLG5hbWUgYWJvdmUgb3RoZXIgc2ltcGxlLWF1ZGlvLWNhcmQgcHJv cGVydGllcy4KU29ydCByZWd1bGF0b3ItbmFtZSBhYm92ZSBvdGhlciByZWd1bGF0b3IgcHJvcGVy dGllcy4KU29ydCByZWd1bGF0b3ItbWluLW1pY3Jvdm9sdCBhYm92ZSByZWd1bGF0b3ItbWF4LW1p Y3Jvdm9sdC4KCk9uIDMvOS8yMSAxMjozOCBBTSwgRGFuaWVsIExlemNhbm8gd3JvdGU6Cj4gRnJv bTogTGluIEh1YW5nIDxobEByb2NrLWNoaXBzLmNvbT4KPiAKPiBUaGVzZSBhcmUgcmVxdWlyZWQg dG8gc3VwcG9ydCBERFIgRFZGUyBvbiByazMzOTkgcGxhdGZvcm0uCj4gCj4gU2lnbmVkLW9mZi1i eTogTGluIEh1YW5nIDxobEByb2NrLWNoaXBzLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBFbnJpYyBC YWxsZXRibyBpIFNlcnJhIDxlbnJpYy5iYWxsZXRib0Bjb2xsYWJvcmEuY29tPgo+IFNpZ25lZC1v ZmYtYnk6IEdhw6tsIFBPUlRBWSA8Z2FlbC5wb3J0YXlAY29sbGFib3JhLmNvbT4KPiBTaWduZWQt b2ZmLWJ5OiBEYW5pZWwgTGV6Y2FubyA8ZGFuaWVsLmxlemNhbm9AbGluYXJvLm9yZz4KPiAtLS0K PiAgYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazMzOTkuZHRzaSB8IDE5ICsrKysrKysr KysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKykKPiAKPiBkaWZm IC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazMzOTkuZHRzaSBiL2FyY2gv YXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszMzk5LmR0c2kKPiBpbmRleCBlZGJiZjM1ZmUxOWUu LjZmMjNkOTkyMzZmZSAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlw L3JrMzM5OS5kdHNpCj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazMzOTku ZHRzaQo+IEBAIC0xOTM3LDYgKzE5MzcsMjUgQEAKPiAgCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwo+ ICAJfTsKPiAgCj4gKwlkZmk6IGRmaUBmZjYzMDAwMCB7Cj4gKwkJcmVnID0gPDB4MDAgMHhmZjYz MDAwMCAweDAwIDB4NDAwMD47Cj4gKwkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktZGZp IjsKPiArCQlyb2NrY2hpcCxwbXUgPSA8JnBtdWdyZj47Cj4gKwkJaW50ZXJydXB0cyA9IDxHSUNf U1BJIDEzMSBJUlFfVFlQRV9MRVZFTF9ISUdIIDA+Owo+ICsJCWNsb2NrcyA9IDwmY3J1IFBDTEtf RERSX01PTj47Cj4gKwkJY2xvY2stbmFtZXMgPSAicGNsa19kZHJfbW9uIjsKPiArCQlzdGF0dXMg PSAiZGlzYWJsZWQiOwo+ICsJfTsKPiArCj4gKwlkbWM6IGRtYyB7Cj4gKwkJY29tcGF0aWJsZSA9 ICJyb2NrY2hpcCxyazMzOTktZG1jIjsKPiArCQlyb2NrY2hpcCxwbXUgPSA8JnBtdWdyZj47Cj4g KwkJZGV2ZnJlcS1ldmVudHMgPSA8JmRmaT47Cj4gKwkJY2xvY2tzID0gPCZjcnUgU0NMS19ERFJD PjsKPiArCQljbG9jay1uYW1lcyA9ICJkbWNfY2xrIjsKPiArCQlzdGF0dXMgPSAiZGlzYWJsZWQi Owo+ICsJfTsKPiArCj4gIAlwaW5jdHJsOiBwaW5jdHJsIHsKPiAgCQljb21wYXRpYmxlID0gInJv Y2tjaGlwLHJrMzM5OS1waW5jdHJsIjsKPiAgCQlyb2NrY2hpcCxncmYgPSA8JmdyZj47Cj4gCgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8CF4C433E0 for ; Tue, 9 Mar 2021 11:43:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75F586525B for ; Tue, 9 Mar 2021 11:43:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229553AbhCILm5 (ORCPT ); Tue, 9 Mar 2021 06:42:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230183AbhCILmp (ORCPT ); Tue, 9 Mar 2021 06:42:45 -0500 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3AB6C06174A; Tue, 9 Mar 2021 03:42:44 -0800 (PST) Received: by mail-ed1-x536.google.com with SMTP id p1so19428211edy.2; Tue, 09 Mar 2021 03:42:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=A6bIv+p3szTuEIXXM2XphhkvFikVXUeMFjbmhdY08N8=; b=seKe5sEbHQa2kiM0aglI977bXPLc7n2L9EqPWPTJOMEnPVhhuyIHSFyPYkIdVfACDn x3mN+QytQkoPj5UiQVGQ2pRd6re8ZDWsyMZDWmEJjYZZbDdm9r/SiArFBrwMrtDPiZ9C NzLI/p4c856hviBTwjM5QeoxaovTdWN38ihnqEeqvvxo8W3baQdCRWtP4OROgLu4iNlY d5AWq26xMBjIvnfHHDuox2HdbaxCbS4upaUh2jdEhnhGom4IlOuNoBoAMnML8x0Rit6+ tiyQegUOWvCqZ+YHsX/lEcEAKAfym5Tn0hl+EWuqnUB5KqRGcq1K7aHA6ZI7wR0D9rr5 KIPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=A6bIv+p3szTuEIXXM2XphhkvFikVXUeMFjbmhdY08N8=; b=UZpJ6XSiGRpaOYqelqyADU6QdL9II1S0Hm/tv6VzeeH8TMHxn5M5GqSacBu7kmVv8p +1oZYWXzZ567sBo5evgqfp6TAqt1FEWDhZvF0utyZsd4Qmzy6NYpbBlUnxBbRMahi1HB pWEWHDwuVLp9omzKtMyrJ8kqn+ceUMsC5d9dFMQBErMXUT49t/zh1XliUt/D6TDww7KO y25nOCo45tE3yldU++QyO/7wVJaDFX6ZxEGeNz3x+cppDETS04tg6u/iiiH9dvPWXZG0 RzvxpFqX18hKQPY0KwyXEJC6pv0cnQ8Qu+fBueh6dCyfW5Dj1oVqTlb+Fio2IsHWhkGY SqlA== X-Gm-Message-State: AOAM530bBvnrDs92V1kldsAuHn4ePfa0yUOdSTWY0sxBIKBhNmALccqY Txee97RzS5d2vIITBOmvX0lGmullvzLh5Q== X-Google-Smtp-Source: ABdhPJxZEHCNsHJ/oZO4KUI9IfkOvyl87o8wDz3iKGCTcntvjFUWE1J5tlAp4nXyDD67Iv0XoGbqUQ== X-Received: by 2002:a05:6402:12cf:: with SMTP id k15mr3458170edx.192.1615290163721; Tue, 09 Mar 2021 03:42:43 -0800 (PST) Received: from [192.168.2.2] (81-204-249-205.fixed.kpn.net. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id a22sm8397139ejr.89.2021.03.09.03.42.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Mar 2021 03:42:43 -0800 (PST) Subject: Re: [RESEND PATCH v5 2/4] arm64: dts: rk3399: Add dfi and dmc nodes. To: Daniel Lezcano , heiko@sntech.de Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Lin Huang , Enric Balletbo i Serra , =?UTF-8?Q?Ga=c3=abl_PORTAY?= , Rob Herring , Helen Koike , Chen-Yu Tsai , Jacob Chen , Shunqian Zheng , Robin Murphy , Boris Brezillon , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20210308233858.24741-1-daniel.lezcano@linaro.org> <20210308233858.24741-2-daniel.lezcano@linaro.org> From: Johan Jonker Message-ID: <9c36893a-6ca8-dade-e203-890a4071bf50@gmail.com> Date: Tue, 9 Mar 2021 12:42:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20210308233858.24741-2-daniel.lezcano@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Daniel, Some comments. Have a look if it's useful or that you disagree with. New nodes should be verifiable if possible. Especially with so many properties. Could you convert rockchip-dfi.txt and rk3399_dmc.txt to yaml instead of changing old txt documents? Add rockchip-dfi.yaml and rk3399_dmc.yaml before this patch in version 6. Nodes and properties have a sort order. Please fix. Some goes for [RESEND PATCH v5 3/4]. (This is a generic dtsi. How about cooling and dmc ??) ---- Heiko rules: compatible reg interrupts [alphabetical] status [if needed] ---- My incomplete list: For nodes: If exists on top: model, compatible and chosen. Sort things without reg alphabetical first, then sort the rest by reg address. Inside nodes: If exists on top: compatible, reg and interrupts. In alphabetical order the required properties. Then in alphabetical order the other properties. And as last things that start with '#' in alphabetical order. Add status below all other properties for soc internal components with any board-specifics. Keep an empty line between properties and nodes. Exceptions: Sort pinctrl-0 above pinctrl-names, so it stays in line with clock-names and dma-names. Sort simple-audio-card,name above other simple-audio-card properties. Sort regulator-name above other regulator properties. Sort regulator-min-microvolt above regulator-max-microvolt. On 3/9/21 12:38 AM, Daniel Lezcano wrote: > From: Lin Huang > > These are required to support DDR DVFS on rk3399 platform. > > Signed-off-by: Lin Huang > Signed-off-by: Enric Balletbo i Serra > Signed-off-by: Gaël PORTAY > Signed-off-by: Daniel Lezcano > --- > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index edbbf35fe19e..6f23d99236fe 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -1937,6 +1937,25 @@ > status = "disabled"; > }; > > + dfi: dfi@ff630000 { > + reg = <0x00 0xff630000 0x00 0x4000>; > + compatible = "rockchip,rk3399-dfi"; > + rockchip,pmu = <&pmugrf>; > + interrupts = ; > + clocks = <&cru PCLK_DDR_MON>; > + clock-names = "pclk_ddr_mon"; > + status = "disabled"; > + }; > + > + dmc: dmc { > + compatible = "rockchip,rk3399-dmc"; > + rockchip,pmu = <&pmugrf>; > + devfreq-events = <&dfi>; > + clocks = <&cru SCLK_DDRC>; > + clock-names = "dmc_clk"; > + status = "disabled"; > + }; > + > pinctrl: pinctrl { > compatible = "rockchip,rk3399-pinctrl"; > rockchip,grf = <&grf>; >