From: Subhash Jadavani <subhashj@codeaurora.org>
To: Jesse Chan <jc@linux.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Vivek Gautam <vivek.gautam@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: qcom-ufs: add missing MODULE_DESCRIPTION/LICENSE
Date: Tue, 21 Nov 2017 11:19:36 -0800 [thread overview]
Message-ID: <9c48d20f858188432d72d4b69e3ff434@codeaurora.org> (raw)
In-Reply-To: <20171120213305.53913-1-jc@linux.com>
On 2017-11-20 13:33, Jesse Chan wrote:
> This change resolves a new compile-time warning
> when built as a loadable module:
>
> WARNING: modpost: missing MODULE_LICENSE() in
> drivers/phy/qualcomm/phy-qcom-ufs.o
> see include/linux/module.h for more information
>
> This adds the license as "GPL v2", which matches the header of the
> file.
>
> MODULE_DESCRIPTION is also added.
>
> Signed-off-by: Jesse Chan <jc@linux.com>
> ---
> drivers/phy/qualcomm/phy-qcom-ufs.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-ufs.c
> b/drivers/phy/qualcomm/phy-qcom-ufs.c
> index c5ff4525edef..124dc70f6986 100644
> --- a/drivers/phy/qualcomm/phy-qcom-ufs.c
> +++ b/drivers/phy/qualcomm/phy-qcom-ufs.c
> @@ -675,3 +675,6 @@ int ufs_qcom_phy_power_off(struct phy *generic_phy)
> return 0;
> }
> EXPORT_SYMBOL_GPL(ufs_qcom_phy_power_off);
> +
> +MODULE_DESCRIPTION("Universal Flash Storage (UFS) QCOM PHY");
> +MODULE_LICENSE("GPL v2");
Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2017-11-21 19:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 21:33 [PATCH] phy: qcom-ufs: add missing MODULE_DESCRIPTION/LICENSE Jesse Chan
2017-11-20 22:06 ` Bjorn Andersson
2017-11-21 19:19 ` Subhash Jadavani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c48d20f858188432d72d4b69e3ff434@codeaurora.org \
--to=subhashj@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=jc@linux.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vivek.gautam@codeaurora.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.