From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 02/13] drm/i915: Introduce the i915_user_extension_method Date: Wed, 13 Mar 2019 11:35:55 +0000 Message-ID: <9c6c162d-e54b-5de3-58d7-70e0f79ba752@linux.intel.com> References: <20190308141244.16837-1-chris@chris-wilson.co.uk> <20190308141244.16837-3-chris@chris-wilson.co.uk> <155247421525.30003.1677063484586585461@skylake-alporthouse-com> <416b041d-ab92-5dd4-03a0-c0320ad95b61@linux.intel.com> <155247607083.30003.12037087488629119993@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2EE346E091 for ; Wed, 13 Mar 2019 11:35:57 +0000 (UTC) In-Reply-To: <155247607083.30003.12037087488629119993@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEzLzAzLzIwMTkgMTE6MjEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTAzLTEzIDExOjEzOjEwKQo+Pgo+PiBPbiAxMy8wMy8yMDE5IDEwOjUw LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBRdW90aW5nIFR2cnRrbyBVcnN1bGluICgyMDE5LTAz LTA4IDE0OjMzOjAyKQo+Pj4+Cj4+Pj4gT24gMDgvMDMvMjAxOSAxNDoxMiwgQ2hyaXMgV2lsc29u IHdyb3RlOgo+Pj4+PiAraW50IGk5MTVfdXNlcl9leHRlbnNpb25zKHN0cnVjdCBpOTE1X3VzZXJf ZXh0ZW5zaW9uIF9fdXNlciAqZXh0LAo+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgIGNvbnN0 IGk5MTVfdXNlcl9leHRlbnNpb25fZm4gKnRibCwKPj4+Pj4gKyAgICAgICAgICAgICAgICAgICAg ICB1bnNpZ25lZCBsb25nIGNvdW50LAo+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgIHZvaWQg KmRhdGEpCj4+Pj4+ICt7Cj4+Pj4+ICsgICAgIHVuc2lnbmVkIGludCBzdGFja2RlcHRoID0gNTEy Owo+Pj4+Cj4+Pj4gSSBoYXZlIGRvdWJ0cyBhYm91dCB1c2VmdWxuZXNzIG9mIHRyeWluZyB0byBp bXBvc2Ugc29tZSBsaW1pdCBub3cuIEFuZAo+Pj4+IGFsc28gcmVzZXJ2YXRpb25zIGFib3V0IHVz aW5nIHRoZSBuYW1lIHN0YWNrLiBCdXQgYm90aCBhcmUgaXJyZWxldmFudAo+Pj4+IGltcGxlbWVu dGF0aW9uIGRldGFpbHMgYXQgdGhpcyBzdGFnZSBzbyBtZWguCj4+Pgo+Pj4gV2UgbmVlZCBkZWZl bmNlIGFnYWluc3QgbWFsaWNlIHVzZXJzcGFjZSBkb2luZwo+Pj4gICAgICAgIHN0cnVjdCBpOTE1 X3VzZXJfZXh0ZW5zaW9uIGV4dCA9IHsKPj4+ICAgICAgICAgICAgICAgIC5uZXh0X2V4dGVuc2lv biA9ICZleHQsCj4+PiAgICAgICAgfTsKPj4+IHNvIHNhZGx5IHNvbWUgbGltaXQgaXMgcmVxdWly ZWQuCj4+Cj4+IE9oIHllcywgZ29vZCBwb2ludC4gSSB3YXNuJ3QgdGhpbmtpbmcgbWFsaWNpb3Vz bHkgZW5vdWdoLgo+Pgo+PiBTIHBvc3NpYmxlIGFsdGVybmF0aXZlIHNvbHV0aW9uIGNvdWxkIGJl LCBpbiBjb25qdW5jdGlvbiB3aXRoIHRoZSByZXN1bHQKPj4gZmllbGQgZnJvbSBiZWxvdywgdG8g b25seSBhbGxvdyB2aXNpdGluZyBhbnkgZXh0ZW5zaW9uIG9uY2UuIEl0IHdvdWxkCj4+IHJlcXVp cmUgcmVzZXJ2aW5nIHNvbWUgdmFsdWUgYXMgbWVhbmluZyAibm90IHZpc2l0ZWQiLiBQcm9iYWJs eSB6ZXJvLCBzbwo+PiBub24temVybyBpbiByZXN1bHQgd291bGQgaW1tZWRpYXRlbHkgZmFpbCB0 aGUgY2hhaW4sIGJ1dCB3b3VsZCBhbHNvIEkKPj4gdGhpbmsgbWVhbiB3ZSBvbmx5IHN1cHBvcnQg bmVnYXRpdmUgdmFsdWVzIGluIHJlc3VsdCBhcyBvdXRwdXQsIG1hcHBpbmcKPj4gemVyb3MgdG8g b25lLgo+IAo+IEkndmUgYXZvaWRlZCB1c2luZyB0aGUgc3RydWN0IGl0c2VsZiBmb3IgbWFya3Vw IHNvIGZhci4KPiBVZ2gsIGl0IHdvdWxkIGFsc28gbWVhbiB0aGF0IHVzZXJzcGFjZSBoYXMgdG8g c2FuaXRpemUgdGhlIGV4dGVuc2lvbgo+IGNoYWluIGJldHdlZW4gdXNlcy4KPiAKPj4+Pj4gKwo+ Pj4+PiArICAgICB3aGlsZSAoZXh0KSB7Cj4+Pj4+ICsgICAgICAgICAgICAgaW50IGVycjsKPj4+ Pj4gKyAgICAgICAgICAgICB1NjQgeDsKPj4+Pj4gKwo+Pj4+PiArICAgICAgICAgICAgIGlmICgh c3RhY2tkZXB0aC0tKSAvKiByZWN1cnNpb24gdnMgdXNlZnVsIGZsZXhpYmlsaXR5ICovCj4+Pj4+ ICsgICAgICAgICAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPj4+Pj4gKwo+Pj4+PiArICAg ICAgICAgICAgIGlmIChnZXRfdXNlcih4LCAmZXh0LT5uYW1lKSkKPj4+Pj4gKyAgICAgICAgICAg ICAgICAgICAgIHJldHVybiAtRUZBVUxUOwo+Pj4+PiArCj4+Pj4+ICsgICAgICAgICAgICAgZXJy ID0gLUVJTlZBTDsKPj4+Pj4gKyAgICAgICAgICAgICBpZiAoeCA8IGNvdW50ICYmIHRibFt4XSkK Pj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgIGVyciA9IHRibFt4XShleHQsIGRhdGEpOwo+Pj4+ Cj4+Pj4gSG93IGFib3V0Ogo+Pj4+Cj4+Pj4gICAgICAgICAgICAgICAgICAgcHV0X3VzZXIoZXJy LCAmZXh0LT5yZXN1bHQpOwo+Pj4+Cj4+Pj4gQW5kOgo+Pj4+Cj4+Pj4gc3RydWN0IGk5MTVfdXNl cl9leHRlbnNpb24gewo+Pj4+ICAgICAgICAgICBfX3U2NCBuZXh0X2V4dGVuc2lvbjsKPj4+PiAg ICAgICAgICAgX191NjQgbmFtZTsKPj4+PiAgICAgICAgICAgX191MzIgcmVzdWx0Owo+Pj4+ICAg ICAgICAgICBfX3UzMiBtYno7Cj4+Pj4gfTsKPj4+Pgo+Pj4+IFNvIHdlIGFkZCB0aGUgYWJpbGl0 eSBmb3IgZWFjaCBleHRlbnNpb24gdG8gc3RvcmUgaXQncyBleGl0IGNvZGUgZ2l2aW5nCj4+Pj4g dXNlcnNwYWNlIG9wcG9ydHVuaXR5IHRvIGtub3cgd2hpY2ggb25lIGZhaWxlZC4KPj4+Pgo+Pj4+ IFdpdGggdGhpcyBJIHdvdWxkIGJlIHNhdGlzZmllZCB1c2FiaWxpdHkgaXMgZnV0dXJlIHByb29m IGVub3VnaC4KPj4+Cj4+PiBJJ20gc29yZWx5IHRlbXB0ZWQuIFRoZSBiaWdnZXN0IG9iamVjdGlv biBJIGhhdmUgaXMgdGhpcyBkZWZlYXRzIHRoZQo+Pj4gZWxlZ2FuY2Ugb2YgYSByZWFkLW9ubHkg Y2hhaW4uIFNvIHdobyB3b3VsZCBhY3R1YWxseSB1c2UgaXQ/Cj4+Pgo+Pj4gZXJyID0gZ2VtX2Nv bnRleHRfY3JlYXRlX2V4dCgmY2hhaW4pOwo+Pj4gaWYgKGVycikgewo+Pj4gICAgICAgIHN0cnVj dCBpOTE1X3VzZXJfZXh0ZW5zaW9uICpleHQgPSAoc3RydWN0IGk5MTVfdXNlcl9leHRlbnNpb24g KiljaGFpbjsKPj4+ICAgICAgICB3aGlsZSAoZXh0ICYmICFleHQtPnJlc3VsdCkKPj4+ICAgICAg ICAgICAgICAgIGV4dCA9IChzdHJ1Y3QgaTkxNV91c2VyX2V4dGVuc2lvbiAqKWV4dC0+bmV4dF9l eHRlbnNpb247Cj4+PiAgICAgICAgaWYgKGV4dCkKPj4+ICAgICAgICAgICAgICAgIGZwcmludGYo c3RkZXJyLCAiY29udGV4dCBjcmVhdGlvbiBmYWlsZWQgYXQgZXh0ZW5zaW9uOiAlbGxkIiwgZXh0 LT5uYW1lKTsKPj4+IH0KPj4+Cj4+PiBXaGF0IGV4YWN0bHkgYXJlIHRoZXkgZ29pbmcgdG8gZG8/ IFRoZXkgYXJlIG5vdCBnb2luZyB0byBkbyBhbnl0aGluZwo+Pj4gbGlrZQo+Pj4gICAgICAgIHdo aWxlIChlcnIpIHsKPj4+ICAgICAgICAgICAgICAgIGV4dCA9IGZpcnN0X2ZhdWx0eV9leHQoJmNo YWluKTsKPj4+ICAgICAgICAgICAgICAgIHN3aXRjaCAoZXh0LT5uYW1lKSB7Cj4+PiAgICAgICAg ICAgICAgICBjYXNlIC4uLjogIGRvX2ZpeHVwX0EoZXh0KTsKPj4+ICAgICAgICAgICAgICAgIH0K Pj4+ICAgICAgICAgICAgICAgIGVyciA9IGdlbV9jb250ZXh0X2NyZWF0ZV9leHQoJmNoYWluKTsK Pj4+ICAgICAgICB9Cj4+Pgo+Pj4gSSdtIG5vdCByZWFsbHkgc2VlaW5nIGhvdyB0aGV5IGJlbmVm aXQgb3ZlciwgYW5kIGFib3ZlLCBoYW5kbGluZyB0aGUKPj4+IGlvY3RsIGVycm9yIGJ5IHByaW50 aW5nIG91dCB0aGUgZW50aXJlIGVycm9uZW91cyBzdHJ1Y3QgYW5kIGNoYWluLCBhbmQKPj4+IGZh bGxpbmcgYmFjayB0byBhdm9pZGluZyB0aGF0IGlvY3RsLgo+Pj4KPj4+IEkgdGhpbmsgd2hhdCB5 b3UgcmVhbGx5IHdhbnQgaXMgYSBwZXItYXBwbGljYXRpb24vZmQgZGVidWcgbG9nLCBzbyB0aGF0 Cj4+PiB3ZSBjYW4gZHVtcCB0aGUgYWN0dWFsIGVycm9ycyBhcyB0aGV5IGFyaXNlICh3aXRob3V0 IGxlYWtpbmcgdGhlbSBpbnRvCj4+PiB0aGUgZ2VuZXJhbCBzeXNsb2cpLgo+Pgo+PiBNYXliZS4u IGNvdWxkIGJlIGFuIGV4dGVuc2lvbiBvZiB0aGUgZXhpc3RpbmcgcHJvYmxlbSBvZiAiV2hhdCBF SU5WQUwKPj4geW91IG1lYW4gZXhhY3RseT8iIGluZGVlZC4KPj4KPj4gSSBkb24ndCBzZWUgYSBw cm9ibGVtIHdpdGggd3JpdGluZyBiYWNrIHRob3VnaD8KPiAKPiBXcml0aW5nIGFueXRoaW5nIGdp dmVzIG1lIHRoZSBoZWViaWUtamVlYmllcy4gSWYgd2Uga2VlcCBpdCBhIHJlYWQtb25seQo+IHN0 cnVjdCwgd2UgY2FuIG5ldmVyIGJlIHRyaWNrZWQgaW50byBvdmVyd3JpdGluZyBzb21ldGhpbmcg aW1wb3J0YW50Lgo+IAo+IEl0IGFsc28gbWFrZXMgaXQgaGFyZGVyIGZvciB1c2Vyc3BhY2UgdG8g cmV1c2UgYXMgdGhleSBoYXZlIHRvIGNsZWFyIHRoZQo+IHJlc3VsdCBmaWVsZD8KClllYWguLiBu b3RoaW5nIHRoZW4uCgpTaGFsbCB3ZSBvbmx5IHJlc2VydmUgc29tZSBzcGFjZSB3aXRoIGEgZmxh Z3MgYW5kIHNvbWUgcnN2ZCBmaWVsZHMganVzdCAKaW4gY2FzZSBpdCB3aWxsIG5lZWQgdG8gY2hh bmdlL2dyb3c/CgpSZWdhcmRzLAoKVHZydGtvCgoKCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4