All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Khem Raj <raj.khem@gmail.com>, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] python3: Expose PYTHON_BINABI in global config metadata
Date: Wed, 04 Sep 2019 19:49:19 +0100	[thread overview]
Message-ID: <9c7b636db80cad1b2d9a29b287d1e0500aadf668.camel@linuxfoundation.org> (raw)
In-Reply-To: <20190904181009.8374-1-raj.khem@gmail.com>

On Wed, 2019-09-04 at 11:10 -0700, Khem Raj wrote:
> packages can use
> 
> find_package(PythonInterp REQUIRED)
> find_package(PythonLibs REQUIRED)
> 
> while we control PYTHON pointing to native py3 the libs and include
> directories will then point to build host version, which can result
> in
> unexpected combination and if we are lucky we get errors if its quite
> different e.g. py2 libs/includes and py3 executable
> 
> This variable can be then used to export PYTHON_LIBRARY and
> PYTHON_INCLUDE_DIR so that above find_packages can work correctly
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/conf/distro/include/tcmode-default.inc   | 3 +++
>  meta/recipes-devtools/python/python3_3.7.4.bb | 1 -
>  2 files changed, 3 insertions(+), 1 deletion(-)

Putting this into the global namespace seems like a really bad idea.
Can we not use a class like Alex mentions? I thought we already had
one?

Cheers,

Richard



  parent reply	other threads:[~2019-09-04 18:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-04 18:10 [PATCH 1/2] python3: Expose PYTHON_BINABI in global config metadata Khem Raj
2019-09-04 18:10 ` [PATCH 2/2] python3native: export PYTHON_LIBRARY and PYTHON_INCLUDE_DIR Khem Raj
2019-09-04 18:16   ` Alexander Kanavin
2019-09-04 18:53     ` Khem Raj
2019-09-04 18:14 ` [PATCH 1/2] python3: Expose PYTHON_BINABI in global config metadata Alexander Kanavin
2019-09-04 18:41   ` Khem Raj
2019-09-04 18:50   ` Khem Raj
2019-09-04 18:49 ` Richard Purdie [this message]
2019-09-04 18:51   ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c7b636db80cad1b2d9a29b287d1e0500aadf668.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.