From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kartik Rajput <kkartik@nvidia.com>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@sandisk.com>,
Bart Van Assche <bvanassche@acm.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <mkp@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Thierry Reding <treding@nvidia.com>,
linux-scsi@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: ufs: Add nvidia,tegra264-ufs
Date: Wed, 30 Sep 2026 12:45:17 +0200 [thread overview]
Message-ID: <9ca8cf3e-6d44-46a7-b269-d687db708401@kernel.org> (raw)
In-Reply-To: <20260930-hopeful-hasty-eagle-052982@quoll>
On 30/09/2026 12:43, Krzysztof Kozlowski wrote:
> On Tue, Sep 29, 2026 at 03:15:07PM +0530, Kartik Rajput wrote:
>> Add binding for the UFS host controller on NVIDIA Tegra264 SoCs. The
>> controller supports UFS 3.1 up to HS-G4B on two data lanes.
>>
>> Signed-off-by: Kartik Rajput <kkartik@nvidia.com>
>
> I do not understand why you added dependency on the phy in this
> patchset. Looks like fake/not real dependency, so you only stall your
> work and raise questions.
>
> Cover letter mentions "the binding references
> the M-PHY provider" but this is simply NOT TRUE.
>
> Patch itself is correct but I suggest to be careful what you send, to
> avoid questions on trivial stuff.
Forgot the tag:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
But honestly, this fake dependency is a no-go and I commented on driver
patch regarding it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-30 10:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 9:45 [PATCH v2 0/4] Add UFS host controller support for NVIDIA Tegra264 Kartik Rajput
2026-09-29 9:45 ` [PATCH v2 1/4] dt-bindings: ufs: Add nvidia,tegra264-ufs Kartik Rajput
2026-09-30 10:43 ` Krzysztof Kozlowski
2026-09-30 10:45 ` Krzysztof Kozlowski [this message]
2026-09-29 9:45 ` [PATCH v2 2/4] scsi: ufs: Add UIC DEBUGSAVECONFIGTIME attribute and its field masks Kartik Rajput
2026-09-29 9:45 ` [PATCH v2 3/4] scsi: ufs: hisi: Use VS_DEBUGSAVECONFIGTIME instead of a literal address Kartik Rajput
2026-09-29 9:45 ` [PATCH v2 4/4] scsi: ufs: tegra: Add Tegra264 UFS host controller driver Kartik Rajput
2026-09-29 10:07 ` sashiko-bot
2026-09-30 10:44 ` Krzysztof Kozlowski
2026-09-30 11:34 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ca8cf3e-6d44-46a7-b269-d687db708401@kernel.org \
--to=krzk@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@sandisk.com \
--cc=bvanassche@acm.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kkartik@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkp@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=thierry.reding@kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.