From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7728EFCC9A5 for ; Mon, 9 Mar 2026 23:50:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Usf2c8oheBhN4rTUg/6UxDx9DMs4PXDC10F9BFyFRk0=; b=Ywv36y7LWaAfzT6EPNP3CuKS6V 3XDhAyRWFyQ9Dwg3huIpHq/kBCbM2bHi7ckvREkq+KTg7PAxXID2sN3RGP/RQI+1XDVGk+kbYiVTE p8e9xCIWCxFGHhdeoNnvdbkTImM9HGNHfDqyqWmBJiPo5IrkHs0WIE5XxXo2cBygeV2d/1z/3KxQM GSW1K2wkzFtafO9NU7PKvcX0JSUOTObptcCQbn6hIiAWuPxjJUDpTi1o21Uk1WN+kbkghbs6534IW WrzbGgJgfAe8ZolSUEif03/jT/ha+x+M6ecMngt+XjqU1W/viBbL3CWV4sYa9jrULAA+duKlLmPKX B5u8fxwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzkN0-00000008JoZ-3sYe; Mon, 09 Mar 2026 23:50:42 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzkMz-00000008JoJ-1IHt for ath10k@bombadil.infradead.org; Mon, 09 Mar 2026 23:50:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=Usf2c8oheBhN4rTUg/6UxDx9DMs4PXDC10F9BFyFRk0=; b=dBSNJ27IG2bXcsf08zaaZB3LrR CdTSuzA1KZItafUG36EzUDA3WzUkjBkUPWkdeGCtQIxAJ6t9qGRJVoYCqN3+kxdi9u14utn1NSPVp uhdV5PZ/kVt2uVEogKfrW9hYroZD8PyLlmSTY6d2b3kSpuCB3B8CY6roQGx+HStH4TzS7XZSwRR6d gzfaKw2tXYg5AJHQocyy2AVdhLJAQMGVwkuK7aP6UEF9dPCS0XEA13MvQxmoPfZLyPgU6udYRliC4 qv/iIlcx6jT7jGm+Mo4k4HQirLk6dPjisx1KN47lmeso3SyIGE88pY+Y9ryY2LOq7+J7Cn67S2KWr o84OENOw==; Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzkMu-0000000DMMd-0lGu for ath10k@lists.infradead.org; Mon, 09 Mar 2026 23:50:38 +0000 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 629JFukk2872805 for ; Mon, 9 Mar 2026 23:50:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Usf2c8oheBhN4rTUg/6UxDx9DMs4PXDC10F9BFyFRk0=; b=IQgsSFbn0KFUnTb1 KDrlCb6DNjAXoPA8Nwvhml10EY3QiGV6sjcWdNcnFvTJTrnhRVGJDtbhXabxBPnO BFpeIJL2HBaHQH7kQciQbJgYijhb3lehwUQC0cKolzAqoof+fVPKpuoHYKhB9Hgl BuQBFoeu9Hd+OfySMjSvJpeHu8TWZsotLGbmQdkOPDDb3/sqO2JBA9vS5polGetk fL4zv4ya9KZWdQVnq0gUkDwX3qHUozGvBXji0UFEYja0gt+AGzmuTNPejNDJohox OT/YvTyzG3CdAs6InKcMXboMSg94ba5A1lPk9z5x7jvLPjgpl2gEd4edPd7aC87I eaYn/w== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ct477gpam-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 23:50:32 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-2be21f89332so7691315eec.0 for ; Mon, 09 Mar 2026 16:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773100231; x=1773705031; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Usf2c8oheBhN4rTUg/6UxDx9DMs4PXDC10F9BFyFRk0=; b=UhtbBEbPcTeFkRb5hyrN23xul5qIFUI9nGyZV5n8wBNNKjSGDt95rNx8FDTZrKZoWG UvphbZstG+fBAHG9cDgdtYCmrshLUdZ9G1MkAMnykTQoN8d21A+inDbbb3DQAQ6kGUxa Vpk1JG62KDvdc29TSk1UFC1FvAFMV+uDW60KYK2GMgGCREgKJHCFuPCUzClUVTH6Ov4o oak6LAE4f4cTiRm9RY5kZJrjFsxc3JuvQi9r4iXig5plbkndmXVhvUMQ72ivu/WkQPBC oRmEUdm76+UYPZ6NC/PIZSQEK4twC6goJbUw7QgqF8JxcpuYl9vQdLR0M2URoHDRDNhR y7+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773100231; x=1773705031; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Usf2c8oheBhN4rTUg/6UxDx9DMs4PXDC10F9BFyFRk0=; b=tI9xMLhHnRmCCeV7q2XJRh1H9NXXeUeg/mBJPWONpeSsXuhjTbB4L3dT/yCSyV2LuP RO2QNWr1KzvHG1XP6imjwS4tBCi5i9pg/iDzKMJy5ev9ff6/fgxPbX36ik1bh5SvZSDT L/jfSANCdt7DgUMCUOcvLACWAha/lzYzmhzdFukaq9vEHU/+mSL5phMN/O83d7d4IMga 8UF4Ym9dVN489W6+zLdn2qLbARlYYtcDtLwNj4tfO7D7m7lMIwHuwEB/u2FWjmrWeKO3 a9KroxQt8F5UXkHXFjeddz7dlw7gvjtLm7071auRzSWZeat29oYoXrxXY+g61wZmj0sA A4Yw== X-Forwarded-Encrypted: i=1; AJvYcCWZYENTP6CoMCHGKGjNEkPdxkIX/Ky4lOMc2DLbP+8OZgoL3wd36Q6tfLWXQXMDEcEqpsRbiWM=@lists.infradead.org X-Gm-Message-State: AOJu0YzvKBE6lUHWnOno49zkJGePzD/SLvm6tgBUHWbhPzn9NCe3BOYk DDy4Gq7s9zWe6BKu+csaHziSy3iuYXq4nanyuFZblE7mFLJ9rntohNFvn1nMpuUXWrYud75GI9F cq7YMFRA8OVnV552BHuR3eF+DdacCqI2pT2CGZRk1+Tvk58AdIGfIlFfEcqzGdc8R X-Gm-Gg: ATEYQzyWP4koVScA6ZHbgCQnPUfR2FJDuDlAHt4yD19GX1AOZQ7jsI77uftwm/g5a2n n/I9QJjE5VRqD3Ql4hACOzaIxtM42t3Ga5FAPNr8hIwZ3+oSwowP6lCcWxCVg1kQk31zm9i9R/s 71V7jBk+YUU3bdxaBZJ63lG8RXS0yWieBhwYQ6t0SVNuKMQKiNepFjW2U1UGV6veDhNMh31QdV2 lpMkL2dw8vf0PM/2GmjGwP+m937ratP4OJBlJB0lBVmUUwheTskQ/JrES9FGIQ5hxH7I5Rt1noz 5ncIeLVyFViHH6srO09m8BudBbmaziOlvI4Fo7D8NU3t7rAnl9uDJYeqjQ677pHnl/FURFhKo6z 2a+FboGSmpgYJ/PzPOyGPlAx3z/qTqCTI/6oiWSGTN1BTkCMLUqC6gp4jyuLjpSOzR/tU25ilKw H2Oq60RsK8vHyOVg== X-Received: by 2002:a05:7022:629f:b0:128:cf80:deea with SMTP id a92af1059eb24-128cf80e01fmr3402095c88.1.1773100230944; Mon, 09 Mar 2026 16:50:30 -0700 (PDT) X-Received: by 2002:a05:7022:629f:b0:128:cf80:deea with SMTP id a92af1059eb24-128cf80e01fmr3402088c88.1.1773100230365; Mon, 09 Mar 2026 16:50:30 -0700 (PDT) Received: from [192.168.1.41] (c-24-130-122-79.hsd1.ca.comcast.net. [24.130.122.79]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-128dc848cbcsm3108879c88.7.2026.03.09.16.50.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Mar 2026 16:50:29 -0700 (PDT) Message-ID: <9cc7638f-1232-4cb7-b4d7-cdac66a2f4ba@oss.qualcomm.com> Date: Mon, 9 Mar 2026 16:50:25 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/8] Group QMI service IDs into the QMI header To: Daniel Lezcano , konradybcio@kernel.org, andersson@kernel.org Cc: linux-kernel@vger.kernel.org, Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Kees Cook , Greg Kroah-Hartman , Arnd Bergmann , Mark Brown , Wesley Cheng , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org References: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> Content-Language: en-US From: Jeff Johnson In-Reply-To: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDIxMCBTYWx0ZWRfX12qt82y0wtEE AEjnZ0+gCygL/Hpw5Ym/85/DFRS3Md8JyV0xAznpfITV22kLb3Eu9JUZY5x8NUvGBLybWh5XnBO WuCxzApvTir5GlybC86OWnCN8M41J2UsTC+jesCEGlfd/Z2M3xBnvGoDgfXiHFpSkzCHQZglNTx 5BHHi8Bykv8vNn19pVkoshkVvzLl/SXeEDRCe2vIs7/rmHNHv/iaHVDEj7QDUdea7wBAjxEkWwT pBUpfuba6ENwCAIU7aihMMc7IpAvdCsCGV5e/z/Sc9rUKDfQbB59qif6e4IpCYJf4rCR3U0J4SK CCS+ngXYG+H9fAYuLqqZafVmA7aEq6AuVLPj84ur/kRqM5ls00F49KW0zduJi/2Z6L2Zj5g9tII h+TZ3yb9rmu7Nk3KQTHlXpKRWCJncwUcggfAVFWBtr4o7HJqlV4oZAWhiESu4iYSqN5Whw2oU3Q IEFn3oVmtIFTzzYo+8A== X-Proofpoint-GUID: O8-3bl_aGeyNP0rriJlMp60jnTeCmJWC X-Authority-Analysis: v=2.4 cv=KLxXzVFo c=1 sm=1 tr=0 ts=69af5cc8 cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=Tg7Z00WN3eLgNEO9NLUKUQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=J1Y8HTJGAAAA:8 a=1XWaLZrsAAAA:8 a=20KFwNOVAAAA:8 a=KKAkSRfTAAAA:8 a=iox4zFpeAAAA:8 a=ag1SF4gXAAAA:8 a=COk6AnOGAAAA:8 a=JfrnYn6hAAAA:8 a=GmBS2Oju3p3q64JsNm8A:9 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 a=y1Q9-5lHfBjTkpIzbSAN:22 a=cvBusfyB2V15izCimMoJ:22 a=WzC6qhA0u3u7Ye7llzcV:22 a=Yupwre4RP9_Eg_Bd0iYG:22 a=TjNXssC_j7lpFel5tvFf:22 a=1CNFftbPRP8L7MoqJWF3:22 X-Proofpoint-ORIG-GUID: O8-3bl_aGeyNP0rriJlMp60jnTeCmJWC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_06,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 bulkscore=0 impostorscore=0 spamscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090210 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260309_235037_333911_4CCB2CB3 X-CRM114-Status: GOOD ( 21.51 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath10k" Errors-To: ath10k-bounces+ath10k=archiver.kernel.org@lists.infradead.org On 3/9/2026 4:03 PM, Daniel Lezcano wrote: > The different subsystems implementing the QMI service protocol are > using their own definition of the service id. It is not a problem but > it results on having those duplicated with different names but the > same value and without consistency in their name. > > It makes more sense to unify their names and move the definitions in > the QMI header file providing a consistent way to represent the > supported protocols. Consequently the different drivers will use them > instead of their own definition of the service id. > > Cc: Alex Elder > Cc: Andrew Lunn > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: Jeff Johnson > Cc: Bjorn Andersson > Cc: Mathieu Poirier > Cc: Srinivas Kandagatla > Cc: Konrad Dybcio > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: Kees Cook > Cc: Greg Kroah-Hartman > Cc: Arnd Bergmann > Cc: Mark Brown > Cc: Wesley Cheng > Cc: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-wireless@vger.kernel.org > Cc: ath10k@lists.infradead.org > Cc: ath11k@lists.infradead.org > Cc: ath12k@lists.infradead.org > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-remoteproc@vger.kernel.org > Cc: linux-sound@vger.kernel.org > --- > Daniel Lezcano (8): > soc: qcom: qmi: Enumerate the service IDs of QMI > net: ipa: Use the unified QMI service ID instead of defining it > locally > net: drivers: wireless: ath: Use the unified QMI service ID instead of > defining it locally prefix for wireless drivers is simply wifi: : so s/net: drivers: wireless:/wifi:/ > remoteproc: qcom: Use the unified QMI service ID instead of defining > it locally > slimbus: qcom-ngd-ctrl: Use the unified QMI service ID instead of > defining it locally > soc: qcom: pdr: Use the unified QMI service ID instead of defining it > locally > ALSA: usb-audio: qcom: Use the unified QMI service ID instead of > defining it locally > samples: qmi: Use the unified QMI service ID instead of defining it > locally > > drivers/net/ipa/ipa_qmi.c | 6 ++---- > drivers/net/wireless/ath/ath10k/qmi.c | 2 +- > drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h | 1 - > drivers/net/wireless/ath/ath11k/qmi.c | 2 +- > drivers/net/wireless/ath/ath11k/qmi.h | 1 - > drivers/net/wireless/ath/ath12k/qmi.c | 2 +- > drivers/net/wireless/ath/ath12k/qmi.h | 1 - > drivers/remoteproc/qcom_sysmon.c | 2 +- > drivers/slimbus/qcom-ngd-ctrl.c | 5 ++--- > drivers/soc/qcom/pdr_interface.c | 4 ++-- > drivers/soc/qcom/pdr_internal.h | 3 --- > drivers/soc/qcom/qcom_pd_mapper.c | 2 +- > include/linux/soc/qcom/qmi.h | 12 ++++++++++++ > samples/qmi/qmi_sample_client.c | 2 +- > sound/usb/qcom/qc_audio_offload.c | 2 +- > sound/usb/qcom/usb_audio_qmi_v01.h | 1 - You are touching a lot of subsystems with a single series. How do you plan on having these land? Do you have a maintainer who will take all of these through their tree? > 16 files changed, 25 insertions(+), 23 deletions(-) >