From mboxrd@z Thu Jan 1 00:00:00 1970 From: aq Subject: Re: [PATCH] Guest boot loader support Date: Tue, 26 Apr 2005 18:54:31 +0900 Message-ID: <9cde8bff0504260254266a7027@mail.gmail.com> References: <1114469427.4336.42.camel@bree.local.net> <9cde8bff050426023247aa475b@mail.gmail.com> Reply-To: aq Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_164_23074686.1114509271218" Return-path: In-Reply-To: <9cde8bff050426023247aa475b@mail.gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Katz Cc: xen-devel List-Id: xen-devel@lists.xenproject.org ------=_Part_164_23074686.1114509271218 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On 4/26/05, aq wrote: > On 4/26/05, Jeremy Katz wrote: > > Attached is an updated version of the patch to add boot loader support > > for guest domains. > > > > Changes from the initial set of patches: > > * Per Ian's request, adds an option to specify booting a specific kerne= l > > from the host domain (you can specify it either with the title of the > > boot loader config entry or with the grub 0-based index) > > * Reduces some of the code duplication for finding out what the virtual > > disk to boot off of is > > * Improved error handling to use the standard Xen logging and error > > facilities > > Jeremy, I looked at your code, and find few lines like this: exec("%s =3D r\"%s\"" %(self.commands[com], arg.strip())) Looks like you dont need the above "r". Then the code should be: exec("%s =3D \"%s\"" %(self.commands[com], arg.strip())) Here is a small patch (against your patch) to remove those typos. $ diffstat booloader1.patch xen-bootloader2.patch | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Signed-off-by: Nguyen Anh Quynh ------=_Part_164_23074686.1114509271218 Content-Type: application/octet-stream; name="booloader1.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="booloader1.patch" LS0tIHhlbi1ib290bG9hZGVyLnBhdGNoCTIwMDUtMDQtMjYgMTg6NDc6MzYuNDM3MDI4MDAwICsw OTAwCisrKyB4ZW4tYm9vdGxvYWRlcjIucGF0Y2gJMjAwNS0wNC0yNiAxODo0OTowMS42ODcwMjgw MDAgKzA5MDAKQEAgLTE0Nyw3ICsxNDcsNyBAQCBkaWZmIC1OcnUgYS90b29scy9weWdydWIvc3Jj L0dydWJDb25mLnB5CiArDQogKyAgICAgICAgICAgIGlmIHNlbGYuY29tbWFuZHMuaGFzX2tleShj b20pOg0KICsgICAgICAgICAgICAgICAgaWYgc2VsZi5jb21tYW5kc1tjb21dIGlzIG5vdCBOb25l Og0KLSsgICAgICAgICAgICAgICAgICAgIGV4ZWMoIiVzID0gclwiJXNcIiIgJShzZWxmLmNvbW1h bmRzW2NvbV0sIGFyZy5zdHJpcCgpKSkNCisrICAgICAgICAgICAgICAgICAgICBleGVjKCIlcyA9 IFwiJXNcIiIgJShzZWxmLmNvbW1hbmRzW2NvbV0sIGFyZy5zdHJpcCgpKSkNCiArICAgICAgICAg ICAgICAgIGVsc2U6DQogKyAgICAgICAgICAgICAgICAgICAgbG9nZ2luZy5pbmZvKCJJZ25vcmVk IGltYWdlIGRpcmVjdGl2ZSAlcyIgJShjb20sKSkNCiArICAgICAgICAgICAgZWxzZToNCkBAIC0y NDYsNyArMjQ2LDcgQEAgZGlmZiAtTnJ1IGEvdG9vbHMvcHlncnViL3NyYy9HcnViQ29uZi5weQog Kw0KICsgICAgICAgICAgICBpZiBzZWxmLmNvbW1hbmRzLmhhc19rZXkoY29tKToNCiArICAgICAg ICAgICAgICAgIGlmIHNlbGYuY29tbWFuZHNbY29tXSBpcyBub3QgTm9uZToNCi0rICAgICAgICAg ICAgICAgICAgICBleGVjKCIlcyA9IHJcIiVzXCIiICUoc2VsZi5jb21tYW5kc1tjb21dLCBhcmcu c3RyaXAoKSkpDQorKyAgICAgICAgICAgICAgICAgICAgZXhlYygiJXMgPSBcIiVzXCIiICUoc2Vs Zi5jb21tYW5kc1tjb21dLCBhcmcuc3RyaXAoKSkpDQogKyAgICAgICAgICAgICAgICBlbHNlOg0K ICsgICAgICAgICAgICAgICAgICAgIGxvZ2dpbmcuaW5mbygiSWdub3JlZCBkaXJlY3RpdmUgJXMi ICUoY29tLCkpDQogKyAgICAgICAgICAgIGVsc2U6DQo= ------=_Part_164_23074686.1114509271218 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel ------=_Part_164_23074686.1114509271218--