From mboxrd@z Thu Jan 1 00:00:00 1970 From: aq Subject: Re: [PATCH] Guest boot loader support Date: Wed, 27 Apr 2005 04:37:34 +0900 Message-ID: <9cde8bff05042612371682e511@mail.gmail.com> References: <1114469427.4336.42.camel@bree.local.net> <9cde8bff050426023247aa475b@mail.gmail.com> <1114534871.18436.7.camel@bree.local.net> Reply-To: aq Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1114534871.18436.7.camel@bree.local.net> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Katz Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 4/27/05, Jeremy Katz wrote: > On Tue, 2005-04-26 at 18:32 +0900, aq wrote: > > Jeremy, I tried it out with the latest xen-unstable got from the > > homepage and patch with xen-booloader.patch. There are few "hunk". > > What xen-unstable version are you using? >=20 > Bah, bitkeeper foils me again. Rediffed to current -unstable attached. > Thanks for catching that. >=20 > > By the way, did you forget __init__.py in pygrub/src/ ? pygrub is a > > python package, and looks like we need it. At the moment compilation > > spit out an error "... __init__.py not found...". >=20 > It was there at one point... added it as well for this diff. >=20 > As for your other comment, the r quoting of the strings is to make sure > that the strings are interpreted as raw strings instead of trying to > handle escaping which helps in cases where you have "odd" things in your > grub.conf. ok, i see the point. other question: pygrub::get_config(fn) tries to read "/boot/grub/grub.conf". Normally this should be "/boot/grub/menu.lst". I wonder which distro are you working on? I expect this code will be in -unstable soon, so we can work on the same code base. sending patch would be easier. thank you, aq