From mboxrd@z Thu Jan 1 00:00:00 1970 From: aq Subject: Re: [PATCH] xen bootloader Date: Fri, 29 Apr 2005 12:25:04 +0900 Message-ID: <9cde8bff0504282025452c1242@mail.gmail.com> References: <9cde8bff0504270221eded71f@mail.gmail.com> <1114744237.17750.39.camel@bree.local.net> Reply-To: aq Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1114744237.17750.39.camel@bree.local.net> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Katz Cc: Mike Wray , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 4/29/05, Jeremy Katz wrote: > On Wed, 2005-04-27 at 18:21 +0900, aq wrote: > > Here is a patch to fix few problems in Xen bootloader you sent to the > > list yesterday. >=20 > Thanks. Sorry for the delay in responding, I've been underwater with > stuff for FC4 test3. >=20 > > list of changes: > > - make a dummy tools/pygrub/src/__init__.py >=20 > I still don't know why this didn't work, but thanks. >=20 > > - extend filesystem abstraction by adding file_exist() method. this > > method is used to check for existent of a file given its name. now > > ext2fs implements this method. >=20 > Great, thanks. My only comment about the ext2fs code for this is that > you might as well inline the contents of ext2_file_exist in > ext2fs_file_exist... you don't gain anything by having that for reuse > that I can see. I agree. By the way, I am working on xfs/jfs/reiserfs module for this code. Hopefully I will finish soon. regards, aq