Re: [PATCH] allow user to choose mirror to get kernel source

[aq <aquynh@gmail.com>]

On 5/7/05, Keir Fraser <Keir.Fraser@cl.cam.ac.uk> wrote:
> > hello,
> >
> > This patch allows user to choose mirror to get linux kernel source
> > instead of getting it from kernel.org (which set as default)
> >
> > # diffstat xen.patch
> >  Config.mk             |    3 +++
> >  buildconfigs/Rules.mk |    2 +-
> >  2 files changed, 4 insertions(+), 1 deletion(-)
> >
> > Signed-off-by: Nguyen Anh Quynh <aquynh@gmail.com>

> Isn't it just as easy to change the address directly in
> buildconfigs/Rules.mk? 

hmm.. I dont think so. Just declare to everyone that if they want to
customize a little bit the building process, they can come there (I
suppose that Config.mk is fine for this purpose) to mess up, and they
dont need to look further. Isnt it much easier for users if you put
this variable (and those alike) to one place, and for all needs, users
can go there to customize them?

Besides, we should not expect that everyone want/be-able to hack up
the code to modify the right place to get this job done. That is
cleary more difficult than modifying a variable.

>Alternatively you can download the kernel from
> wherever you like and place it at the root of the build tree, or in
> the immediate parent directory, and the build process will
> automatically pick it up rather than contact www.kernel.org.

Then you want your users to do some other things before compiling?
That is a little bit more incovenient, isnt it?

My idea is that if users have a better mirror than kernel.org, they
can modify this variable (easily, without needing to mess with
anything else) and go on building Xen. Just imagine one needs to
install dozen systems, they would get the kernel source and put it in
a local server, then let all others to get it from there.

So I think it is worthwhy. Or there is no harm at all to have this variable.

Anyway, if you apply this patch, I think other names (like
LINUX_KERNEL_MIRROR) might be better than "KERNEL_REPO".

Thank you,
aq