From mboxrd@z Thu Jan 1 00:00:00 1970 From: aq Subject: Re: [PATCH] reiserfs module for pygrub Date: Tue, 24 May 2005 13:15:58 +0900 Message-ID: <9cde8bff05052321156b0322b6@mail.gmail.com> References: <1116904670.3439.28.camel@bree.local.net> Reply-To: aq Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1116904670.3439.28.camel@bree.local.net> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Katz Cc: Ian Pratt , xen-devel List-Id: xen-devel@lists.xenproject.org On 5/24/05, Jeremy Katz wrote: > On Tue, 2005-05-24 at 02:27 +0100, Ian Pratt wrote: > > > > The libraries get linked dynamically into the python module. If at > > > > runtime, the library isn't present, it won't cause a fatal > > > error (you > > > > won't be able to access those types of filesystems, but it > > > won't fall > > > > over on the import) > > > > > > yes, this trick could be easily adapted to reiserfs and > > > others. but what if the user keeps the needed libraries, but > > > removes those headers ( like /usr/include/ext2fs/ext2_fs.h > > > )after building (for example to make the system more > > > compact)? then the check would fail. > > > > As I understand it, it's a build-time check for the header file > > (setup.py) >=20 > Exactly. >=20 anyway, i sent in a check file for ext2 and reiserfs tools/check/ check_fslibs_devel (which is filtered by accident, and i dont see it to be approved to the list yet?). so i doubt that we need to check (again) for header files in setup.py. regards, aq