From mboxrd@z Thu Jan  1 00:00:00 1970
From: aq <aquynh@gmail.com>
Subject: Re: [PATCH] xs.h and xs_lib.h
Date: Mon, 13 Jun 2005 00:14:44 +0900
Message-ID: <9cde8bff0506120814b2ebbe8@mail.gmail.com>
References: <9cde8bff050610013219cd249d@mail.gmail.com>
	<1118558205.31631.2.camel@localhost.localdomain>
Reply-To: aq <aquynh@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1118558205.31631.2.camel@localhost.localdomain>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Xen Dev <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 6/12/05, Rusty Russell <rusty@rustcorp.com.au> wrote:
> On Fri, 2005-06-10 at 03:32 -0500, aq wrote:
> > This patch moves declaration of xs_handle from xs.c to xs.h.
>=20
> No; why do this?  It's opaque for a reason.  Originally it was just an
> int, but Keir insisted it be an opaque structure.  Exposing it binds us
> to the current structure again.
>=20
> > Besides,
> > it installs xs.h and xs_lib.h to /usr/include, and gets top Makefile
> > uninstalled them when cleaning up.
>=20
> xs_lib.h should not be installed in /usr/include!

i see that, but where should we put this header?

regards,
aq