From mboxrd@z Thu Jan 1 00:00:00 1970 From: aq Subject: Re: [PATCH] xs.h and xs_lib.h Date: Tue, 14 Jun 2005 13:46:54 +0900 Message-ID: <9cde8bff05061321467b982b1c@mail.gmail.com> References: <9cde8bff050610013219cd249d@mail.gmail.com> <1118558205.31631.2.camel@localhost.localdomain> <9cde8bff0506120814b2ebbe8@mail.gmail.com> <1118709165.18549.5.camel@localhost.localdomain> Reply-To: aq Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1118709165.18549.5.camel@localhost.localdomain> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Rusty Russell Cc: Xen Dev List-Id: xen-devel@lists.xenproject.org On 6/14/05, Rusty Russell wrote: > On Mon, 2005-06-13 at 00:14 +0900, aq wrote: > > On 6/12/05, Rusty Russell wrote: > > > On Fri, 2005-06-10 at 03:32 -0500, aq wrote: > > > > This patch moves declaration of xs_handle from xs.c to xs.h. > > > > > > No; why do this? It's opaque for a reason. Originally it was just a= n > > > int, but Keir insisted it be an opaque structure. Exposing it binds = us > > > to the current structure again. > > > > > > > Besides, > > > > it installs xs.h and xs_lib.h to /usr/include, and gets top Makefil= e > > > > uninstalled them when cleaning up. > > > > > > xs_lib.h should not be installed in /usr/include! > > > > i see that, but where should we put this header? >=20 > Once the daemon and library are built, it's not necessary for anything. >=20 i installed xs_lib.h because xs.h includes it. now we need to remove this and include xs_lib.h in other files as needed. later i will send in another patch to fix this, and revert the problem raised in last patch. regards, aq