From mboxrd@z Thu Jan 1 00:00:00 1970 From: aq Subject: Re: [PATCH] fix broken ACM Date: Thu, 23 Jun 2005 17:04:22 +0900 Message-ID: <9cde8bff050623010440448361@mail.gmail.com> References: <9cde8bff05062210406b403295@mail.gmail.com> <9cde8bff05062210523e7dd070@mail.gmail.com> Reply-To: aq Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On 6/23/05, Keir Fraser wrote: >=20 > On 22 Jun 2005, at 18:52, aq wrote: >=20 > > are you sure? on my system, without the patch acm_init() would be > > defined twice. > > > > also, some structrures and global variables are hidden in the #else > > (of #if (ACM_USE_SECURITY_POLICY =3D=3D ACM_NULL_POLICY) ) > > > > > > how did you compile acm? >=20 > The whole point is not to bother, if the statically chosen security > policy is null.=20 i see, but the problem occurs if we want to compile it. the reason is because you grouped null ops together, but you accidentally hide some structures and variables. also we must enclose the declare of acm_init() in #if (ACM_USE_SECURITY_POLICY =3D ACM_NULL_POLICY). please see my second patch. regards, aq