From mboxrd@z Thu Jan 1 00:00:00 1970 From: aq Subject: Re: [PATCH] fix broken ACM Date: Thu, 23 Jun 2005 17:19:58 +0900 Message-ID: <9cde8bff050623011933b990e9@mail.gmail.com> References: <9cde8bff05062210406b403295@mail.gmail.com> <9cde8bff05062210523e7dd070@mail.gmail.com> <9cde8bff050623010440448361@mail.gmail.com> Reply-To: aq Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On 6/23/05, Keir Fraser wrote: >=20 > On 23 Jun 2005, at 09:04, aq wrote: >=20 > > i see, but the problem occurs if we want to compile it. the reason is > > because you grouped null ops together, but you accidentally hide some > > structures and variables. also we must enclose the declare of > > acm_init() in #if (ACM_USE_SECURITY_POLICY =3D ACM_NULL_POLICY). pleas= e > > see my second patch. >=20 > If we build non-NULL security policy then the struct definitions and so > on are compiled in, because they are in the else clause of the acm > header file. yes, that is true. but the default policy is NULL, and we get the problem compiling the code at the moment. my patch does nothing, just tries to fix the compiling problem (in default state). regards, aq