From mboxrd@z Thu Jan 1 00:00:00 1970 From: aq Subject: Re: [PATCH] fix broken ACM Date: Fri, 24 Jun 2005 07:06:10 +0900 Message-ID: <9cde8bff05062315067b7a7137@mail.gmail.com> References: <7ae02d710529059790220f4430ef0fae@cl.cam.ac.uk> <9cde8bff05062308227dfd471e@mail.gmail.com> <6b08ec7c5c15235c3fb974971b1638ac@cl.cam.ac.uk> Reply-To: aq Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <6b08ec7c5c15235c3fb974971b1638ac@cl.cam.ac.uk> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel , Stefan Berger List-Id: xen-devel@lists.xenproject.org On 6/24/05, Keir Fraser wrote: >=20 > On 23 Jun 2005, at 16:22, aq wrote: >=20 > > Keir, certainly i understand your point. but this patch doesnt harm, > > anyway ;-) >=20 > We need to understand why a patch is useful before we apply it. >=20 > > one annoying problem at the moment is that if we want to compile ACM > > in, we should modify the value of ACM_USE_SECURITY_POLICY, since the > > current default value is ACM_NULL_POLICY( which is meaningless as Keir > > pointed out ) > > > > any clean way to overcome this problem? >=20 > The way I skip building acm directory in the root Makefile is quite > gross, and won't actually detect if you edit ACM_USE_SECURITY_POLICY. > Probably need to think about ways of cleanly expressing a new build > config option for security policies etc. Then Makefile decision can > hook off of that. There is one solution: define the value of ACM_USE_SECURITY_POLICY in xen/Makefile, then "make" will put its value into acm code (using sed on a "template" configuration header file, for example) Is that clean enough? If that is fine, I am ready to send a patch. regards, aq