From mboxrd@z Thu Jan  1 00:00:00 1970
From: aq <aquynh@gmail.com>
Subject: Re: [PATCH] 1 of 2: default ssid to 0
Date: Sun, 26 Jun 2005 19:04:54 +0900
Message-ID: <9cde8bff05062603045533ebf@mail.gmail.com>
References: <OF925F6D60.79986553-ON8525702C.0012218A-8525702C.001254CB@us.ibm.com>
Reply-To: aq <aquynh@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <OF925F6D60.79986553-ON8525702C.0012218A-8525702C.001254CB@us.ibm.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Reiner Sailer <sailer@us.ibm.com>
Cc: xen-devel@lists.xensource.com, Stefan Berger <stefanb@us.ibm.com>
List-Id: xen-devel@lists.xenproject.org

On 6/26/05, Reiner Sailer <sailer@us.ibm.com> wrote:
> > Message: 7
> > Date: Sat, 25 Jun 2005 20:39:20 -0500
> > From: aq <aquynh@gmail.com>
> > Subject: Re: [Xen-devel] [PATCH] 1 of 2: default ssid to 0
> > To: Stefan Berger <stefanb@us.ibm.com>
> > Cc: xen-devel@lists.xensource.com
> > Message-ID: <9cde8bff05062518394eab73cb@mail.gmail.com>
> > Content-Type: text/plain; charset=3DISO-8859-1
> >
> > On 6/25/05, Stefan Berger <stefanb@us.ibm.com> wrote:
> > > Hello!
> > >
> > > Attached is the patch that changes the default ssid from 0xffffffff t=
o
> 0
> > > as discussed in previous emails.
> > >
> > > Signed-off-by: Reiner Sailer <sailer@us.ibm.com>
> > > Signed-off-by: Stefan Berger <stefanb@us.ibm.com>
> > >
> > >    Stefan
> > >
> >
> >
> >
> > +     for(j=3D0; j<=3D CWALL_MAX_SSIDREFS; j++)
> > +         if ((0 < j) &&( j <=3D CWALL_MAX_TYPES))
> > +             ssidrefs[j*CWALL_MAX_TYPES + j - 1] =3D htons(1);
> > +
> >
> > why dont you run the loop from j=3D1?
>=20
>=20
> because row j=3D0 is the new default ssid and has no types set.
> We start with row j=3D1 and set the "diagonal" types to one.

i meant in the above loop, if start from j=3D1 you can eliminate the
check (if 0<j), because in case j=3D0 you does nothing.

regards,
aq